Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <bdac114d-2366-407a-bfe1-fca2bb035429@suse.com>
Date:   Wed, 25 Oct 2023 11:07:07 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] usb: storage: add shutdown function for usb storage
 driver
To:     Alan Stern <stern@rowland.harvard.edu>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc:     "Li, Meng" <Meng.Li@windriver.com>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "usb-storage@lists.one-eyed-alien.net" 
        <usb-storage@lists.one-eyed-alien.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20231023054111.2744872-1-Meng.Li@windriver.com>
 <33bd0779-bfe7-4c87-8fe6-ea8455df3b6b@rowland.harvard.edu>
 <PH0PR11MB51918DD50651DB6BE937BEA3F1DFA@PH0PR11MB5191.namprd11.prod.outlook.com>
 <3fe5b43c-a5aa-4c6a-8614-03a4d9dd53e2@rowland.harvard.edu>
 <2023102428-zit-quickness-9b73@gregkh>
 <5107f6ca-e972-4af1-a21d-6c95778969f3@rowland.harvard.edu>
 <2023102459-protector-frequency-1033@gregkh>
 <a6bb88cd-0b89-4eb1-b90d-8ad633b7a8f2@rowland.harvard.edu>
Content-Language: en-US
From:   Oliver Neukum <oneukum@suse.com>
In-Reply-To: <a6bb88cd-0b89-4eb1-b90d-8ad633b7a8f2@rowland.harvard.edu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?STJsOFFYSmdic1hjaGhnemdZNzVuNmFrMGVjbW9tTEo5TTZKQnFSSVFsUnN2?=
 =?utf-8?B?UCtPeVpRY2dYV0NNR1RlNDZtZ3NYOEJzQlFhSGh4Y2g1bGFUQnIrU3M0dUlK?=
 =?utf-8?B?RFd2NVZiMDZyWE1IVzJJUTE4ZHNNMWV4U2d2aUorellDaXFrOGVpeitobkdH?=
 =?utf-8?B?SW9ET3FiVCtCcUZBaHlXVENGMG5xMFJib0NLSDZWUHc1SEswdmZla0ZiRFhH?=
 =?utf-8?B?UkhRYWdubjhYbFFVb0JGWVZIRFFsZ00raW5oNkhJd0FKaFBSb0tIMnhCOWFy?=
 =?utf-8?B?b1VJYjIrYjRlZzFkZDJENys4am03cVIwUFMzZlVFSFU3Tkx4VEFjK0h4OHdT?=
 =?utf-8?B?c0l4OGhCNkVHMTVKTXZKeFNMOGczMGpkbndlNjNZcVk4cmpwZHVWZTZuemVW?=
 =?utf-8?B?ZWc4S2pxSkNncitQVkZtWnFYWXdBL3FUUk9vMlp3ZmE1a24xa3Ira0RCRloz?=
 =?utf-8?B?SGd3Uy9PYi9lU25ianhJaHJYRUNZOE9vK0JjOUVDbk5yTWZ2L0UzcjM4Rlds?=
 =?utf-8?B?UTdIaVJBU1FMMGFUNTR3bzBmdjBqc3hLaytaSzNKM09VZ3ZydzBZN2xXQXlQ?=
 =?utf-8?B?SS9vM3lpdjlLeVVWaU01andZNzVHN1EwcmFxY0xKMm9wem9CYTR4OGczQjJL?=
 =?utf-8?B?TGVmMkUyQWNuWWtuelRrSmhSUE8yeHFWd0FRUTliWHoxRGtRYjJLQWExemdk?=
 =?utf-8?B?ajd0ekQ0Ukt3cTl4TlBOUGlFc0RNak5MRFBhQkwzRzRvVGo0ZHNLZFU4SW8r?=
 =?utf-8?B?a3lKbnpyUm10K1FiUFZlUGx3SERaOHFDQms0VitvMU5QUW1ySWxnYWNoNjRY?=
 =?utf-8?B?ZTA4djdXWmZnK0h1MkRVcUZhaXJiYXBpdGdROW4xc0xkRnk1MDk5RWdZVXZI?=
 =?utf-8?B?Q1FwTWExdnpxS3FUTE5SZWNuT1J1eExST0JnWTFDV1lNZTVKUFhHMlRHN2Vp?=
 =?utf-8?B?UWJjZTFsVjlGSER0TDhBWGloMkd0TWIrOTNqRG5kVGxwdkJwT3huaFZERnRO?=
 =?utf-8?B?bGkxN05JcnBhT1ppZDJoUTdxdktJNlVhMTh6Zk92R3RMUjBLMHY0NEhHLzNq?=
 =?utf-8?B?TmxuQXp0bWdodk1RMXlGaWdudDZhMUc2U3R0OWhteGx3bGoweU9OSXlFbEJu?=
 =?utf-8?B?aGhnbVE0ZFk0bklXejBSMk5PTGt2SmtsZjBqR1VtdXF6NThkTUFRWEFFZHZU?=
 =?utf-8?B?NEtkeVNZelBjRVhrd3VSNEhIWU05WGpSeFlscUtIcmFuaXlVeWw4VUhmUjNu?=
 =?utf-8?B?M1ZhZEtPY0lWWnNsMGp4TW1DemNLVVUySDY1L2owK016ODFScmZwdmE0M3k4?=
 =?utf-8?B?N1hqRmk5TnlKclVNWWdubm1LYlBNOVZEaUJtZDR5WjZLVloxUkgyRmMzNnRq?=
 =?utf-8?B?Zkx5UGlDbTdIa3pjanc4YUNlNktRRk1ncy9TcEpLTko4VkJzMzhWczVZcklQ?=
 =?utf-8?B?Y2hTYlFYSm82WmNqekVhTlFzRU1SMlZnSTdPYnoxNUpiUXc5VUNlZFZSVzUx?=
 =?utf-8?B?a1dMOCszSGNlSXNyU3h2Rm5JblZBdCszYzZpMjJQTzlYN3htZFNBSUtTTm5S?=
 =?utf-8?B?VWhTTjc1WVRHMUdleHNJUU1zSkFWMGZUYmJSUHlEVEswMjJoV2M4VzB0eVFz?=
 =?utf-8?B?V09XZHpyZ0M3ZXdjaUU4N0J5aGNsMERuVEJxT0IyU0VUZjN6Yi9nVlkrcUJa?=
 =?utf-8?B?ZE51K0JrcVhPZllzaHM1R0lWbEtQUmo3azZ1RWRxbHYya2hwN0kydnlCWUlI?=
 =?utf-8?B?RDNEYjJwaDl0YVlaQllNdjl1OUVUd0JUS1NvenZDVXR3MzUySitEUHlGNEE3?=
 =?utf-8?B?c282Z2ZGdXdla2VURGh0YVd1dndLQ3RndFpBRXlNTE5ic3NOQXZ6RVcrR1hk?=
 =?utf-8?B?aFdlTkFIVDJEMjFNZk9obWRXazZUODRBRXpQZGZVbjRLMzMvWjhHckRnSG9V?=
 =?utf-8?B?M2lCUVdoWkhIZE5FdnJNSXYxTktlbjlrNjRtdklJUDEzU1krV2J2TDBFRkJl?=
 =?utf-8?B?MXpiZmw1dFVzdTFsUmtacUJURGw1RENWeFYrL1k1ekNVZ0MrakVmcXdBU0RM?=
 =?utf-8?B?RnY1bC9tNU53cWlMOUpYTU9wU0U1c0FBNlNNQWlGY25DbHlCcW14cGVYMm9P?=
 =?utf-8?B?cXpYRG1ydlYvMnAwQkJWMTFCbjVJakNCVjZ5c2k2Q2tZdEdFYitiNnJSUzMz?=
 =?utf-8?Q?iruL5Em7OIMtP+WAdLiZjT2HB958cRBVoVSlfGDuwWMN?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8c10aa94-8e29-41f5-102b-08dbd539c4ef
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6467.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 09:07:10.1529
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pRVAvGCDquLPDfgJzz0LH4j/5Yo9LSrvG3C79hewAgCDYA1BDmxwm3qVMb4QUOxVGidyLGD+o9DnCDzLPM5Y/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR04MB9483
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:07:27 -0700 (PDT)

On 24.10.23 21:23, Alan Stern wrote:
  
> Since USB class-device drivers don't have ->shutdown callbacks (there is
> no shutdown() method in struct usb_driver), they don't know what's going
> on while a shutdown or reboot is in progress.  All they see is a bunch
> of errors.

Does this solve the issue? You'd have to flush the cache on the SCSI
device further down in the tree, if you want this done properly.

	Regards
		Oliver