Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Message-ID: <74296600-6d91-4353-a9f6-fdb1ed724a59@intel.com>
Date:   Wed, 25 Oct 2023 11:22:28 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] amd/pds_core: core: No need for Null pointer check before
 kfree
Content-Language: en-US
To:     Bragatheswaran Manickavel <bragathemanick0908@gmail.com>,
        <shannon.nelson@amd.com>, <brett.creeley@amd.com>,
        <davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
        <pabeni@redhat.com>
CC:     <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20231024182051.48513-1-bragathemanick0908@gmail.com>
From:   Wojciech Drewek <wojciech.drewek@intel.com>
In-Reply-To: <20231024182051.48513-1-bragathemanick0908@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bndWNkxQdEFxWGFvQXZ1Tyt5SndmSXRzOFJ1bjNZdXZ1M2dseUZRZ3hWME9k?=
 =?utf-8?B?bzJxZGQyQ241ZjE0ZW4xa2V1aHlxTHMrdGxpMTFDemlwMUlxNzJreWFSaGlx?=
 =?utf-8?B?RFRzejN4RkFZTS9QVWJPSEpKUW1FVjlzY0tueUVjaldNVkJBeDlDMUMwbmts?=
 =?utf-8?B?SXdaR0pFZUNNaXQrYk9YNEJlWHR6Q0s4OGl2eXd3OCtDY0tSb1MzNWhjMTM5?=
 =?utf-8?B?dVcyQTRlYTgrTVZ6UmQ0ckxIZEtkMzBDSURkVzdiRmZUeXBHTFNtSlJsOVE2?=
 =?utf-8?B?aXowbDZqYXJrWnpxdWtJYzkzQkszbDdSMmpmNjBnbE4va0pFc0c5RGZrazVn?=
 =?utf-8?B?aDBTMXVLS0xRYk1jWVF2UXRzT2YyMnRodUxpY05rQy9rSFVoR0xHcXFRUW5a?=
 =?utf-8?B?RVZHV25BdjB6Y2ttaVVPOHF6MW5kRExOanlHejJ4ejlkWDUvVlB4QVB4WVkz?=
 =?utf-8?B?WDZpb3M2ZzUwT213VDJUSUVpaDJBNlRuMVpXR29NWkhSNTg2Y3FDbHl6bmxm?=
 =?utf-8?B?OEI3UHFndi9xQkE4TDZWbGRVKzhsN1l5UnhERks4WXEzbTEzcE5VUjJmdnpq?=
 =?utf-8?B?T2p0UmgxeTJBSHVjUm9nZHdaWWFiTnh3Z2dGVWRZQk4xRXFoWTlZQ05XT01t?=
 =?utf-8?B?QzJYTU9EWGtYazk0REphanJtY0VjTnBkOThxVlFxR1dreFhzb3owOFVtSDV4?=
 =?utf-8?B?S0ZOeDBvL2JLZitBY2NiVGlhRUNoZi9mQjE2ZWUzZHBSTk5JVEtpUVlaclNh?=
 =?utf-8?B?VjZodTFaSGlsYkZiWGJLeUFRVHBsVlh0K3RYTWJWbnllemowWjJBL1ZaUzAx?=
 =?utf-8?B?VnJOb2JIbTFiRzFpSFZCL1BoQzZtREdyZ1NuVkxFNEQvN3VFcFB0SmNabmFh?=
 =?utf-8?B?RUEvMlQxa2Y4dks1cm5QY2VscGNEamFQR0U4TEUzN2h0WXA5OXRhYUNWNkRN?=
 =?utf-8?B?Y256Yzc0ZW1FLzJRVG5Vc1AzejlJNGt0Sm5saEo4Zmc1aWxCb3JUb1cxdnVy?=
 =?utf-8?B?R1pyQ3VucGF3U0RCSHRqWEI3NWlEaXVkdllOY2RPZnN1NDBnMTNOckI4eW9m?=
 =?utf-8?B?UDNhdDQyOU0vWURSZVdjeXhwcHAyS2dFVmVQbTRxVzhIMkJYMUlEYW1kdnpV?=
 =?utf-8?B?QWNhOFdOelQrd1B1akNpYnBEYjc2aDROVS9DTVNxUmFjRzY1a1hDQUs0QytP?=
 =?utf-8?B?N2QyVDF5b2M0dDVwdjkwcDljL1FvVmRjUDNlUG13WnMxbkRnQ29OUWxLZEI0?=
 =?utf-8?B?VFRPcDgyTStvT2wzWlNMUE52WHlHdlZCN01RdlhTdmNRNkd4Rnpybkw2ZzZ6?=
 =?utf-8?B?TThrWDVMOXJZOW1aQXhaT21mbFVOKy9vYk8xUFlHTG95T1I4aGJDdGFBKzQ0?=
 =?utf-8?B?ZUkwSkhLWWNsUDNEVjF4bnl4SFh5d0x1bjA3UXZSY2tyY1JNZ0tHLzU5aWFT?=
 =?utf-8?B?bEVCQXpxaW41b3Z6Q2hDcUY5Ly9wdGsvd3hqK1hweStHYnJxMzJzMjBuK3Nv?=
 =?utf-8?B?UHk4dWxNUm5PdS9EUGdjSEwzMXVXTzBtWGZLclFPQUVzcnBJdU5JOU5yUTJY?=
 =?utf-8?B?cWIxVGU3UVV3bFRlNjdlSHI1QU5haXA1OE55VTBMR2ltdzAzRlRweGJETkVp?=
 =?utf-8?B?VFBwSlpqaEtJb2VraTl0eFZ3UE1SZVVRT2poVUVmWmYxMFdDbSsyYTQ3dWgv?=
 =?utf-8?B?WllFVVlOUEx5Z210N0MxUnloUi9hY3RhMlNvazBwSG1CcWNYMUhrUHR1TUpo?=
 =?utf-8?B?ajB6a2ZGNkdxMVY1WWdDQUpyaXZYa3JUazBjdWJnSW0zRUVLZ3lwNld6bTEv?=
 =?utf-8?B?b2p2b1BDSFB5aGkrbEtrdkkzbWR1VVJWdkFQNmdSWGp1ZWsrQm1oZ2VvNk1y?=
 =?utf-8?B?YUQwQ29kS2JpeTI4d1ZFb1hDZ1FGa1hnSXVLTWkzSzFmT2taMWhxWDJnNE10?=
 =?utf-8?B?RFppeVNJd25mMm9vVktmSGJNb1lZdmdxWDNMSFlWM1V2RmtqU3ZuSmZuai8v?=
 =?utf-8?B?R0MrQVRFWUFpRzB3V3RRV0NsU2lDdWtjb3NYdzI0Q242b0UycVIwVkwvSzlB?=
 =?utf-8?B?RVpDNUJVQkdYclBickU3d1NNcE1UMStEbzN5NHMrbElLZ1F3dnJtU1RibVF3?=
 =?utf-8?B?WFBOR3NrZmgrakN0UlNoY2tBV0RkbmJTTWVtQXljeWhEWUxudmNsaXBGS1FP?=
 =?utf-8?B?Rnc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 079e7b49-9777-42c4-06bf-08dbd53bec37
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB5776.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 09:22:34.9613
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2u1InmY6qsTysRmVP93T035rklrK54BwMu4WdVXbwiKWb64OaGF2zjLNuhS3TJX3A6M8XVAhYektqK0dqN3FDpjcmetFS1qB0JuuBBtHzFo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6139
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:22:59 -0700 (PDT)


On 24.10.2023 20:20, Bragatheswaran Manickavel wrote:
> kfree()/vfree() internally perform NULL check on the
> pointer handed to it and take no action if it indeed is
> NULL. Hence there is no need for a pre-check of the memory
> pointer before handing it to kfree()/vfree().
> 
> Issue reported by ifnullfree.cocci Coccinelle semantic
> patch script.
> 
> Signed-off-by: Bragatheswaran Manickavel <bragathemanick0908@gmail.com>
> ---

Thanks for the patch!
One nit, you're missing a target tag. It should be [PATCH net-next] since this not a fix IMO.
Reviewed-by: Wojciech Drewek <wojciech.drewek@intel.com>

>  drivers/net/ethernet/amd/pds_core/core.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/ethernet/amd/pds_core/core.c b/drivers/net/ethernet/amd/pds_core/core.c
> index 2a8643e167e1..0d2091e9eb28 100644
> --- a/drivers/net/ethernet/amd/pds_core/core.c
> +++ b/drivers/net/ethernet/amd/pds_core/core.c
> @@ -152,11 +152,8 @@ void pdsc_qcq_free(struct pdsc *pdsc, struct pdsc_qcq *qcq)
>  		dma_free_coherent(dev, qcq->cq_size,
>  				  qcq->cq_base, qcq->cq_base_pa);
>  
> -	if (qcq->cq.info)
> -		vfree(qcq->cq.info);
> -
> -	if (qcq->q.info)
> -		vfree(qcq->q.info);
> +	vfree(qcq->cq.info);
> +	vfree(qcq->q.info);
>  
>  	memset(qcq, 0, sizeof(*qcq));
>  }