Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2430120rda; Wed, 25 Oct 2023 02:26:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IERszAeMal4g59QgFs1nPt2INUVnnGofUbrVI80NNrgIoisany3Uk94odvoCUOZsqQDlilG X-Received: by 2002:a0d:e84c:0:b0:5a8:277f:b378 with SMTP id r73-20020a0de84c000000b005a8277fb378mr14043987ywe.1.1698226019546; Wed, 25 Oct 2023 02:26:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698226019; cv=none; d=google.com; s=arc-20160816; b=idZBVTeUwWvgCtuk4osRhD2nVmNajmXwV1/QqVgzSLsbeC20vbMeD9pZY4BNnvkcET zR9JPLjMrDPm3NaMCYmhR45B3je7PFvnSswSohVG2ayNyXWyYbuZSjO3YySQ5zpdp4ks rxfr3rdYIkVHXknU8MRpDFIq0H741W4irENHvoKmV7sh69kLtKqnv+l3o+bDuutFuMa5 szXMcz7KFq7GDtblpt2To9nGd5uU1OnS1fZu85RAEfxPZsc6qpHZvd4wGzZ1C9toFQjY YxtrNIippRl5JZbFJQt/48cRnoAdu9Tx5Q4yitH9DmaED5lJTYJjLZwOxc5LlI0qz9ss 5HmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=kwNf+HfrvO15GE3+T/ew+zd4zccaBc9e3DFddPuEuqk=; fh=ZlPM2snsRlHeZinS2p3XnvgOwVXUgHKIKtjLGwzfHjA=; b=iTTVzroEi7/bDtvPSSub8jP0TOMBgoB2vG09HmYni8qb6ksWqck1ia1eycTzK+GmqI dqYHWPCZOzeyNCVyE/gpDZ2Uv8vB+ZmkpnTpsUWOLW2CIVqqfwMXqWoWz3IhHag1J8yf fE+qBkZcXZg/IC0uYd/N4wc4UTue/zZMJFvQwaqU0VOHoiXcUI9/+wR+1KVBiSCeFwu3 YvVVdF6kI10IOZlMNpeCQuSDDNfgEq7UuJZAqPb9qLz1vWQNyXzFcv/JtJMjQ1qoo7vX 2jBLZcOoP3j3WydBl7EPlzt/wkj99T4XU/Otrafu2FgB4qlnsFNN3YJn3wYD8po0xl+O tfVA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tULDT4F4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id w73-20020a81494c000000b00585e7c0bcf7si10170740ywa.86.2023.10.25.02.26.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 02:26:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=tULDT4F4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 0FBD98098BA4; Wed, 25 Oct 2023 02:26:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233692AbjJYJ0s (ORCPT + 99 others); Wed, 25 Oct 2023 05:26:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231794AbjJYJ0r (ORCPT ); Wed, 25 Oct 2023 05:26:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0FC88F; Wed, 25 Oct 2023 02:26:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D99D1C433C8; Wed, 25 Oct 2023 09:26:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698226005; bh=4n0iQGryR3l11ivfAXSZJrCU7Nk2I5Jy+sv+NdwUasQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tULDT4F4BuJuij+PaCntRR4+ii5P140m7lR+dfTCphuE2Q+ux46tUY8wcaQ6uXiMb pLYWpIqLoR9/kKBHvCCvRkzTR3OGVnmxBc9TDnZkHYNEJqB0ZZPB9y5VXOCuDtB561 7PB4243yWqd+wmudvFJX/c16YrRlC+opihHGC5/SMlUkJevQCZpDCqePPdRYcGj31p JzIr9+RKEI7INPqB8H1fiChgl5cpBDZ3RL2ct7XoslhxFnwSEJ5jjWbyX676rEQLJA n6jYty+uYu4cQ5gYBLp2h18fOBAZnPgC/CmwiXq2VateWeAW0vdbpIT3/c5AFUbanw 6EwJxQVsC8z3Q== Date: Wed, 25 Oct 2023 10:26:39 +0100 From: Lee Jones To: Jeff LaBundy Cc: James Ogletree , James Ogletree , Dmitry Torokhov , Rob Herring , Krzysztof Kozlowski , Fred Treven , Ben Bright , "linux-input@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4 3/4] mfd: cs40l50: Add support for CS40L50 core driver Message-ID: <20231025092639.GL8909@google.com> References: <20231018175726.3879955-1-james.ogletree@opensource.cirrus.com> <20231018175726.3879955-4-james.ogletree@opensource.cirrus.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:26:57 -0700 (PDT) On Tue, 24 Oct 2023, Jeff LaBundy wrote: > Hi James, > > Just a few trailing comments on top of Lee's feedback. > > On Wed, Oct 18, 2023 at 05:57:24PM +0000, James Ogletree wrote: > > From: James Ogletree > > > > Introduce support for Cirrus Logic Device CS40L50: a > > haptic driver with waveform memory, integrated DSP, > > and closed-loop algorithms. > > > > The MFD component registers and initializes the device. > > > > Signed-off-by: James Ogletree > > --- > > MAINTAINERS | 2 + > > drivers/mfd/Kconfig | 30 +++ > > drivers/mfd/Makefile | 4 + > > drivers/mfd/cs40l50-core.c | 443 ++++++++++++++++++++++++++++++++++++ > > drivers/mfd/cs40l50-i2c.c | 69 ++++++ > > drivers/mfd/cs40l50-spi.c | 68 ++++++ > > include/linux/mfd/cs40l50.h | 198 ++++++++++++++++ > > 7 files changed, 814 insertions(+) > > create mode 100644 drivers/mfd/cs40l50-core.c > > create mode 100644 drivers/mfd/cs40l50-i2c.c > > create mode 100644 drivers/mfd/cs40l50-spi.c > > create mode 100644 include/linux/mfd/cs40l50.h Just popping along to say; these are excellent comments Jeff. Thank you for your review. -- Lee Jones [李琼斯]