Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
IronPort-PHdr: A9a23:CFKR8RQniMpNkGXxX7O91BFdstpsou2eAWYlg6HP9ppQJ/3wt523J
 lfWoO5thQWUA9aT4Kdehu7fo63sHnYN5Z+RvXxRFf4EW0oLk8wLmQwnDsOfT0r9Kf/hdSshG
 8peElRi+iLzKh1OFcLzbEHVuCf34yQbBxP/MgR4PKHyHIvThN6wzOe859jYZAAb4Vj1YeZcN
 hKz/ynYqsREupZoKKs61knsr2BTcutbgEJEd3mUmQrx4Nv1wI97/nZ1mtcMsvBNS777eKJqf
 fl9N3ELI2s17cvkuFz4QA2D62E1fk4WnxFLUG2npBv6C8bvvHL7psonwQ24L8nGY58+B2itt
 aRGSBzlhAE/HiUI7E7SmPxxiqljpS/09Hkdi4SBR6bKd+MkYeDjWPxGaFcYf/gLCwpPJZGTV
 ogrX7UFMuN9sbjf5GtQrgOuAzCUWPLI7z9MjSLr/o83kNYELRrAhFwEI/U1km3rp/Xvc6MPC
 vmE0vKL1m6cfdVH5S3j85LoVC09/PKFbIxsduTR0Hk0EAbMkW28m4bObmjN9MgMnm+f3udle
 9iRhUMY9DosiQO1/9kio67JhKww4W2D1Stg2oIpI42SWmRLRPmvRcgYp2SbLYxwWsQ4XyRyt
 T0nzqFToZegZ3tiIPUPwhfeb7mKf4eF4Ru5CKCfOz5lgnJidr+lwRq/ogCsyez5A9G9y00C7
 jFEnd/Fqm0X2lTN59KGRPpw8gbp2TuG2w3JrOARCU4unLfdK5kvz6R2kZwWsE/ZGTTxllmwh
 6iTHng=
IronPort-SDR: 6538e325_vEal4lnTu32ysoXXPPkFmYXiAftA6WmewohagMT40cLgkXK
 G6s6YC3m5gyCrw2lp8fRwb/U4vt0zSy2covv0kg==
IronPort-PHdr: A9a23:x5yH0RbTUb4ZIAlKXeBzA5v/LTFg0YqcDmcuAucPlecXIeyqqo75N
 QnE5fw30QGaFY6O8f9Agvrbv+f6VGgJ8ZuN4xVgOJAZWQUMlMMWmAItGoiCD0j6J+TtdCs0A
 IJJU1o2t2ruKkVRFc3iYEeI53Oo5CMUGhLxOBAwIeLwG4XIiN+w2fz38JrWMGAqzDroT6l1K
 UeapBnc5PILi4lvIbpj7xbSuXJHdqF36TFDIlSPkhDgo/uh5JMx1gV1lrcf+tRbUKL8LZR9a
 IcdISQtM2kz68CujhTFQQaVz1c3UmgdkUktYUDP7ESrQJmoszva7PNZ+jueDePZR+5oVm6hw
 qdoRRPOsA4cBiIW9XPni8p7tKdm9UHExVR1lqnzP8KMbuU9QIbyIf4nHEt/BJp3WQtTLbq/S
 9tQC+UEGPhpjcrN+VgWvR2HPVW9I8bvzjQVm1zU0O4I9tg6F1mW+DAHJPAXj3/0tpLxKfwLY
 P7uj7KTkiflfs9MxyznyK71bk0iqMCyQbVecdPh0k4qHhz9omeagt2+ZxG518kKt1mW6sRaa
 +yCtDEc9ipKuAGxyO4Liovno6kojXDK7D993IBlD8+SeGtcaov3WIsVtjudMZNxWN9nWWxzp
 SImn6UPooXoFMBr4JEuxhqabuCOX6TSv1TtTu+MJzd/in9/Pr6y1F6+8kmln/X1TdL8kE1Lo
 SxMjsTWuzgT2gbS5MmKRro1/kqo1TuVkQGGwu9eKF0yla3VJoRnxbg1l5EJtl/EEDOwk0Lz5
 JI=
IronPort-Data: A9a23:IcEOfqI1kUBbXCbLFE+RVZElxSXFcZb7ZxGr2PjKsXjdYENS12cFm
 2EcWzyPa/+PNmb2c9skYIrj9RkBsZKDzdNhTQEd+CA2RRqmiyZq6fd1jqvUF3nPRiEWZBs/t
 63yUvGZcIZuCCW0Si6FatDJtWN72byDWo3yAevFPjEZbQJ/QU/Nszo68wICqtAu2YPR7z+l4
 4uo+JSHYgL9glaYD0pNg069gEM31BjNkG5A1rAOTagjlEPTkXATEKUeKcmZR5cvatAJdgISb
 7+rIICRpgs1zT90Yj+WuuqTnnkxf1LnFVPmZky6+0SVqkMqSiQais7XPReHAKtdo23hc9tZk
 L2huXEsIOskFvWkpQgTb/VXOzt1Lfd5w5LfG3eUmt6I6Wfla0X+/Nw7WSnaPaVAkgp2KXpL6
 eReJSAGblaNneurxrK8ROR2wMguRCXpFNpC4TcxkneAUqdgGMqcK0nJzYcwMDMYg8FFHf/TY
 4wGZDt0dzzJYgZCMREZEpsjmueviHTlNTFVwL6QjfNnszSClVEujtABNvLqJvnJY8ZPnH+So
 znt/U3XDVYfMcWQnG/tHnWEw7WncTnAcIsWGa2x8PJnmnWWx2waDBwdRF39qv684ma0QdtCL
 UEO0ikjt64/8AqsVNaVdxSjvFaHswQaVt4WFPc1gCmVw7fQyx6QG2xBSzlGctFgv8gzLRQm3
 1mIktfBBDtgvbSPQ3WNsLGZsVuaMC4ZN24DTSwJVw0I55/kuo5bphfGVMpiFuixh8DdHTD23
 iDMoCUg750IisgE/6a251bKh3SrvJehZh81/S3ZVCSu6QYRTIyiZ4ru51HA8f9KIYCVZlaEt
 XkA3cOZ6YgmDomWlSqCQM0OEauv6vLDNyfT6XZ0E5cJ+DOq9HquO4tX5VlWJE5uNtsDUTDuZ
 0DXtEVa45o7FHmtabR+S4G8EcInye7nD9uNfunJY9xSY55ZdRSA4ihqaEiMmWvqlSAEj6AlP
 r+JfMCtEzAeCKJ63HyxXehbzLxD7iU/xmfUXrjg3Rm93LafIn6IIZ8MNVqUMbs46IuLpQzU9
 5BUMM7i4w5SSuLzSine9YoCKxYBKn1TLZrupeRJeeOZZAlrAmcsD7nW27xJU4hkmblF0+TF5
 HewXmdGx1flw37KMwOHbjZkcryHdZJ+q28reCI3MVu21nwLf4mi9uEceoExcL1h8/ZspcOYV
 NFcJp7FU6sKE2uWvm1HMt/jqcppMhqxjB+IPy2rbSJ5c5MIqxH1x+IItzDHrUEmJiStvNY4o
 7qu2xmdRpwGRg94C93RZu7pxFS01UXxUsooN6cRCogCJBff48JxJjbvj/Q6BcgJJF+RjnGZz
 guaS1NQ7+XEv4Z/opGDiLGmvrWZNbJ0PnNbOG3HspewFy3RpVS4zaF6De2nQDH6VUHPwpuEW
 9l79f/GDaA4rA54iLYkS7dP5oAi1uTrvI5fn1hFHm2UTlGFCYFAA3ih3OtPv51rwo5I5A69X
 2zW8NxaJ4eMBtLBFWQVBQs6b9as0eMftSnS4M8UfmT7xn5T15iWXXpCOyKjjHRmE4J0F4c+0
 MEduMIywC6uuCoAa9qpoHhdyDWREyYmTa4iiKA/PKbqrQgaknd5fp3WD37N0qGlMtljHBEjH
 W6JufDkmb9Z+0vldkgzH1jr2c52p8wHmDJO/W84C2W5oPj3rd5p40QJ6hUydBpf8Ttf2eEqO
 mRLCVx8FZ/TwxhW3vp8T0KeMCAfIiaG+37B6UoDz0zYaEiKalbjDkMAPcS1wURI1F4EIxZ6+
 umDxXfHQATaWpj7/hEPVH5Pr93hSt1M9TP+pv23IvTdH7QHZWvKv6z/Q0sJtBrtPu0pjmLlu
 +RB3bh9eI/7BwEqsow5DIir6rACei+hOV5EY/Ftw/4OFzvufDqzhDu8EGGqW8Z3P/eR21SJO
 89vAcNuVhqFyyeFqA4AN5MMO7NZmP0I5sIIX7HWeV49rLqUqwR2vKLq9iTRgHEhR/Nsm50fL
 rz9Wi2jEGvKo1dpgE7I8dd5P1Snbek+ZAHT2P6/9MMLHckhtMBuaUQD7aumjU6KMQdI/wOmg
 y2bXvX4l9dd8IVLm5fgNo5hBA/ucNP6a7muwTCJ6t9LaYvCDNfKuwYrsWLYBgVxP4YKetFJh
 L+I4c/W3kTEge4MaFrnuaK9TotH2cbje9BsEJPTDGJbli68SsPT80M922SnG6dozvJZxOeaH
 jWdVuXhVOQoS+98xWJUYRdwCxwyKbr6RYa+qDKfr8ajMAk80wvGJ4n+rXTCMGVWWQkPH5jMG
 z7EheunyYFdnrRtGS0rOvBCKL17KW/FRqEJWYDQtz6ZL2/wmXKEmOLouiQB4AHxKEuvMZjF8
 7OcYTambzW0mqXD7O8BgrxIphdNUUpM27ghTHwS6/tdqm6cDldfCc8/LJ9fKJVfshKq5aHCf
 DuXMVcTU3Tsbw9lLyf5zs/oBDqEJ+o0Pdz8GDwl0mWUZwqyB6KCGLFRzThh0VgnZgrcyPybF
 v9G9k3SJhSRxrRbddQX7NG/gsZlwar+7VAM8kbfjcfzIkg/BZMn6X9fJzdOBBf3S5z1qEb2J
 GYLHDEOBAnxTEPqCs9vdkJEABxT7nul0zwsajzJ29rF/ZmSyOpb0vDkJuXvyfs5Yd8XIKIVD
 2bCL4dXD7t6BlRI0Ufxh+8UvA==
IronPort-HdrOrdr: A9a23:RZ8ZcKpE7yzNIpJcSDx02wgaV5oveYIsimQD101hICG9Ffbo8f
 xG/c5rsiMc7Qx6ZJhOo7690cW7Lk80lqQFg7X5X43SODUO0VHARO1fBO3Zsl7d8kXFndK1vp
 0AT0ERMr3N5AhB4PoTomGDYrMd/OU=
From:   =?UTF-8?q?Michael=20Wei=C3=9F?= <michael.weiss@aisec.fraunhofer.de>
To:     Alexander Mikhalitsyn <alexander@mihalicyn.com>,
        Christian Brauner <brauner@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Paul Moore <paul@paul-moore.com>
CC:     Daniel Borkmann <daniel@iogearbox.net>,
        Andrii Nakryiko <andrii@kernel.org>,
        Martin KaFai Lau <martin.lau@linux.dev>,
        Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
        John Fastabend <john.fastabend@gmail.com>,
        KP Singh <kpsingh@kernel.org>,
        Stanislav Fomichev <sdf@google.com>,
        Hao Luo <haoluo@google.com>, Jiri Olsa <jolsa@kernel.org>,
        Quentin Monnet <quentin@isovalent.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Miklos Szeredi <miklos@szeredi.hu>,
        Amir Goldstein <amir73il@gmail.com>,
        "Serge E. Hallyn" <serge@hallyn.com>, <bpf@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-fsdevel@vger.kernel.org>,
        <gyroidos@aisec.fraunhofer.de>,
        =?UTF-8?q?Michael=20Wei=C3=9F?= <michael.weiss@aisec.fraunhofer.de>
Subject: [RESEND RFC PATCH v2 07/14] drm/amdkfd: Switch from devcgroup_check_permission to security hook
Date:   Wed, 25 Oct 2023 11:42:17 +0200
Message-Id: <20231025094224.72858-8-michael.weiss@aisec.fraunhofer.de>
In-Reply-To: <20231025094224.72858-1-michael.weiss@aisec.fraunhofer.de>
References: <20231025094224.72858-1-michael.weiss@aisec.fraunhofer.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ODN2cm83K2NuK3JuZHhqSGR4SFJtTkx3bUNzWFJrUFJNK0t2Rzg4KzhSSWZz?=
 =?utf-8?B?V3Y3VGFRcnJsUUM0S2h0ci9hQnVZdkdPVWJ6YXBDUlNUSjQxVU5DWjFBczhw?=
 =?utf-8?B?cWtPUjVzNDZ1RFYxMEh1UStTSWl4ODc3WjdxQmsvRGZIZzRoUlJMbkNNN2dD?=
 =?utf-8?B?Z3hDUGtxSlVSVzlxekg3N0ZmNXBkZFB2VkwzVkpseTVuSTUybFRGRjFnTnBE?=
 =?utf-8?B?OVJvUkhocUt4TW9CNDNaSDRabWtSMTNMR2tHK1N3LzFYckNuR09yMTQzVjVE?=
 =?utf-8?B?N3BucldldkpjNTJYdi9LTFhDWTAyVnpwWmNMYWR6SElIOG42aytJelNiU1Iy?=
 =?utf-8?B?OGZUWVBxa0ZMTEdFc2JqVW9JTE9YM21WNWx1a0ZQeU5ybGlHVUdCTVFQa3BC?=
 =?utf-8?B?eCtsUTZaMGRvQ0g2WkxSL3dsdWN0dWtlUGorRmpHZ2plaG1PT042aVdRMFlt?=
 =?utf-8?B?bktZU0M0YVZGY0lqaU10WEFtNkVVNFA3RFBZVEFBVllsZ1hTRzZjd3hsK3hB?=
 =?utf-8?B?cFAyKzFyY0dzVWw3NGNtMDcvSXFSTnBGZU1Cd2E5UWk2dEpOS2wybVdEaWwv?=
 =?utf-8?B?MDd4YlBuQlk3aXdraUx3Ry9JRmg5VWI3bHU4RWxQYzB5VDkrNDhRNWk0VXND?=
 =?utf-8?B?QWNBd2hpcWhyRVd0NGVmWWdBcmRBMUN0NlUycXB2U0NUREpobENtVE9QUUhC?=
 =?utf-8?B?N0pwcHd4Z093RGI0cUFxcmdvejdVaDNibVNoYUNvdzhrUTRrek9UVytCKyts?=
 =?utf-8?B?cUR4LzU0bzFzZVBndXlsVjJ3SGl2RlUxSHJNZ0psRzE4d3ZoME8rTWl5c2Jw?=
 =?utf-8?B?VkY3ZmJ2eE1PUElrcFhreG5JUmhNNzFjY3NFQUYzdjJqaldMdW9LaC80UzJi?=
 =?utf-8?B?NHpWZ1AwNCtRR2dpN0VzZHZKa0R1dkRYNVpnN1kvTVQvSXgwZyt3eU9pOUFM?=
 =?utf-8?B?R0FJR2cxN0syWithK2cxNVUzUnJrMEVVc1pkVTA5S05lMjR3Y0dlY1lvSkJX?=
 =?utf-8?B?WGxta2JjZUNzZkVMS3piZmw2SUNISVlKSHNqdWJiMjU1YWtFbmE4ZW9Pa3Q2?=
 =?utf-8?B?VWVib0RuQnB5OG5qbW9pR2wwTVdMQmt0cVpScHFqUXd4RnNPV0F1c0hDL2pT?=
 =?utf-8?B?QW9DZHdNbzgrVkV5WUtlVjhvTGpQT3lnVk5HRVNpdmVJZW1kYldOcFRBM0RC?=
 =?utf-8?B?S09ONkNvdExkRzlJVmVZTU5xRlY5cXpHd1F5d3VFcHd4SWF3ZUxvUWNYblAx?=
 =?utf-8?B?SHQrTzgxbzJhWEN6blBnNnVXS2p3T2hQWkdjZzVrVjNhR3VrUVkzT2J3TXpJ?=
 =?utf-8?B?bk93Sm5yelVqSGZKK1VVRjFCcW5UM0hFVXA3dHh0UlY5VXZmMFdkeFlQVlJn?=
 =?utf-8?B?Uk5BVUZab2RkQ2grRFhwZVpQNVhyYXJpSWlGek00TWhCOGorU0o2ZXRIUEc3?=
 =?utf-8?B?NmxqVlhNQTFmaWw5THdVMURTSExxUE5EVEM3T0FLL1pmWUowVGtRR1JnMjlL?=
 =?utf-8?B?MFJGeVZXQm5KbXZXcUFqdHBzRTgzRmRFcnFmY2ZOcFhNeG5TcjBkbHRZWDJG?=
 =?utf-8?B?S2IyQVNUS2lVQWtrWWU4a250Yy8zMUt1a2ZlZUJWR1ZsSDR4R3NneXcrNkt4?=
 =?utf-8?B?UGtNYWVONURrcGYremNpMkc5MlZCekpsTlJqSTl2UXFiK1B6YTBIem55blBU?=
 =?utf-8?B?L2ZiOHZRYzU0ZUZ3dmV4VG4zWHBzNUNtRWhtL3FBbUtDVzh6WU5KK1l3YXJy?=
 =?utf-8?B?R2FYcTh3MWxaSHo1eHVJUmNBNms0dnFXeFF5OTNvQkJtSE5PMXBxUFRsRXYr?=
 =?utf-8?B?dHlTZG9qYzZCdk9YemRYelBwMVVwejFFUEs4WkVrQ1BEa1g1M1Nna0wrV0Jh?=
 =?utf-8?B?amNONFB4THpIZjY1MlpMYjI3RUpTamxnbjAzSG52a0gwek5mYVZaN0ZiZXg0?=
 =?utf-8?B?RW1CREJjNGw5SWNUa2Fndkx4c0dFN29La1NZc2dJaVkva0poNENzSUh2RC9j?=
 =?utf-8?B?Qit2UURxRVl2N2wzdGZoYXBTSWozRzA4NG1DNXpMN3oxLzRrTzZmaFcvVmxT?=
 =?utf-8?B?TjRQbGV0b0ZtK05MZEJub0FiVUQya2hNd2E0cUFudmFNRnNXMXhUd0FPSVE2?=
 =?utf-8?B?b01VTkhWdzRiMkg5ZmQ3eHU0YVZ3UGVaK2dGS2xtZkFGNGw0TklrRHVaMCsy?=
 =?utf-8?B?eGVuZDAxSVE4Y2tVVUVoNFJYN2dSOGZIdG56anNONk5LMG1Gb2EwbWNFMkJM?=
 =?utf-8?Q?nF4eBX4mv9OYcr4+OFjYK3pqKsPC5UsuxlZdnTcQlI=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 1b2dd8f3-608b-4c5a-1e21-08dbd53ec65d
X-MS-Exchange-CrossTenant-AuthSource: BEZP281MB2791.DEUP281.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 09:42:59.7039
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f930300c-c97d-4019-be03-add650a171c4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BhSYmiedWO3oUym7gS3eVavdGcHH09CWT+7c0prcN8iiPWCBz8kMf/eF17UFrRF7pCRGwbXw5Fiu2V5HpO8hXH6H5VQdpll8ps7A+M1FerIWv0J4BEC9tPf4bjJVpoRP
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BE0P281MB0116
X-OriginatorOrg: aisec.fraunhofer.de
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 25 Oct 2023 02:44:48 -0700 (PDT)

The new lsm-based cgroup device access control provides an
equivalent hook to check device permission. Thus, switch to the
more generic security hook security_dev_permission() instead of
directly calling devcgroup_check_permission().

Signed-off-by: Michael Weiß <michael.weiss@aisec.fraunhofer.de>
---
 drivers/gpu/drm/amd/amdkfd/kfd_priv.h | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
index fa24e1852493..50979f332e38 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_priv.h
@@ -38,7 +38,7 @@
 #include <linux/seq_file.h>
 #include <linux/kref.h>
 #include <linux/sysfs.h>
-#include <linux/device_cgroup.h>
+#include <linux/security.h>
 #include <drm/drm_file.h>
 #include <drm/drm_drv.h>
 #include <drm/drm_device.h>
@@ -1487,9 +1487,8 @@ static inline int kfd_devcgroup_check_permission(struct kfd_node *kfd)
 #if defined(CONFIG_CGROUP_DEVICE) || defined(CONFIG_CGROUP_BPF)
 	struct drm_device *ddev = adev_to_drm(kfd->adev);
 
-	return devcgroup_check_permission(DEVCG_DEV_CHAR, DRM_MAJOR,
-					  ddev->render->index,
-					  DEVCG_ACC_WRITE | DEVCG_ACC_READ);
+	return security_dev_permission(S_IFCHR, MKDEV(DRM_MAJOR, ddev->render->index),
+				       MAY_WRITE | MAY_READ);
 #else
 	return 0;
 #endif
-- 
2.30.2