Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   "Balas, Eliza" <Eliza.Balas@analog.com>
To:     Rob Herring <robh@kernel.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Derek Kiernan <derek.kiernan@amd.com>,
        Dragan Cvetic <dragan.cvetic@amd.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: RE: [PATCH v3 1/2] dt-bindings: misc: adi,axi-tdd: Add device-tree
 binding for TDD engine
Thread-Topic: [PATCH v3 1/2] dt-bindings: misc: adi,axi-tdd: Add device-tree
 binding for TDD engine
Thread-Index: AQHaAowB9bhJsll8RU+bJVO0WUIVKbBZVjaAgADoktA=
Date:   Wed, 25 Oct 2023 10:19:30 +0000
Message-ID: <BN7PR03MB4545D2A90C4D76AF2C6C166997DEA@BN7PR03MB4545.namprd03.prod.outlook.com>
References: <20231019125646.14236-1-eliza.balas@analog.com>
 <20231019125646.14236-2-eliza.balas@analog.com>
 <20231024190947.GA270524-robh@kernel.org>
In-Reply-To: <20231024190947.GA270524-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xRhCGa1YryQMoV21+7BE00kvX//KWAIBLfpdArhBv2r4HiScgRaDOOS/B6j0?=
 =?us-ascii?Q?RSmEJ5+CM+mvVaObIEqdHjm3ohfz0gBdJoDk/8EQ1+Bot7SE1K+I7xH7RADS?=
 =?us-ascii?Q?vHSRikFdRtCWxD/8d4vuXytmNjY6LLmYgI6G52+1FlWGK85vbCn5gQhibUMq?=
 =?us-ascii?Q?hAb8/5s6R8eoJTTI85Hiy2vu1caKYtCQZ7RE1quRiVSFjjI0G1CBiPWjSmKz?=
 =?us-ascii?Q?I2ujISnHO22riSKpwUREEbB0DK02Fv9gTpjt61ddEjv/v922z9QNLTBXx+mS?=
 =?us-ascii?Q?vX1ibDOrugqbAj3g9alLqNj/2mYZFYo4VQmNLIJeW0hgxSoIIN04uSEDBzEq?=
 =?us-ascii?Q?/dmkUoMtMmmFuauRg+aMs+V+TTQBmMV+wntwt7fxLCtlVSO891yeRsLwsVTA?=
 =?us-ascii?Q?Wh9s8jg+5WjmNX2QbrvJa2u4pGg4gkOqWuXbUEhYW6Fmy7YN5HlAVwl3rt+F?=
 =?us-ascii?Q?sZm0XB1k5LiXzx02bGXqORsV1zeQIRfMwEhJhyqSpx/mVQDi7O+pF7kigpKN?=
 =?us-ascii?Q?JV6WB37YuT0GMXmv5DPsQQY9uwKC5mYDY+57Ge7jQz2jPJmdoymVljlW+myr?=
 =?us-ascii?Q?d0OYjEAFWPKKiBOpbNMJ2J9uatW6uPODJVUpMWG/llBmhlZ5+0svgmVgF5vq?=
 =?us-ascii?Q?EXyIG2bj7fatnn2BtpXr/ILjwwrU8ak7rhnVI0IjNJ53uMPiegbokPBND/6I?=
 =?us-ascii?Q?MGid/HnLG5FjEcPOY+q6BZkCfLqHy29VDelvHbYpL2eksqcLlDLMsU8LWj8T?=
 =?us-ascii?Q?H+BXxY3GAhfJek9/0KC+OFs2CBqwcSvAMqtdyobCf6Im82HFow740SU4AWml?=
 =?us-ascii?Q?ayaohMoAew6FvwO8NjTw1Ne+WTdObQO16s/osW6E55F1gX8jfNFlIfEo2LT0?=
 =?us-ascii?Q?c23Ym0z2EEj2uNvIIkXW8gZIT6Cew8wohDhq0sNhfY3hHAuwb209JLPlI5eV?=
 =?us-ascii?Q?vvvTj+Kjj8hvYxMLIhZ+IdeLTT5uqOcsqUHW9hCz3L6LX9XLiLq664NvqtIm?=
 =?us-ascii?Q?Umg6T423mbxc1oD1E5L5pzF2NHlZsWHO2266tMh3sXn3x0bS3/ArwpgIT845?=
 =?us-ascii?Q?hovHwEHbMzjWePBjdWIdB7aUqyzY37NF1Ga2rla8D/6OEWr/AXj+4tm0JwVL?=
 =?us-ascii?Q?Al2hsDgFU7naWnmk5u+QvnFZZkVlF50X282LT1TenPu6I1E2HrhtB7npxxoQ?=
 =?us-ascii?Q?hQMZMwxzKnDIpoVfvINQqJZwDiF+02Nxu1U8XyB3qe+oI7W5zOZRr6I7z0El?=
 =?us-ascii?Q?rA4taAOpzgNF0Eh+x7aU22z4tu4Q457NVtLZPna454S7g70Gg7zsu104DPBM?=
 =?us-ascii?Q?R0dDXd+/TE9DCmb5p7QP7FAb3iS43DT9n/IvxnpRQAhb2RI1OrZGNQv/og18?=
 =?us-ascii?Q?rB0+f76NH+XgXlVKR6XKV2GnNW6kGy/bw7RV+M8bX/+Xod9xOSeKr0sWRzxj?=
 =?us-ascii?Q?1DJSiVfEAlweaOo8c3vXvGrEc6Rc563PuXw4YDWcbREJswagqYlhyhnYk1H0?=
 =?us-ascii?Q?sHihK6d8drjy0uHrfbxBHASZnd/1tJW//UjLFyv+vmQ2ad0MrCH68mvMgFNA?=
 =?us-ascii?Q?z49s09Tw9AZPMWxu7P61dDWuFf2aGyyAiI+g6Rxm?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: analog.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN7PR03MB4545.namprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 996a44c7-af5a-46f6-8b23-08dbd543e077
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Oct 2023 10:19:30.8142
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: eaa689b4-8f87-40e0-9c6f-7228de4d754a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PjXql+d2tTJD0ABiwt9Ctgj5FYf94gONL5f5xxXZDF0OYxYUgccoi1OtRLMkVpS8usAcLetmsqLyuK5VkdbCqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR03MB5948
X-Proofpoint-GUID: D5Rw9RZZyLYxEVZvcSEsiqFdCGUXSCLG
X-Proofpoint-ORIG-GUID: D5Rw9RZZyLYxEVZvcSEsiqFdCGUXSCLG
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-25_01,2023-10-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 clxscore=1011 mlxscore=0 suspectscore=0
 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2310170000 definitions=main-2310250089
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,
	SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 25 Oct 2023 03:20:08 -0700 (PDT)

> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Tuesday, October 24, 2023 22:10
> To: Balas, Eliza <Eliza.Balas@analog.com>
> Cc: linux-kernel@vger.kernel.org; devicetree@vger.kernel.org; Krzysztof K=
ozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor
> Dooley <conor+dt@kernel.org>; Derek Kiernan <derek.kiernan@amd.com>; Drag=
an Cvetic <dragan.cvetic@amd.com>; Arnd
> Bergmann <arnd@arndb.de>; Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Subject: Re: [PATCH v3 1/2] dt-bindings: misc: adi,axi-tdd: Add device-tr=
ee binding for TDD engine
>=20
> [External]
>=20
> On Thu, Oct 19, 2023 at 03:56:45PM +0300, Eliza Balas wrote:
> > Add device tree documentation for the AXI TDD Core.
> > The generic TDD controller is in essence a waveform generator
> > capable of addressing RF applications which require Time Division
> > Duplexing, as well as controlling other modules of general
> > applications through its dedicated 32 channel outputs.
> >
> > Signed-off-by: Eliza Balas <eliza.balas@analog.com>
> > ---
> >  .../devicetree/bindings/misc/adi,axi-tdd.yaml | 65 +++++++++++++++++++
> >  MAINTAINERS                                   |  7 ++
> >  2 files changed, 72 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/misc/adi,axi-tdd.=
yaml
> >
> > diff --git a/Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml b/=
Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
> > new file mode 100644
> > index 000000000000..4449d9abf46e
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/misc/adi,axi-tdd.yaml
> > @@ -0,0 +1,65 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +# Copyright 2023 Analog Devices Inc.
> > +%YAML 1.2
> > +---
> > +$id: https://urldefense.com/v3/__http://devicetree.org/schemas/misc/ad=
i,axi-
> tdd.yaml*__;Iw!!A3Ni8CS0y2Y!4FubpNBZ9iITDA4tWD49qCUp7AqEs72W2OQmpSkLyK2lC=
iWNWSbXGS6MGhJSdKMVza7CV5IRsVxNlA$
> > +$schema: https://urldefense.com/v3/__http://devicetree.org/meta-
> schemas/core.yaml*__;Iw!!A3Ni8CS0y2Y!4FubpNBZ9iITDA4tWD49qCUp7AqEs72W2OQm=
pSkLyK2lCiWNWSbXGS6MGhJSdKMVza7CV5
> J20y6r-A$
> > +
> > +title: Analog Devices AXI TDD Core
> > +
> > +maintainers:
> > +  - Eliza Balas <eliza.balas@analog.com>
> > +
> > +description: |
> > +  The TDD controller is a waveform generator capable of addressing RF
> > +  applications which require Time Division Duplexing, as well as contr=
olling
> > +  other modules of general applications through its dedicated 32 chann=
el
> > +  outputs. It solves the synchronization issue when transmitting and r=
eceiving
> > +  multiple frames of data through multiple buffers.
> > +  The TDD IP core is part of the Analog Devices hdl reference designs =
and has
> > +  the following features:
> > +    * Up to 32 independent output channels
> > +    * Start/stop time values per channel
> > +    * Enable and polarity bit values per channel
> > +    * 32 bit-max internal reference counter
> > +    * Initial startup delay before waveform generation
> > +    * Configurable frame length and number of frames per burst
> > +    * 3 sources of synchronization: external, internal and software ge=
nerated
> > +  For more information see the wiki:
> > +  https://wiki.analog.com/resources/fpga/docs/axi_tdd
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,axi-tdd
>=20
> I don't understand where the version number went. Now my question is is
> there only one version of this (ever). It's not specific enough unless
> there's a version register that can be relied on.
>=20
> This patch needs to answer any questions raised in previous versions.
> Assume the reviewers don't remember your patch and will ask the same
> questions again otherwise.
>=20
> Rob

This is the only TDD driver and I use the information from
the version register to determine the version.
That is why I had to remove the version number from=20
the compatible string.

Thank you,
Eliza