Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <532572c1-c4ed-4b46-8d30-32698bcd930f@linaro.org>
Date:   Wed, 25 Oct 2023 11:41:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/4] media: qcom: camss: Convert to per-VFE pointer for
 power-domain linkages
Content-Language: en-US
To:     Konrad Dybcio <konrad.dybcio@linaro.org>, hverkuil-cisco@xs4all.nl,
        laurent.pinchart@ideasonboard.com, rfoss@kernel.org,
        todor.too@gmail.com, agross@kernel.org, andersson@kernel.org,
        mchehab@kernel.org
Cc:     linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20231024224255.754779-1-bryan.odonoghue@linaro.org>
 <20231024224255.754779-2-bryan.odonoghue@linaro.org>
 <75c4a105-b925-4d6a-8c42-38f3ab32a7ca@linaro.org>
From:   Bryan O'Donoghue <bryan.odonoghue@linaro.org>
In-Reply-To: <75c4a105-b925-4d6a-8c42-38f3ab32a7ca@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 25/10/2023 10:16, Konrad Dybcio wrote:
>> @@ -653,11 +653,11 @@ static int vfe_pm_domain_on(struct vfe_device *vfe)
>>       if (id >= camss->res->vfe_num)
>>           return 0;
>> -    camss->genpd_link[id] = device_link_add(camss->dev, 
>> camss->genpd[id],
>> -                        DL_FLAG_STATELESS |
>> -                        DL_FLAG_PM_RUNTIME |
>> -                        DL_FLAG_RPM_ACTIVE);
> Good opportunity to inilne vfe->id and get rid of a local var!

Yeah no objection to that, this is a progressive patchset so the index 
goes away in 1 or 2 patches later in the series anyway.

---
bod