Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2469257rda; Wed, 25 Oct 2023 03:51:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFaObS4P3ai8R80Ciuz2+4pbwlNTEcVBNGmjumBc0rAVNsYgDs/2Ze0s8+ahHB8+syvR4gj X-Received: by 2002:a5b:8c8:0:b0:d9a:3811:9c57 with SMTP id w8-20020a5b08c8000000b00d9a38119c57mr13316390ybq.43.1698231118139; Wed, 25 Oct 2023 03:51:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698231118; cv=none; d=google.com; s=arc-20160816; b=MDzLG8lpt5Io1ClJrnI1XKsfVMzqamHncQ9t68MOIMERUQDxJXHzzBvLRzeW4eshx/ yb8zyxeWB680eWlu60VOyJFkwRUfIgb3Mrl9uwbof0C1YDDikP5CsiiT79lhXYPCk6Xj kY3VzlYzunsKhP5GliVVZPrsTOLMiYFfxI6Izda26Z40RVjxrXUsLHk+YM0u6bAoyss6 nY6m+jwnIo+za/8b71Nkrq4lp5CuWGXqSYA05+SSnXKPw4Z3lTxEXj8Q1C2FvSoDM+8m un5BsFxsSmiWbcV8u/KtszpTeXTw4LmQGrUw/1PDk2avRWr289CYbZ9rLPHSKb7sMAue XKaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=xTMGiIf9BvcjDTMlnBhMDXLdKdTkxQrxNd4R2wPfqL8=; fh=nK/B2gIzvYPsKU0sJgdKEVdz5eoE00hHt727sEimwsQ=; b=Xq+r4+UkiPCr6lA/EEFMlLBOK8e9Jzp3UPZSEs1FPkrhARuq5GUYdbm+zvNvS5zFTB pVeBVyAFTJ5eh8ETZKDskc+2U/rXI3IO2tKXYfiadA2AedJd7oVlOLvbP5uszN+iOxH9 9lFgy3Xzw2x1TVYlfOlehodX7/O03+UM9A7qbArPnq2BI4Zy06jOuaOROlkX0xu5Kl4Y sjigFu9g3ab2VhdOweDBQtNI9p3/5zNLVB4xF4MhJykfM4gj/I7Tul6VROzqalc57UY9 9pKH+s7KtGyykc7IMepjtkOEDKJ89QZl6rYLg4IAJHmBO725SpG2pOmRRk62tG0g+DD4 NXpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=mcHjHkuy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Return-Path: Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id v13-20020a25fc0d000000b00d9a3af0f490si11063324ybd.177.2023.10.25.03.51.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 03:51:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@posteo.net header.s=2017 header.b=mcHjHkuy; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=posteo.net Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 9824080C7125; Wed, 25 Oct 2023 03:51:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232272AbjJYKvm (ORCPT + 99 others); Wed, 25 Oct 2023 06:51:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJYKvm (ORCPT ); Wed, 25 Oct 2023 06:51:42 -0400 Received: from mout01.posteo.de (mout01.posteo.de [185.67.36.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88D50AC for ; Wed, 25 Oct 2023 03:51:39 -0700 (PDT) Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 51A3124002A for ; Wed, 25 Oct 2023 12:51:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1698231097; bh=0FIw4YJi8aEpRPqIX3rgKn5FpRFYwb1qqUHkTAzLsjs=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version: Content-Transfer-Encoding:From; b=mcHjHkuyzf94AqEZQqn0bHKE7baNtxOpkiXmJf15CI29HAIdMJKaCIHdlyd2PK3GF N+qx/UCsY8mDyAHXUek5mj3dgbAcxjCWO+LKtE0xEHB5722F1GifYZGpV8uoAQm1pM TMMiP2dsrI+xM9kMRs6NhDZYtKMhxBhUF/fWywJjMSauYOO/kjjChw922ImsfXCaQo lv187s3MxifVFgK9dS1eLarPLIdJLNBkhpe11HJCI3HkFDLcwIQZ6xtvELmKw2Ha2a T2LjC0s2IrpurKrjZDGoo8T7si4MPw5skmo8wP3QlSbMu2PG8fVYtwee5fcoK8uhTS SWM37OwcSwhZQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SFm2G6rRLz9rxB; Wed, 25 Oct 2023 12:51:34 +0200 (CEST) From: Mark O'Donovan To: linux-kernel@vger.kernel.org Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org, hare@suse.de, Mark O'Donovan Subject: [PATCH v3 0/3] nvme-tcp: always set valid seq_num in dhchap reply Date: Wed, 25 Oct 2023 10:51:22 +0000 Message-Id: <20231025105125.134443-1-shiftee@posteo.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 03:51:54 -0700 (PDT) The first patch is a small unrelated fix which makes it clear that the response data section of the Success1 message is not optional. The second patch removes use of the host sequence number (S2) as an indicator of bi-directional authentication. The third patch causes us to always set the host sequence number (S2) to a non-zero value instead of the 0 value reserved for the secure channel feature. v1: original submission v2: rebased + added dedicated variable for bi-directional auth v3: nvme-target code now reads seq-num Mark O'Donovan (3): nvme-auth: auth success1 msg always includes resp nvme-auth: add flag for bi-directional auth nvme-auth: always set valid seq_num in dhchap reply drivers/nvme/host/auth.c | 13 ++++++------- drivers/nvme/target/fabrics-cmd-auth.c | 2 +- include/linux/nvme.h | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) base-commit: 4f82870119a46b0d04d91ef4697ac4977a255a9d -- 2.39.2