Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2471023rda; Wed, 25 Oct 2023 03:56:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/E//ljodkt2MT50nQQLOUDkl9b8Rp8lZ0IEjcboSQMpnp9W1HdptbzC0cAdz5RgvdyE9q X-Received: by 2002:a25:25cd:0:b0:d7f:1749:9e59 with SMTP id l196-20020a2525cd000000b00d7f17499e59mr16451457ybl.11.1698231394493; Wed, 25 Oct 2023 03:56:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698231394; cv=none; d=google.com; s=arc-20160816; b=nv4IAKGdQRYflxWemaXuVU42O5BrggQ452fAx8DaHOiLV3IbWE4XNakfwhNB4lzDct BP9jNRTk51vQroSeAbMPmaKGiTZaJNXs98mhpM0+9SKHBl5M0QJGc5H9HVJ9wU5uaM0e hfklt2D8Xiks4kAkV/gs9pMIE0/iBOYOC0IflplsWV31Ki0sGZCICwnkS1mKMVbP3U75 xPG8ZeSFZ2UI1/mZJAn7JRzM3XRtVlpyNxhBA5I1689WyRlE6ErN84Rj605e6I1gRR8+ lFtkhwjqQh5m3yeuZZvqKmn3CALm72bVPDDtUAV4dvbcfx5HjwcqPJ5WJYdp0nyJF8He 1k7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=luYAaC4Ad9rTiLXjx+ga8YrzC2X/wgzwmHzA+hkgu68=; fh=Sg3QctNnffz09olm+k3+/xewvpIrPKG943V4dMChNiE=; b=Xx13XtNQvh3+X2P0pjQmoCfozYQAhZjAd0TldYVDFq1oI7/S5K2yLPUXJfvo9IITYY H7flewl/fzVPnPOUdxxC162ONCNOnQhLxD7d5HMFD6YwZ+W41vEl7Xd4w5zZDabLN7E7 CnzcJspA3PP8JY/Qx1YYGF6vFon5jDPpxGwG2Ur2MNY8qjYNIjMqjdlG1LXc59hoOeCa reWhO8MxZvRxcGgdtQMAat2ARkB6FiA045gFXjy5ivcS8H5Qt6DZpfCSur8PeS5N8k6e m76pu0WCL1ODc25we8UJoVbZkNO/loKHzba9M05rTFK96H5cKru0QIps1WK4749Rz9dd hHBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xjzg7RB+; dkim=neutral (no key) header.i=@suse.de header.b=bEvvqyBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id i10-20020a256d0a000000b00d9ca7577fcbsi9328187ybc.717.2023.10.25.03.56.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 03:56:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=Xjzg7RB+; dkim=neutral (no key) header.i=@suse.de header.b=bEvvqyBj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id BDAEB802854A; Wed, 25 Oct 2023 03:56:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233039AbjJYK4Y (ORCPT + 99 others); Wed, 25 Oct 2023 06:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232695AbjJYK4X (ORCPT ); Wed, 25 Oct 2023 06:56:23 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D544A6 for ; Wed, 25 Oct 2023 03:56:21 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 2C25C21DA9; Wed, 25 Oct 2023 10:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698231378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=luYAaC4Ad9rTiLXjx+ga8YrzC2X/wgzwmHzA+hkgu68=; b=Xjzg7RB+SX2KGGvgxAcattFJLLIljw8wm1yrbEcFKd1KyjC26eXN3LyoJDan5e9auhN5IA gZXCAL8K1D5//9fY0c+oTaKKDpXDOtx9/q6071DFSdVf8NUbeDBDiQnoVbCaHYv5WvOZie AaD1uc1UYRVIhRHJkx9L7D3Bvqzygrc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698231378; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=luYAaC4Ad9rTiLXjx+ga8YrzC2X/wgzwmHzA+hkgu68=; b=bEvvqyBjmBmMLUy50G+pv6d6puyiZPP4gKY8Ej4yqWRU62FXO03/Gw26gO+OeH7O/5uk6g f3CRixv2g/Oq/+BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E2BF413524; Wed, 25 Oct 2023 10:56:17 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 6FmENFH0OGVfSgAAMHmgww (envelope-from ); Wed, 25 Oct 2023 10:56:17 +0000 Message-ID: <6ce64595-9b99-4f8c-b713-f0a897a8670f@suse.de> Date: Wed, 25 Oct 2023 12:56:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/3] nvme-auth: add flag for bi-directional auth Content-Language: en-US To: Mark O'Donovan , linux-kernel@vger.kernel.org Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org References: <20231025105125.134443-1-shiftee@posteo.net> <20231025105125.134443-3-shiftee@posteo.net> From: Hannes Reinecke In-Reply-To: <20231025105125.134443-3-shiftee@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -11.09 X-Spamd-Result: default: False [-11.09 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-3.00)[99.98%]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 03:56:32 -0700 (PDT) On 10/25/23 12:51, Mark O'Donovan wrote: > Introduces an explicit variable for bi-directional auth. > The currently used variable chap->s2 is incorrectly zeroed for > uni-directional auth. That will be fixed in the next patch so this > needs to change to avoid sending unexpected success2 messages > > Signed-off-by: Mark O'Donovan > Reviewed-by: Christoph Hellwig > --- > drivers/nvme/host/auth.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes