Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2471200rda; Wed, 25 Oct 2023 03:57:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGk0Yg6f14aONyoe43Lo4SxkH1b3JVNvDEm/QuV+dlGWjvNmDJ7oyIf6VR9xtsPa6VUS1CM X-Received: by 2002:a25:800d:0:b0:da0:7936:526b with SMTP id m13-20020a25800d000000b00da07936526bmr1247906ybk.17.1698231420699; Wed, 25 Oct 2023 03:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698231420; cv=none; d=google.com; s=arc-20160816; b=JoDdZt6cqEOw3Hqx1qMrWNsmSisCvgHa9u38ygX6hrsSh2+3+79DkrPVco7BrYkelv niiuFU5bi3zTZc7t1cywx3PbvENEAjA4st2473ox93UAiGPsSEv/fv10lHlkEA11d2EA PvCqOBg5EESwzBoge9Bg+/DEm6rLeBjksGr/ye02Uouwwwo7WpmBruBG7Gb8hTR7TNI3 ScawSTuyrk2WscgxvzD/8n8BEw34r3ZVX9jqQFxSe00f0XVD7VPdkZrbIb/ZnvWYEjM+ GWlR+LriwumnRNiichOWQ3OUBLVdXt6/InwKBfJ0+9PFO1wDECQjQTxOwWHvJ7Pq/7FZ xhiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature:dkim-signature; bh=zeDWim+JScQgSjn6RlSH0KxhQY+Tl4p6+kd8bxOPMlY=; fh=Sg3QctNnffz09olm+k3+/xewvpIrPKG943V4dMChNiE=; b=tshXmnXVivQVKOi4+ka623TOGGYT+RbrBX8zVLmvOpSlJMsAK1njMMPt/mk7CVfxNf JKbq63FRjPGzFymj3ngCwOznV06khht+5E4Qk27GoHGz8mdCT8thwf+d54GbRL0V7XGp kAwU9huU/qQoarLdNo7DQMNeOROLxCs3A2qtNMKzUpiL39ZqbXGiJY/Ly9uYNRKezNQk 6CxikWtlDBDfIWCGfUW3EVD+sSsYieT5C9+tQne4V6vBqhD3B6CV5qBOsNGKl50CgaX5 ViIRykSHVm9tWhv1NCbHbaVj6lxMbOt6jfzE7zxn9/ff57OYqh97vgWeX0+JqtpnE9Gc NQ9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NXnheQZX; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Return-Path: Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id o145-20020a254197000000b00d9a4b78d410si9649101yba.302.2023.10.25.03.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 03:57:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.de header.s=susede2_rsa header.b=NXnheQZX; dkim=neutral (no key) header.i=@suse.de; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=suse.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 05DDC802B3DC; Wed, 25 Oct 2023 03:56:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233153AbjJYK4r (ORCPT + 99 others); Wed, 25 Oct 2023 06:56:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232272AbjJYK4p (ORCPT ); Wed, 25 Oct 2023 06:56:45 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E2EBAC for ; Wed, 25 Oct 2023 03:56:43 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 0B4FF21DA9; Wed, 25 Oct 2023 10:56:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1698231402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zeDWim+JScQgSjn6RlSH0KxhQY+Tl4p6+kd8bxOPMlY=; b=NXnheQZXRctRq2m3ZlyuWmkmoLDpA+qf06DJJuynTTtgtq+EDmb1eph14FuwoRMIhoqcfF a7MLqTF3hRYZqtSjhtLegBBFCN3B2KrP4HA4dP1HkMrrO29pQW2LmGlJZmVMUlxcNaUpLe 0eYMBpZCGQf6mAOtl1hA/2yeG9xi82M= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1698231402; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zeDWim+JScQgSjn6RlSH0KxhQY+Tl4p6+kd8bxOPMlY=; b=BAukHQ5a4vx/UD9JbN9yEXKEZACAjqqhFIAKD0uHEtu8bKWjkF4jkDLUCemLRHWKuuLPyf ZE4pzjFKIS9dfIDA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id DC40C13524; Wed, 25 Oct 2023 10:56:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SAINNWn0OGVfSgAAMHmgww (envelope-from ); Wed, 25 Oct 2023 10:56:41 +0000 Message-ID: <70ec751d-8aba-42b4-861c-e7e17c4a7476@suse.de> Date: Wed, 25 Oct 2023 12:56:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/3] nvme-auth: always set valid seq_num in dhchap reply Content-Language: en-US To: Mark O'Donovan , linux-kernel@vger.kernel.org Cc: linux-nvme@lists.infradead.org, sagi@grimberg.me, hch@lst.de, axboe@kernel.dk, kbusch@kernel.org References: <20231025105125.134443-1-shiftee@posteo.net> <20231025105125.134443-4-shiftee@posteo.net> From: Hannes Reinecke In-Reply-To: <20231025105125.134443-4-shiftee@posteo.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -11.04 X-Spamd-Result: default: False [-11.04 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-2.95)[99.80%]; MIME_GOOD(-0.10)[text/plain]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-3.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCPT_COUNT_SEVEN(0.00)[7]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 25 Oct 2023 03:56:58 -0700 (PDT) On 10/25/23 12:51, Mark O'Donovan wrote: > Currently a seqnum of zero is sent during uni-directional > authentication. The zero value is reserved for the secure channel > feature which is not yet implemented. > > Relevant extract from the spec: > The value 0h is used to indicate that bidirectional authentication > is not performed, but a challenge value C2 is carried in order to > generate a pre-shared key (PSK) for subsequent establishment of a > secure channel > > Signed-off-by: Mark O'Donovan > Reviewed-by: Christoph Hellwig > > --- > v1: used incorrect prefix nvme-tcp > v2: added spec extract to commit message > v3: read the seq-num in nvme-target code > Reviewed-by: Hannes Reinecke Cheers, Hannes