Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2484268rda; Wed, 25 Oct 2023 04:19:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEvLLvvqjweJvynxPmWVe6x+7ghJqfd5NgJ4bXUDPr37oYlfazZCBFVNcNIxudnxR95Plr4 X-Received: by 2002:a25:28f:0:b0:d81:894b:28e4 with SMTP id 137-20020a25028f000000b00d81894b28e4mr14070160ybc.51.1698232743697; Wed, 25 Oct 2023 04:19:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698232743; cv=none; d=google.com; s=arc-20160816; b=kACnE5XIOvgP5iduG/Nb2PMKy8G2oqtUCGTfRQNYG69i8tGv9K6/DVawCeQhdS9mLz tKEm7SAwRWC1zCmPYhikXgMrfADxGqBWvJr+6PPv623pt+y5VmunlK7uIoD3WOBc4CjU aQBQ78R1puIHJGTxAcVRsfz3o6B++zDjexQBEgdWRfY69kL2PyzcgU2aohkvrJH5YVTK IYYf9lKyZRme2VcOdFd0f2a3JnmztuEhloaD2G576HAoZVFljV3ZIOvJDB3EKrg3I5w6 uDc9UJj+vM0M4tza685JbiVsQ0CTvpUpGYbYrxLGW33UcbPPMFBlPmmrugP2d8m1tnZV iV/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zni4MC39mFQuWv1PNE4ESe3BI304dg591sjjGItxG4c=; fh=yqoav7EnEdJ2mT+rtoecryk3HwWdUT86ZBxH2AVEvUc=; b=IW+Dggz2RajvuDZ1AkJaWNRmdUE+WLde7/5bENoBY0Ko60Zch8Vdgdy+WYx52J1myf fPeWYuMy8msWpzdW9Sb1JyTyr6HrzIhghurvWyM/BseZB+4VI7R17ICtCui2JdNV0FF+ 5WLzggf98JdbplamX99+ZS9ZQ3RGebqdlirAuVzUQKSuh14y4KfSSkAh8Bd2X1DcEe8M 8UsDZpk8Iz9aJMfOMP6QyAFM/Gc5qDvitQm9DXn5I0XTRHE+rTzkmxxIYfTjdAOzfo9P 6NGNXnyRhDU4fzrQOfh8bLJkyRjkSULTI2XsYGOlROsnjvUrG3ua9JZdyQQGhY8FEtDH RGyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XVnH2i6y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j9-20020a256e09000000b00d9a66ec5a28si10314291ybc.121.2023.10.25.04.19.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 04:19:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=XVnH2i6y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 3654E80E7622; Wed, 25 Oct 2023 04:19:01 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234790AbjJYLSr (ORCPT + 99 others); Wed, 25 Oct 2023 07:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58128 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233804AbjJYLSj (ORCPT ); Wed, 25 Oct 2023 07:18:39 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF50137; Wed, 25 Oct 2023 04:18:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698232716; x=1729768716; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GGWBLv1O7SHoGXNqpswjaidLqIzwApROs0cSW0Fp2r8=; b=XVnH2i6yhtAz/hY4hA0WS3OjmJbRC8Vi1L0e9WESRTIgx0xzGyvQdSdh ICZoR7QVgZJ6oduA7tWm0bpO4sTbbpAfBMgkSam53mK0peLfQIWRQGoLs iO/p6RBo/+BcI3Mi0NcR460Rm90FzkfA5vROZNb2Y3lUwFRBAt7O7JxGH udpKh6LqZS/++FPM9jZ8kpueie9omX0N52aLVeUeFTYWsSkBWdByDq+Hz QKsxaG+A604I67LIaXT918sT78A5daxmWE5GrIuH/26N5A9wV1JLFx+XD SlHwU92WkvO9x0PBbqlZMe8Hx8lsU+vC0jkY0RHBi19pa5FPc0UJqRroO Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="391154628" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="391154628" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 04:18:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="762425103" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="762425103" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 04:18:22 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, lenb@kernel.org, Michal Wilczynski Subject: [PATCH v1 3/6] ACPI: acpi_video: Remove unnecessary driver_data clear Date: Wed, 25 Oct 2023 14:18:03 +0300 Message-ID: <20231025111806.2416524-4-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025111806.2416524-1-michal.wilczynski@intel.com> References: <20231025111806.2416524-1-michal.wilczynski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 04:19:01 -0700 (PDT) Commit 0d16710146a1 ("ACPI: bus: Set driver_data to NULL every time .add() fails") introduced clearing driver_data every time probe fails, so it's not necessary to clear it in the probe() callback. Remove NULL assignment to driver_data in error path in acpi_video_bus_add(). Signed-off-by: Michal Wilczynski --- drivers/acpi/acpi_video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index e17474949bbb..0c93b0ef0feb 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -2077,7 +2077,6 @@ static int acpi_video_bus_add(struct acpi_device *device) kfree(video->attached_array); err_free_video: kfree(video); - device->driver_data = NULL; return error; } -- 2.41.0