Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2484283rda; Wed, 25 Oct 2023 04:19:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGoLtUK4XTLl3BAqFzBImcLgNOMVok9f13ETwn+Fv9shaKpfKSUAnGWwS/bFgKKSL5d7qDQ X-Received: by 2002:a81:6d8d:0:b0:5a7:b8e6:6441 with SMTP id i135-20020a816d8d000000b005a7b8e66441mr13707425ywc.16.1698232745097; Wed, 25 Oct 2023 04:19:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698232745; cv=none; d=google.com; s=arc-20160816; b=ogAUWKq1ewPIS1mMRs+Keek8miutwxCnBru9CW/gH2rmSmCi0clVWGfb3VF1+/PQbT 17eV4joKqIMVy7JzDPGMqIPaRXj92z1lVr18rDQpKDzax3ejStlvzVeJqNa0hcN1AxDP oZuAmOkUfOCbvM7RADzkPUi+8HU47aaCS9qVfo0Oj+UBVmNRwM8U44BBJy9c4NggEjW7 AS6aQM67zM9l0ekYgbk/Qfycju6nm39Ldl6ytZqRVLa8Ef4N3zjSsk0EhL6kYOWLroN8 YPrQVSfq04UVvG1Vzk/e34Cquj7FZ/gh5Om3ZLgZBOPDxwRAj4MkD01E6kac3dqCysk+ mt7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=rCKCd2AwmQP5hvIXtRokTJjP9VoU1a1R+9Yta6i2nzw=; fh=yqoav7EnEdJ2mT+rtoecryk3HwWdUT86ZBxH2AVEvUc=; b=c/DaRpxgj5tVkMgihYuAe5gAPYoBZWf8RdP8kiqknbrbKE6KLT/qSLbMycn7ZI1bAN RdKm4EDMbX/gGBqL5jEBZrFfhncMhH7d4JaaIEms8dDIeIy1fBGSCNuSiUKDYmzrNQR8 OTZ6DhMF3ah+8IgCT1QHj+nqRIFT3HHDEuwRtgDD+y6VHZ74tLvN3GykrS78zimNebIP IkcZtydybf8DKC26I97X55HBXY28+UJnOuMM/BNZhVxOxBUGoQ4RMXh9nXDZliUfcErG 1rxpRopgkdSD70uWVTuYGa53bqiVhglV+t7UQToEgGugouCwq+JbyTYW3HbjRC1l7YG9 ZNFA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eh9Gv0dT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id v66-20020a818545000000b0054fdf854b93si10230752ywf.576.2023.10.25.04.19.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 04:19:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=eh9Gv0dT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 1EEFC80E7625; Wed, 25 Oct 2023 04:19:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343573AbjJYLSx (ORCPT + 99 others); Wed, 25 Oct 2023 07:18:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234655AbjJYLSk (ORCPT ); Wed, 25 Oct 2023 07:18:40 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A2EE18E; Wed, 25 Oct 2023 04:18:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698232718; x=1729768718; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zxS//e/ZqjIB0NhbIBluRHpqaStKqMVqrAs7nUrO30A=; b=eh9Gv0dTUI1E0jFNHkSYABwrN+ihY+6BYLLbG5iBBlZwxgJTt1ST2VuX Q2J2j5uLjkwfuhj/ewWJMPu03pgshcH6ozOb2FCxXwnk0Z4yHQYBW1+pe UFmwrpicpCe9CqyV2zbjzlDbCJX8RSWMrgJeUMfN8vyX4xA/1RPVbT1pl Gt87B8Amnf7ZYt+oUPFS9sPS+7rX8fGukFfNJESG1Cm+Za4vfkx5cLO1w QIcgKGaepK+J/OBwJPJYj2UEjfggL6qDy5LI+IJYw/LsAkeFL7QaCMib/ 5t/dOYdtdif0BYkfABZMDBecNHUj2hAuXvAP73jATyhs0RXmSWfNZSLRK w==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="391154641" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="391154641" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 04:18:30 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="762425139" X-IronPort-AV: E=Sophos;i="6.03,250,1694761200"; d="scan'208";a="762425139" Received: from powerlab.fi.intel.com ([10.237.71.25]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Oct 2023 04:18:28 -0700 From: Michal Wilczynski To: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org Cc: rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, lenb@kernel.org, Michal Wilczynski Subject: [PATCH v1 6/6] ACPI: acpi_video: Fix holes in acpi_video_bus Date: Wed, 25 Oct 2023 14:18:06 +0300 Message-ID: <20231025111806.2416524-7-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231025111806.2416524-1-michal.wilczynski@intel.com> References: <20231025111806.2416524-1-michal.wilczynski@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 04:19:02 -0700 (PDT) As identified by 'pahole' utility there are holes in acpi_video_bus struct. Rearrange elements to get rid of the holes. Put elements biggest in size first, and one-byte elements later. Signed-off-by: Michal Wilczynski --- drivers/acpi/acpi_video.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/acpi/acpi_video.c b/drivers/acpi/acpi_video.c index bfc7f51a527d..1e10d5b748b2 100644 --- a/drivers/acpi/acpi_video.c +++ b/drivers/acpi/acpi_video.c @@ -155,19 +155,19 @@ struct acpi_video_enumerated_device { struct acpi_video_bus { struct acpi_device *device; + struct acpi_video_enumerated_device *attached_array; + struct list_head video_device_list; + struct mutex device_list_lock; /* protects video_device_list */ + struct list_head entry; + struct input_dev *input; + struct notifier_block pm_nb; bool backlight_registered; u8 dos_setting; - struct acpi_video_enumerated_device *attached_array; u8 attached_count; u8 child_count; struct acpi_video_bus_cap cap; struct acpi_video_bus_flags flags; - struct list_head video_device_list; - struct mutex device_list_lock; /* protects video_device_list */ - struct list_head entry; - struct input_dev *input; char phys[32]; /* for input device */ - struct notifier_block pm_nb; }; struct acpi_video_device_flags { -- 2.41.0