Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2486099rda; Wed, 25 Oct 2023 04:22:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFCFyXnkNpkKRodzYafONiWzukUB49h0I0pTb+oSYiWiWZfIddK0K0PqrgDHzpraYh9cx/p X-Received: by 2002:a0d:d48e:0:b0:5a9:30c3:c664 with SMTP id w136-20020a0dd48e000000b005a930c3c664mr11305023ywd.19.1698232942497; Wed, 25 Oct 2023 04:22:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698232942; cv=none; d=google.com; s=arc-20160816; b=CW0YgcxYY75TzhVVDxg4meHyAJyMRtrm59fz7NcGfmqhZWe55F+QVVR0Sv2Wklz+UO WmD2UnUsyNvv+dcNrT0Radk5uANuE2LI0du70FQRsrkiFxYFsaJEVXRloYw49jgrHd8R XxyiEG4caE7pJzkj28xUEv0dIqLolV0XvoQU8fNP2SpIC4+Uvw29dcibAq3P8sLYLdcO f5vKJ5xw43al+OKwBvl4HPXCikhHQB9RmsSOTl/xPuHOfvPB2T0CSR395+3tO42fNZ8S mWK5NIegMRuvonDf/O6CuHEEtud/TdO+l0ZyinKR8RNPb3oIJbhcpMbBwW/z6nq02gFp Yrmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:user-agent :content-transfer-encoding:references:in-reply-to:date:cc:to:from :subject:message-id:dkim-signature; bh=dwp8E74sI4tVBaqrgu+e8RzHTAWo0YSAPvz5KCe5hyQ=; fh=WSYMl92wegEV8b/CA5YAxjUlkQMk8GgEStrWnOZKXIE=; b=Ws9yw/+SNMifSeufjpYDumejsKY9HYL3ZrSGP7goZGosq5VisFVu2uAF8cCkBZdpiy GRxCFqqdNSsZS3IO0obARQjTWzcmD7wt8wkCN0uzW4PK6EqhjuVDd1JcSRnLJKj3DSKE jlvgyDW49o8d2JZO7ElFCC0vgIKcpVGicBsZZIhvDQW6SyQPKGYZnuyEJ5Fx05ZEncKb MJ35ULCZnryMzE/Dd9ySCZDYWnhkr1wabVDPYW4+KyIcdaeqMKXJ6sgA/p/upq8XIZDw QR19Ox50EDCSCCKQi63O8XMESjhAWSjRheU0jLEACZrPglGVrC6t008ZvlxyYbkaMJiQ pQig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aY07CGEI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id k63-20020a0dfa42000000b005a23fed78dfsi10566253ywf.454.2023.10.25.04.22.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 04:22:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=aY07CGEI; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 983D480FCBF8; Wed, 25 Oct 2023 04:22:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233782AbjJYLWL (ORCPT + 99 others); Wed, 25 Oct 2023 07:22:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232076AbjJYLWJ (ORCPT ); Wed, 25 Oct 2023 07:22:09 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0C3210A for ; Wed, 25 Oct 2023 04:22:06 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id 38308e7fff4ca-2c50cd16f3bso79207031fa.2 for ; Wed, 25 Oct 2023 04:22:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1698232925; x=1698837725; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=dwp8E74sI4tVBaqrgu+e8RzHTAWo0YSAPvz5KCe5hyQ=; b=aY07CGEIYA8zybKuO4KqyfbYe0+V0m3ih1/Mp8aNqLBEwpZhGwZbL1IkCxiW1RyUoK NdhfhGU5a7byOEXq9tN5DvTBVfouTZDZv9uHaH47eVbvaxM4fU2WTklwOe/v/IORSCM9 renAg5q1HekURoFkVl8Okn5DdHlA5u08iCGhYaIXRDHrqklc2gkfoH25rCx8NuPzPlL8 3t3gZKXjwKpQJJhLRqrFay1GnbNvFTImTAwV8kDmgD5+SdTcawFMkVKduS+LYAGbsZ8Y ch7M6mqaqwto/BYwKcH6XlX7bcHNWQTkZGKj1byZZuGjpkJl5Av2fsedBXU7Sq2sqgB8 y6WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698232925; x=1698837725; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dwp8E74sI4tVBaqrgu+e8RzHTAWo0YSAPvz5KCe5hyQ=; b=dTP2wXqwYCon4+ua+pFdpdCceZF2wkdGWzh1FTpUvkUWDOu2ZW+4d8ac+J3H3EXIJS 7pv40Q9wmVL8JIj/3i1+/pfbLYznNyiQXO04asVNeYi/Nywr7r9gMGe7sGbOIQbYw9/j pm5VwU+lXWBPNyBPhl7iHJCPiiLI3OAqYatN8KvLSXiYLVmAo+A5m73a4jvH+se0T9TH vLLjH1t/CZj/bgcYcRWAbtHeMxBOOp473BDcLQgefv2aDqmR89X6/Q6ZfWAZhaai6PGi dXqiAUwzpXEIQ/tTfPhyDjxvdU7IyxMpJgw0vmmxWxlMagRbvNkfRGWblte0zN6BbuPH z5Jw== X-Gm-Message-State: AOJu0YyG0iLADTT6SwfQrl8U8Oi4kVI4CbL7E3sk3lkPQG1CMqCCwABv aqzK3bpsGxy1yGZIwNmcD2As1g== X-Received: by 2002:a05:651c:b20:b0:2c5:8a4:9e6f with SMTP id b32-20020a05651c0b2000b002c508a49e6fmr12089142ljr.37.1698232924963; Wed, 25 Oct 2023 04:22:04 -0700 (PDT) Received: from draszik.lan ([80.111.64.44]) by smtp.gmail.com with ESMTPSA id o12-20020a05600c4fcc00b0040775501256sm14361794wmq.16.2023.10.25.04.22.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 04:22:04 -0700 (PDT) Message-ID: Subject: Re: [PATCH v2] tty: serial: samsung_tty: remove dead code From: =?ISO-8859-1?Q?Andr=E9?= Draszik To: Andi Shyti Cc: linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, alim.akhtar@samsung.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-serial@vger.kernel.org Date: Wed, 25 Oct 2023 12:22:03 +0100 In-Reply-To: <20231024215509.ak4jbbahw2vsahs6@zenone.zhora.eu> References: <20231019100901.4026680-1-andre.draszik@linaro.org> <20231024215509.ak4jbbahw2vsahs6@zenone.zhora.eu> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4-1 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 04:22:19 -0700 (PDT) Hi Andi, On Tue, 2023-10-24 at 23:55 +0200, Andi Shyti wrote: > Hi Andre, >=20 > On Thu, Oct 19, 2023 at 11:09:01AM +0100, Andr=C3=A9 Draszik wrote: > > When support for various old platforms was removed in commit > > 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks"), > > s3c24xx_serial_ops also became unused here because nothing sets > > port > > type TYPE_S3C24XX anymore. > >=20 > > Remove s3c24xx_serial_ops and all the code that's unreachable now. > >=20 > > Fixes: 1ea35b355722 ("ARM: s3c: remove s3c24xx specific hacks") >=20 > is this really a fix? Or is it a cleanup? I guess from my position it's fixing the issue of dead code, introduced in the commit referenced. Which is of course also a cleanup :-) Not sure... Cheers, Andre