Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Date:   Wed, 25 Oct 2023 08:33:56 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Yi Liu <yi.l.liu@intel.com>, joro@8bytes.org,
        alex.williamson@redhat.com, kevin.tian@intel.com,
        robin.murphy@arm.com, cohuck@redhat.com, eric.auger@redhat.com,
        nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com,
        chao.p.peng@linux.intel.com, yi.y.sun@linux.intel.com,
        peterx@redhat.com, jasowang@redhat.com,
        shameerali.kolothum.thodi@huawei.com, lulu@redhat.com,
        suravee.suthikulpanit@amd.com, iommu@lists.linux.dev,
        linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
        zhenzhong.duan@intel.com, joao.m.martins@oracle.com
Subject: Re: [PATCH] iommu/vt-d: Enhance capability check for nested parent
 domain allocation
Message-ID: <20231025113356.GX3952@nvidia.com>
References: <20231024150011.44642-1-yi.l.liu@intel.com>
 <62f396d4-f890-477f-b9ea-7b330fec35c2@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <62f396d4-f890-477f-b9ea-7b330fec35c2@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GqvlfS1inqOfSTIJdqfAPO96g9AmJGYDw+SRz+5/l3w4HzpnABzNzW+M/HoY?=
 =?us-ascii?Q?OqOIhDahyuCu2ls/AuBoXGhB2MA3yrl35gQHPw+pYdJq5OPDvZiNx3GNkq6K?=
 =?us-ascii?Q?EZuS76lcdDEig1yY0PjtSukCvjqxHBnjXt9QYDTUY4V5qZXpRH0BUa53MfDD?=
 =?us-ascii?Q?2KLBOZW9/Ko/mB2vFkLqjynQgI2QXuFSVZ1GG1+iKjpBSPPp+C9oGLE9ny2j?=
 =?us-ascii?Q?5/hiR4eGvGe05puOKDNne7xNY3UaY1TGpj3vVZjez1ls4UIp24DDtbUt57Av?=
 =?us-ascii?Q?XtQ1uh6RbjaobKgaGQJr0Sa3IdO6gw72a+m2qf0ce6vxD+bvDs7MK072pWVQ?=
 =?us-ascii?Q?81PTBXEsw0NsZjKKjmYRfDhfDLGi8r3ULXfkRi6FYPb0yyUi9DcC7QU/fOlT?=
 =?us-ascii?Q?1rZ7lYF/0+kiEwvFidyRWcbfjZiTX86uloj7DjRRwTK3mcJJY+dJc26UGrik?=
 =?us-ascii?Q?4IW8SeB/b21je2REltKGygemv8QcY7vZXG3fDLSZPSam061YditxidkBfa2h?=
 =?us-ascii?Q?ipMM1vRdZAagpnpTXJrnLfAzapkmf2RW15hW31km5937t5iw0tDLTxyqCn0B?=
 =?us-ascii?Q?Xuy74naOeiEFnUPdGEmSMB0j59oDZqvuX5xrFqvj1BSqnuM3hpeYbuSiMcL/?=
 =?us-ascii?Q?X+DchuhP/m6YZXC8Xq74A73WY005aP0Sx0CZDtEzJ9FM1YZ55ptPljRZdS14?=
 =?us-ascii?Q?U9xD4iBV4vROlC9UHFtGtvzQ7QFMvj6tkZsWkN1y9dj7ywWIVaEEqeUwb4xT?=
 =?us-ascii?Q?vKvSU0aQBSKwHz9IzUtgSewWKU4BucsECqL6ksGEMBljMvYrTcrJ96xTm+IE?=
 =?us-ascii?Q?4mioUVZNBuaUpUlTXk7CZ5hz8Up41nUdkuEwXET/Dll79VoJlN2R9Gn/IoAG?=
 =?us-ascii?Q?FcSWk6lDP8pgz7jDLBawBRZjoh+IY0jtAhBxoXg6wJSMVYuZ5rIvtqkh2sbX?=
 =?us-ascii?Q?WpZa5zJr6rPu1GsccKSSpZlvlN5fyArYlkpH6AVUB587/QNX/3utL/thgZ2w?=
 =?us-ascii?Q?py9zmJDDVXySGknm+Qx9s/PWgzw+oQxaGhOBU4nF6tjhMu6Q812V8OQ0grjJ?=
 =?us-ascii?Q?YjnP4iaGGYx5beSlmg/tKf5FdAlJ5qBRDLjeqic4A8YZ1Th+cbiFRQEZ1YRL?=
 =?us-ascii?Q?xCOJegNadp2gRfejI9s82j8ObLWgwGpMv48Poo9oYkD+GoDGFirYYwyNuATM?=
 =?us-ascii?Q?K3PEUGZNBt1vwop3+eUeVgT0yXvssBWO54Y8eRPdyslzcgiWD3dxptQA5H2u?=
 =?us-ascii?Q?iaHH2EclkVoE5JyrPWJnI0p1ustBb57oy8JjdUWAKOpsseZZ5NSgQMg20Qqn?=
 =?us-ascii?Q?+a1Ich/sJ9QacakG76XAjxY3VoExjtSabL0hxIEBbDa0BXlLiHfIDjDJaXaa?=
 =?us-ascii?Q?z5T24Cmc51+IDMfcBsldfPR4LCUSxznECKdqeO9zZ2W+TvY+S6KLE9SV9gP9?=
 =?us-ascii?Q?xsS2bMu0+PNoRjIKn3NDOZHIkge0pDP/EqKqsYBGRIj7rWYK+OXgjClrZWxt?=
 =?us-ascii?Q?MSdm5bKrlTfyJchgYGxv6QVGGsNqyQcqli30sJ1hYnozDyobNjb36V/tbF2W?=
 =?us-ascii?Q?Rq67jnYrU3rTwZTUuUo3E2pRWR6N8BmjfsJelFGS?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ee603a2-29bc-4544-0f17-08dbd54e46af
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 11:33:57.4698
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z3KL2DB5oGeQRDyYF0NsIQc3W//tquh0JCdBB2y9A3z29G4i6TQmqN8oH/UxpdUY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7981
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 04:34:06 -0700 (PDT)

On Wed, Oct 25, 2023 at 09:10:08AM +0800, Baolu Lu wrote:
> On 10/24/23 11:00 PM, Yi Liu wrote:
> > This adds the scalable mode check before allocating the nested parent domain
> > as checking nested capability is not enough. User may turn off scalable mode
> > which also means no nested support even if the hardware supports it.
> > 
> > Fixes: c97d1b20d383 ("iommu/vt-d: Add domain_alloc_user op")
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > ---
> > v1: Based on Joao's dirty page tracking v6 https://github.com/jpemartins/linux/commits/iommufd-v6
> > ---
> >   drivers/iommu/intel/iommu.c | 2 +-
> >   drivers/iommu/intel/iommu.h | 2 ++
> >   2 files changed, 3 insertions(+), 1 deletion(-)
> 
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
> 
> Hi Jason,
> 
> Given that this fixes a commit in the iommufd tree, can you please pick
> this fix as well?

Done

Thanks
Jason