Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <fe834675-a745-42ba-ae4a-97f003f84d10@amd.com>
Date:   Wed, 25 Oct 2023 17:17:34 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 2/2] perf/x86/amd: Don't allow pre-emption in
 amd_pmu_lbr_reset()
Content-Language: en-US
To:     Peter Zijlstra <peterz@infradead.org>,
        Mario Limonciello <mario.limonciello@amd.com>
Cc:     Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Thomas Gleixner <tglx@linutronix.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H . Peter Anvin" <hpa@zytor.com>, linux-kernel@vger.kernel.org,
        x86@kernel.org, linux-pm@vger.kernel.org, rafael@kernel.org,
        pavel@ucw.cz, linux-perf-users@vger.kernel.org,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Ian Rogers <irogers@google.com>,
        Adrian Hunter <adrian.hunter@intel.com>
References: <20231023160018.164054-1-mario.limonciello@amd.com>
 <20231023160018.164054-3-mario.limonciello@amd.com>
 <ZTd6BYr17ycdHR2a@gmail.com> <38ea48b4-aaba-4ba4-84a1-e88d6cb9df94@amd.com>
 <20231024155939.GF33965@noisy.programming.kicks-ass.net>
 <47518940-2803-4a6b-88fd-8cfc872b4219@amd.com>
 <20231024163038.GC40044@noisy.programming.kicks-ass.net>
 <20231024163450.GB13938@noisy.programming.kicks-ass.net>
From:   Sandipan Das <sandipan.das@amd.com>
In-Reply-To: <20231024163450.GB13938@noisy.programming.kicks-ass.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?S1lMTmtTR21YUjIvdU0xS1haTE9IL2UzNk1qWjg3WXlDaVU0YXZ6WGZBOHkr?=
 =?utf-8?B?c1NmajI3citWSmRUOVlSa0VIMU84QmhiN1NmZGsrdWpNSHB2RHZna3g3L2po?=
 =?utf-8?B?K0JEa3ROUVBCYzFmRGxub1E4N29HOExOK21OOGJta2VncHZxWGZISnhaUnkv?=
 =?utf-8?B?NXhZdklaUGdQYnVhcGN2clJuTXNVTkZqdW9rekJnUXdPaExwT1NjcDZ2bk01?=
 =?utf-8?B?YXpmaU5hQUlSZlJ3MTdWR0NCRk9yTTRRMFpwSXVvMWxMTUpEZVc2K0kxelAx?=
 =?utf-8?B?RUt0MXFFMHBEYTFkeEkwSjhYaS9sZ1c0OG81R3JWK3d1dFp4S0czQVlUM1I4?=
 =?utf-8?B?T2wwU29GTXNkbUFRQTVhUWJiNDFmYUdqNml6S2FBUm5OQmQ3UU1FRnZaOHdj?=
 =?utf-8?B?K1JGMTQwdUF2RFRTeUpzeDM1VHk0dU9xUmp1dlR3Rk45Z0hPZGo2TFRMZ0RX?=
 =?utf-8?B?VlFyRWsrRXRWSTZ3ODZld21ra0RuYjhHaXI4NWc5VDJNanpLbEhvRlA2dFZZ?=
 =?utf-8?B?RFprSS9QdUxpUG1WNnRxeXMrODhqbTEzOGZVNDg5SUVjcmJZLzFxeVdsN0RK?=
 =?utf-8?B?TVJrbWo5S0Zmamc5S0ZYZlZ1bkVKdC9HRHQyVWFuVnNUZUJzZW5mVVUwTzI1?=
 =?utf-8?B?MFVpbzBHYWtjMlNjNGo3SWpQRlBUYVNSd1cyOERFVnhadkwzdWJkZWpEKzRk?=
 =?utf-8?B?Z1lwOHZ1MHkvOUdhSHI3S1dPRTVZRzZ0TG5Jc0dXMmNndFhlUkUwOHhEZU5x?=
 =?utf-8?B?Nlc1bEpwNXp6cWdwcW1xRjhKZFA3c0RFUU9PY3JXcEk1bWtpaU1GVFJwS0da?=
 =?utf-8?B?VkVaaVZmbFlHdnZwNktZeFhPOXBMd1hmNUFKeTNhbDJZbUlFYTFYQ2NwWGgr?=
 =?utf-8?B?bW9WdkhpanFscmlyOFhuWmNkUDcrUlc5Sm44ZzBOT0tNSlpCbm9xempSbitO?=
 =?utf-8?B?TmVSNHY2TVpLeXNkbGtvTXl2cmJmUDdvZmdBT1ZVOGpSS2NNeExaOVJ4R1Jk?=
 =?utf-8?B?QWRKeWM5VFE4STF0d09URUlKU256UHdTaVVBbTJPUWE2Z0dreEdpVmZ6ZUxL?=
 =?utf-8?B?amlCdkNjSWRrbWZ2VVhBZ0l4SE5xd3h4WkpreXlzNFp2RkFTdm1WWnFyaE15?=
 =?utf-8?B?RVYrZTNVVlk2dFlPQVBtMkhzU0l0aGNVRlBqNnVDY2Q3Rkd6d1NrWWNISExa?=
 =?utf-8?B?MXlZZFJ3dFNQWHowSktTcGVoWnRodUpxSEJvRHBGM0RkbkdnUjMwSjVNSXhh?=
 =?utf-8?B?RXRKcVhXQ0JZM2RndUdLTFZtSFVPb0FOU0l1QTJWTm9BeEtPUEowZmZBSkFn?=
 =?utf-8?B?OVVheDVOa2lZUlRVank2L0FxaFRIL0VzV0NCZU9zTGVqK01rMjNMSWh6VEtU?=
 =?utf-8?B?UDNIc2JGWGNjS05iQTFhWk9mVDlMOFJHZy9sTzJPSDU1cytLWE14YjVKN1Bw?=
 =?utf-8?B?QlBSdUM4YUVIU0daY0pRSlVKN3RSVDd5VHR6SmdKRitwSk5OajJPUXk1N3pV?=
 =?utf-8?B?dHF0VU5SZ2FRY3drYm9zRTAvMmlUL1o5ajF2Y012U0ViekxQa00rOWcwam1I?=
 =?utf-8?B?Zi9YMmVadFo2ZHlvMkwydkY3Y0V2alBvNEdHOGdxR2lHVEVKRGowb2RJQ3Ba?=
 =?utf-8?B?aVJzOEZPUWEzb09wTEFiMytRZ1pRZWZURmFxVFNJY0ZlOUU0RVp6SCtpOVFl?=
 =?utf-8?B?OFkxczFQOXVUV2JieURtZkVhdlhSaTRIbWh0TmtLTzBvV0Y1WE53aFRoTEIv?=
 =?utf-8?B?VXVMRHpma0dBbzM1bWp2QStjazRjalhEWlJuVjU3cEFrR1Yxd1RwRmNUanN6?=
 =?utf-8?B?cFRWNU0zdk8rTDdHV204MmM4RUxBS1NVZHJiQ2FqRWFHWjdLRDZ1V2hYb3ZX?=
 =?utf-8?B?eHg5UnFrSzlJd2JPYjkwSjM0NW03L3IwN1E5TW5PUkNnLytSQmNtU2IzQldJ?=
 =?utf-8?B?WllldDlJTm05aUpTRUVaa1Z6MW9KcXd3YStWblJIUWRYaGJ5NmFJb0hERlRp?=
 =?utf-8?B?alRUMmpQT3pZL253NEYxS1ZsNEdtd2tDR2paS2RVREtBNjVjNTA4eUJHZ1Fz?=
 =?utf-8?B?WnBQR0RxZFVxaS9VVm9ibWJjQWp5ZmtYUHdGcU9UbkNYcmVJUGFONGVIUVh5?=
 =?utf-8?Q?E4XabQci/JC/V4T9qT8KI8jvj?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 50bea83e-1d6a-4b91-5440-08dbd550266b
X-MS-Exchange-CrossTenant-AuthSource: PH7PR12MB5712.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 11:47:22.5091
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W9/ncSs0LoWLxIF/tHc4Lz7F8Sspu1LnrN3Jgsab6USXayLGYEw4JhSM0AufbOeGc8GlznVh72kGGw8ZPToPvA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7365
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 04:47:31 -0700 (PDT)

On 10/24/2023 10:04 PM, Peter Zijlstra wrote:
> On Tue, Oct 24, 2023 at 06:30:38PM +0200, Peter Zijlstra wrote:
>> On Tue, Oct 24, 2023 at 11:04:06AM -0500, Mario Limonciello wrote:
>>
>>>> IIRC this is the hotplug thread running a teardown function on that CPU
>>>> itself. It being a strict per-cpu thread should not trip
>>>> smp_processor_id() wanrs.
>>>>
>>>
>>> BUG: using smp_processor_id() in preemptible [00000000] code: rtcwake/2960
>>> caller is amd_pmu_lbr_reset+0x19/0xc0
>>> CPU: 104 PID: 2960 Comm: rtcwake Not tainted 6.6.0-rc6-00002-g3e2c7f3ac51f
>>
>> Very much not the cpuhp/%u thread :/, let me try and figure out how that
>> happens.
> 
> Uhh, my bad, these are the PREPARE/DEAD handlers, they run before online
> and after dying. The CPU is completely dead. Running lbr_reset() here
> makes no sense.
> 
> Did that want to be in amd_pmu_cpu_dying() ?
> 

Agreed, it should have gone into the cpu_dying() callback. lbr_reset() is called
once from cpu_starting() so I wonder if its necessary to call it again in the
CPU offline path.