Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2514074rda; Wed, 25 Oct 2023 05:13:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEwBszUW4z36lDfHwVzGN0IuoJv7Bt1ztiGmCF83r7N69GOkTsTBExDkjcZ8uoI/e+pfTUJ X-Received: by 2002:a25:44:0:b0:d9d:38cd:e054 with SMTP id 65-20020a250044000000b00d9d38cde054mr13735334yba.13.1698235994740; Wed, 25 Oct 2023 05:13:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698235994; cv=none; d=google.com; s=arc-20160816; b=X7tTE8lkjMdrPDqqWGpgsDp6afxq8p4+OHq8ASw611YjYV5wd/2HWDDH9ywXR59BLc kkLnpGj71vehynGcWqmuAYvc5L1Qu28b/vIPCko+V1DDLDZ7DiJpJqlqGG5YHsNg9y4D qRlB+WFjswWdeoXZDEQIYmhQtXQycMbMu0Z7g/5KoVgOSkLAhWjHTfZjLgRWSe2CN3HT uCqrITrULhe2+s08M3Gf0AOl7sEyulAEK/Xmp3Szij/AutrUKbT3J7V1x3d8GXdSIsC9 omrc5LiwqHs3M5N4/9YrARyuoOernBJAck7lyO6LU6Ds1n6i0QEDeqYhKvhGUkyHkV8l tpCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2qzhiukkgpOy6J0SM/VQSNu7HQN67lhA2KMCFySs/Z8=; fh=Q0JpVfPEZhMiWKgkq1SU/2iPe5ydYttTSZwNuIs4ezE=; b=wpnEIbgACwIMEQAZU29A//5npV2ZPdMBSb+uMXAdMKtO4bO3HsXB+1wNJyv1LUXuVD qj4xSNgpKqyiKL1bU5hTiqVDZchj2AkqzAHBZGJZX9TCM32eCBu6QaHXBY3YWle98gLc l8D74PUZsJSzrY00AaQ0lQKWa/+Yuwv3CQsCpDj9KhGlyLHDKhEMRw3uzMPO2MazocQI 3B4xTF6gynrGJFQ8UBNf7fiaYROpRJG2dlUqMbO84Tz5OWBDEeQLCT0dXoGpFOBz+Hts IurpMR4qmJYrlSt4E17pp6eicJglFokD0asFunskN8yctC2LfF+/0lj9zRYDeaIZOhZn 5eug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="emXY/bJn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id 83-20020a250556000000b00d9caf9456a3si9836627ybf.409.2023.10.25.05.13.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 05:13:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="emXY/bJn"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 57FAF8024AD0; Wed, 25 Oct 2023 05:13:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234684AbjJYMNF (ORCPT + 99 others); Wed, 25 Oct 2023 08:13:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232789AbjJYMNE (ORCPT ); Wed, 25 Oct 2023 08:13:04 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BCD4B0; Wed, 25 Oct 2023 05:13:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 98D37C433C8; Wed, 25 Oct 2023 12:12:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698235982; bh=4+xwe367k3YeGIMrExzUgwgVoVE6QX1MvS5Q6KetWyQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=emXY/bJnZ6TI8CxNbrMekyo38I5pF6dXpoLNZxXDhO21G9HLiHXpB8Kql49N6+aDZ nHsPyJkrXdoZNYfiOoMkPipCiO++hdtS5yfcbQKrcFdlEiNDMZHtNzs/UyS7n/yWHQ Pxy/OVIGSSPfFxZO0vGjr/3MV/Z9jKYo6fHFG4Oag1nqS4xW4ylaMr6nfbD1lZCi5q SJqS6zGjboPBgEFuIzBzTokukJn8HePbfKgBVFm8LkbFloKzNWZhmd6C0uuAK0X607 9uaKapWvKiAyNk6/my4ZtbAmoDj9yuAumCAks15RpaYiiL2DR0b7Ul6WhttlnqYtTc D/WDMWLfVgUnA== Date: Wed, 25 Oct 2023 13:12:55 +0100 From: Lee Jones To: Anjelique Melendez Cc: pavel@ucw.cz, thierry.reding@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, agross@kernel.org, andersson@kernel.org, luca.weiss@fairphone.com, konrad.dybcio@linaro.org, u.kleine-koenig@pengutronix.de, quic_subbaram@quicinc.com, quic_gurus@quicinc.com, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-pwm@vger.kernel.org Subject: Re: [PATCH v6 3/7] soc: qcom: add QCOM PBS driver Message-ID: <20231025121255.GM8909@google.com> References: <20231020182218.22217-1-quic_amelende@quicinc.com> <20231020182218.22217-4-quic_amelende@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231020182218.22217-4-quic_amelende@quicinc.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 05:13:12 -0700 (PDT) On Fri, 20 Oct 2023, Anjelique Melendez wrote: > Add the Qualcomm PBS (Programmable Boot Sequencer) driver. The QCOM PBS > driver supports configuring software PBS trigger events through PBS RAM > on Qualcomm Technologies, Inc (QTI) PMICs. > > Signed-off-by: Anjelique Melendez > --- > drivers/soc/qcom/Kconfig | 9 ++ > drivers/soc/qcom/Makefile | 1 + > drivers/soc/qcom/qcom-pbs.c | 243 ++++++++++++++++++++++++++++++ > include/linux/soc/qcom/qcom-pbs.h | 30 ++++ > 4 files changed, 283 insertions(+) > create mode 100644 drivers/soc/qcom/qcom-pbs.c > create mode 100644 include/linux/soc/qcom/qcom-pbs.h The LED patches look good to go. What's the plan for the SoC driver? * Who will review it? * Shall I take it via LED with an Ack? -- Lee Jones [李琼斯]