Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762090AbXKTVcw (ORCPT ); Tue, 20 Nov 2007 16:32:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754840AbXKTVcn (ORCPT ); Tue, 20 Nov 2007 16:32:43 -0500 Received: from g5t0006.atlanta.hp.com ([15.192.0.43]:6218 "EHLO g5t0006.atlanta.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757503AbXKTVcm (ORCPT ); Tue, 20 Nov 2007 16:32:42 -0500 From: Paul Moore Organization: Hewlett-Packard To: Kamalesh Babulal Subject: Re: mm snapshot broken-out-2007-11-20-01-45.tar.gz uploaded Date: Tue, 20 Nov 2007 16:31:45 -0500 User-Agent: KMail/1.9.7 Cc: akpm@linux-foundation.org, mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Whitcroft , Balbir Singh References: <200711200953.lAK9qxjO030444@imap1.linux-foundation.org> <474344D0.40704@linux.vnet.ibm.com> <200711201548.44542.paul.moore@hp.com> In-Reply-To: <200711201548.44542.paul.moore@hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200711201631.46068.paul.moore@hp.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1709 Lines: 41 On Tuesday 20 November 2007 3:48:44 pm Paul Moore wrote: > On Tuesday 20 November 2007 3:34:24 pm Kamalesh Babulal wrote: > > Hi Andrew, > > > > The kernel build fails, in selinux with following error > > > > CHK include/linux/compile.h > > UPD include/linux/compile.h > > CC init/version.o > > LD init/built-in.o > > LD .tmp_vmlinux1 > > security/built-in.o(.toc1+0x928): undefined reference to > > `selinux_xfrm_refcount' make: *** [.tmp_vmlinux1] Error 1 > > 11/20/2007-14:42:08 Build the kernel. Failed rc = 2 > > 11/20/2007-14:42:08 build: Building kernel... Failed rc = 1 > > > > The patch causing this error is git-lblnet.patch, where in the > > selinux_xfrm_enabled() is called from security/selinux/hooks.c, depends > > on the extern atomic_tselinux_xfrm_refcount. > > The problem appears to be that the selinux_xfrm_refcount functionality is > not properly protected by CONFIG_SECURITY_NETWORK_XFRM. I'm fixing that > now. I've fixed the problem in the git tree below, meaning I just did a quick compile without defining CONFIG_SECURITY_NETWORK_XFRM and everything appeared to link correctly. I haven't had a chance to try booting the fix yet because my test machine is a little slow compiling right now, but the fix was pretty trivial (simply move the extern and the inline function) so I don't expect any problems. * git://git.infradead.org/users/pcmoore/lblnet-2.6_testing -- paul moore linux security @ hp - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/