Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2527953rda; Wed, 25 Oct 2023 05:36:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2MIezuYEDpoq9GkI43/O4eQ1KT6xAd+9B3D0zItGjOqrjqyY0bPDgKXIQqGXyqSad/iUN X-Received: by 2002:a25:d251:0:b0:d9a:6301:c82b with SMTP id j78-20020a25d251000000b00d9a6301c82bmr15810181ybg.13.1698237360518; Wed, 25 Oct 2023 05:36:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698237360; cv=none; d=google.com; s=arc-20160816; b=scNHKKy50xXVj351Ebq76z1xySDdCfDk7FW1bEK0N3K2+tMzpxtpVy3w50gPpNdqLS zGTitz+AK2oLgOyfA6S4hHrpTrzZTUsbZGqVtsUT45VMm4sLFfaKz2igw5S4fA0H/ujq UAtw5TJr9cP+Ix5A/612JCCYTdF9HHlieAG8kMkNn2sfw686gYqk+XC3l9mMR6OY5cyG LFwN5OYWBN7Jhd6EJ2Pk8LA0V3afucB9MEqq9yzGJO6AqhnB4oHikuHi7a8I2F2kxAJ8 ymNZHCteLxemyxQEL2vRfLZynsXxjtRRlHiSTM7QZj7aXQOlUtf/PuarkV9xsQ5NLS/h IBAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=e9rhzqr3NOHtVKCBuqfpDxgciMBYDCCCmcwS5w2Kpjs=; fh=6LR9+wg3MGY99qv9/kZSSNaV5/5IWBj6eVgBuEwpmd8=; b=Dpn2uztu7rlCR3wYootNlltss1f1no/+fjMRqWU5PWoq3ss7zB7iF94dkSZNwajR16 SzMKN35zSZWLshb4UZtZHyID0kRfgJ4RKEV9j/aZ0E0pXDhBPEjA/VWbjrecr0NmhZAC kA8IhnFJJBULdnuoXO+tEXR8biJjCg9p2xckJFAaf2YWB2FzlbWG0nD60e3F5Ttwp0Q6 ZX0sxhvWkL8MlU9H1FiWkbbGXqcQhzMkhyCR/byg+YQuu+xF25sAZghCYCxrWRj3SABz Zb3Di5Yvwtb0GvmcsSIZnQLDeoP0hzOlu+EgEfeZl8TKHPUmJvW/W92bzcjEmpIWSR53 MtdQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R5Zbuhpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id x92-20020a25a065000000b00da02790c22asi5087574ybh.715.2023.10.25.05.35.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 05:36:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=R5Zbuhpx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 9B013808725E; Wed, 25 Oct 2023 05:35:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344024AbjJYMfZ (ORCPT + 99 others); Wed, 25 Oct 2023 08:35:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344017AbjJYMfW (ORCPT ); Wed, 25 Oct 2023 08:35:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69F49CC for ; Wed, 25 Oct 2023 05:34:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698237283; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e9rhzqr3NOHtVKCBuqfpDxgciMBYDCCCmcwS5w2Kpjs=; b=R5ZbuhpxT/U0CDLwXSLp1+O6Oa0KP4K4bj2H34j10vvLjLcBPjoJ3fzqTJxICn3tq8DqAm mloi7miOxU7LXacqybF0yqffLCLu43Fd59LXXNrLYbrSrL+EEcIsWYjMFx+wg6VSku/kWv 3DArUWMfNM8+EFnYedfbAzBo4hzljo0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-267-FJPbped1NaSK3-7XS-bRXg-1; Wed, 25 Oct 2023 08:34:38 -0400 X-MC-Unique: FJPbped1NaSK3-7XS-bRXg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A91512812940; Wed, 25 Oct 2023 12:34:37 +0000 (UTC) Received: from [100.85.132.103] (unknown [10.22.48.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6593725C0; Wed, 25 Oct 2023 12:34:36 +0000 (UTC) From: Benjamin Coddington To: Christophe JAILLET Cc: trond.myklebust@hammerspace.com, anna@kernel.org, chuck.lever@oracle.com, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] NFS: Fix an off by one in root_nfs_cat() Date: Wed, 25 Oct 2023 08:34:35 -0400 Message-ID: <11A69D01-44A5-4261-BF9B-EC3A1209E3F1@redhat.com> In-Reply-To: <7f97bb62c4e8137c5d7f7a7a30789440a5102b3f.1698183837.git.christophe.jaillet@wanadoo.fr> References: <7f97bb62c4e8137c5d7f7a7a30789440a5102b3f.1698183837.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 05:35:38 -0700 (PDT) On 24 Oct 2023, at 17:47, Christophe JAILLET wrote: > The intent is to check if the 'dest' is truncated or not. So, >+ should be > used instead of >, because strlcat() returns the length of 'dest' and 'src' > excluding the trailing NULL. > > Fixes: 56463e50d1fc ("NFS: Use super.c for NFSROOT mount option parsing") > Signed-off-by: Christophe JAILLET Minor typo in the body: >+ should be >=, otherwise looks right. Reviewed-by: Benjamin Coddington Ben