Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2528040rda; Wed, 25 Oct 2023 05:36:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGAJKcYWRAIWd3Ct5xDMDzD7FsZsFvH+rbB/CKBD2XDltUewQhjL7am8NAEGOwtTC/Mn7pu X-Received: by 2002:a81:4e16:0:b0:5a7:bf2b:dc27 with SMTP id c22-20020a814e16000000b005a7bf2bdc27mr15307809ywb.14.1698237369222; Wed, 25 Oct 2023 05:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698237369; cv=none; d=google.com; s=arc-20160816; b=OtJfzmAlGTfgqqJ/uW+znHcGu7ng0oJJUHcxFUXb6vzI1TGOsMsWQEHeHW6A0hjjbK Pr5L2pQLdXaD0BFRv2cN8CWvglx40enh7SaGJDZmR3Q45b5CPyPbcWMjDP6atwbOFFUu OS8Db7/x8zHI950KdRmx13tuVsqqLIvAY+YeiN3LD5Ra6kOFphHP0OBzxJDuspdWMpJ4 OSDj6MLCjlVrx4lRpLVGEt1znX/EHi/ZanMC59ER5hjqS8JZJ+K2LBuWilBikOPYuZLG QqhR5uxy8lmuwEZT623XfZlCYmoOT5oKi9NgECmKDUqrONTsXSZeetZ4FSf/yZs+0+OE JgtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=IIfXyZoxzqzNs1x6NcY6WinvIChe9VAS0A6uJtrJM9Q=; fh=YB/uXhonq8Qy+beGXYaNmXaHQAOouNCJbi/U8zEtxqI=; b=xEIglSeARA/3/HNqu7F7Wp4QHnR+Jw4dO2RTTmoiAQPJEG35bv3LCy6u5m0CX6zgpL cpoTrMQMlHs0u1oL61tImYAHHdqiJr3Y7QZEi6ntNh+g6H6Wx65BF+X23dHDsKFZ66qS ZA6hLWo1v1zZUjlQ9VYTv1ncqKIhN85k+Z8UkBgLD52Pf6dSGA0X44bTm8QU48CnnVkD s7UXeEcZarzh4ZhpCRwOwTx2py25Jy5YBmRAIe8pQQFa3PA+2W4fcyr6bQV8aeYy7V0w 3b1E8DJG21L1mafnM2wRD8imuA9uk23RlFpITG9Pj0SWtD+kpXHovRWGBhA3s2CdP4O1 aKAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f8P6l0TP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id v188-20020a0dd3c5000000b005a7be928f8bsi9977705ywd.272.2023.10.25.05.36.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 05:36:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f8P6l0TP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 1DE338022C3F; Wed, 25 Oct 2023 05:36:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234875AbjJYMf4 (ORCPT + 99 others); Wed, 25 Oct 2023 08:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234846AbjJYMfy (ORCPT ); Wed, 25 Oct 2023 08:35:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F374E13A for ; Wed, 25 Oct 2023 05:35:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698237308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IIfXyZoxzqzNs1x6NcY6WinvIChe9VAS0A6uJtrJM9Q=; b=f8P6l0TPg4TxV5026xCqpWx/DW5cMtoKU5R2TdVrO5IOBb3CC59TOEHm2il/caVdYE15VM o8owc6SNPkqEkhxaBTINiuvk2a4xsigpMJS+MDcRnVD/CT0f3zcYQdyMdgzE/RchZ90Ife wtvDkOgmX9P9TOwe9vtRsH0EhoKQK2M= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-438-Q8Qxy8Y6ONSwH4z1ALu1_w-1; Wed, 25 Oct 2023 08:34:56 -0400 X-MC-Unique: Q8Qxy8Y6ONSwH4z1ALu1_w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 14F66811E8E; Wed, 25 Oct 2023 12:34:56 +0000 (UTC) Received: from [100.85.132.103] (unknown [10.22.48.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CAF125C2; Wed, 25 Oct 2023 12:34:53 +0000 (UTC) From: Benjamin Coddington To: Christophe JAILLET Cc: chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, trond.myklebust@hammerspace.com, anna@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] net: sunrpc: Fix an off by one in root_nfs_cat() Date: Wed, 25 Oct 2023 08:34:52 -0400 Message-ID: In-Reply-To: <856a652a7e28dde246b00025da7d4115978ae75f.1698184400.git.christophe.jaillet@wanadoo.fr> References: <856a652a7e28dde246b00025da7d4115978ae75f.1698184400.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 05:36:03 -0700 (PDT) On 24 Oct 2023, at 17:55, Christophe JAILLET wrote: > The intent is to check if the strings' are truncated or not. So, >= should > be used instead of >, because strlcat() and snprintf() return the length of > the output, excluding the trailing NULL. > > Fixes: a02d69261134 ("SUNRPC: Provide functions for managing universal addresses") > Signed-off-by: Christophe JAILLET Reviewed-by: Benjamin Coddington Ben