Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
Date:   Wed, 25 Oct 2023 13:41:45 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Oleksij Rempel <o.rempel@pengutronix.de>
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Conor Dooley <conor+dt@kernel.org>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 4/7] regulator: dt-bindings: whitelist
 system-critical-regulator property for fixed-regulator
Message-ID: <e2ae68a5-b6fc-4b0f-b198-e635435c33ce@sirena.org.uk>
References: <20231025084614.3092295-1-o.rempel@pengutronix.de>
 <20231025084614.3092295-5-o.rempel@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="snUpAOfYIdGu4zP7"
Content-Disposition: inline
In-Reply-To: <20231025084614.3092295-5-o.rempel@pengutronix.de>
Precedence: bulk


--snUpAOfYIdGu4zP7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote:
> Allow fixed-regulator to be marked as system-critical by whitelisting
> the 'system-critical-regulator' property.
>=20
> This property indicating that the fixed-regulator is critical to system
> stability or functionality, aligning with the recent changes in the
> regulator core handling of under-voltage events for system-critical
> regulators.

Why would this need to be something we explicitly enable for a given
regulator?  Surely this is a property of the creativity of hardware
engineers rather than the regulator itself.

Also please avoid the use of the outdated terms whitelist and blacklist,
pass and block lists are often a good alternative.

--snUpAOfYIdGu4zP7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU5DQgACgkQJNaLcl1U
h9AdYggAhZQKEysbWfpHAlugx8AivAUbYgLyylR9UaQWeuqprdjhZheLHYMK8zsB
OY6KCpgqc4CETsiBQNtJxKDKrckLqPNJPtEbz12ntgjpTRZEMO92A31iYsfR2xAe
W7R0VmxFeUOJnzQ0fXMgnvSkS9aRF8HfuRIEH+hh8nYr5+Z9+LHPRNlm7qMk8KH0
GuW1jn3o9dQ1TgZy2RHDSSTrUZoGiDrmGyyqjWeburUFG63NHFAhm/p69WpNWf4N
VjbQilSJYiDeNq9k+7bBy+/Bk63oBZAowt7vAsJGoPxqw+G2vJhP1GneqAQD1zVh
34arlTX8Bt081igWxEk0mKg6b2bacw==
=zJKI
-----END PGP SIGNATURE-----

--snUpAOfYIdGu4zP7--