Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2534708rda; Wed, 25 Oct 2023 05:47:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE8RLGY5CuhMLDX1kVFDzrLA6iTIpfAoV4OYYioX7Us14mQQTpKUO6/SiKQiTECEh+d7IwR X-Received: by 2002:a05:6808:2105:b0:3af:8050:369f with SMTP id r5-20020a056808210500b003af8050369fmr18978514oiw.6.1698238073901; Wed, 25 Oct 2023 05:47:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698238073; cv=none; d=google.com; s=arc-20160816; b=V5B5tEhoz/l2Qm9bB2rNSZlhbhhI4BfOyJmGXO4n8cy0Dn1sZvLLXrzoIN/M0RR+yo pRNyH4WQWgNHUS938+hlN1X3v8neqkq1kPvUom7NhmetfHxyjpsyL1oli3L5mlQ2OKd+ 2jqr/eR3HNeTqFLrKuXfN3/xWzlHmC3TGNgAnUUKwhhuC1ErtUWxW6eEpwt/hr/4SOeG DVc9tdFPmfWJdS698Nd2wYkgEMQ+Hziv95wbVtEUFZZwtzm74U5opV+hsGz3pvbHVHtC UgSx29jEYb+pDun8HWo9ortCdpWPONr0loNPMtSUOVqalwYeg2mceLqK+sKPIVviDIoZ YB8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pJe37MYiPaeidMaZQc4YyFNtFSj/xgS9hyCox8Zlw4w=; fh=AfM8wbkFcXZ9m0/zB/hCrnSOXu1WVFFxf81izzwkKmQ=; b=0B4f8r8dOmmykoaqwud2WjxDtRLFpW4alH2HuztyPJibj56G8LZl1EJCT/Kpbk2Ufb oL/6XsrrC1/sSfqVYyPuhf8X+ztTtHt+J7JvjExuMMWSTpK0R+S1JMnC7VC4WjIjjuHl yOcqn+wwOYWT5dy9pdMQH6oFAcO0n5ezI8CDAPT/MHAdt+CQNTqwRHTXxgZYE2P2NUAH z4sSSCRt15v60kVqiNw5pp2kHShIUB0xQ5u0W3/TR2aWelkTvR4xS+hZatr54/w8R4jU tOyyrcfN2YqOblD+O5Mn/TDfu+9Fd15/9Qq0lSUqFYSkbn6CJdacktR3EU+mkpf7hnOI FzGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YATVW8Kq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id s49-20020a25aa34000000b00da07c0bd35dsi1605409ybi.25.2023.10.25.05.47.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 05:47:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YATVW8Kq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id A27DF80D291E; Wed, 25 Oct 2023 05:47:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234894AbjJYMrq (ORCPT + 99 others); Wed, 25 Oct 2023 08:47:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232807AbjJYMrp (ORCPT ); Wed, 25 Oct 2023 08:47:45 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 679C490 for ; Wed, 25 Oct 2023 05:47:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3C9E5C433C8; Wed, 25 Oct 2023 12:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698238063; bh=CyqpQORDLu/59HchAbKGaMl6wNYR768sbZQ93p3rYeg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YATVW8KqlFBX1JZPFRjcCsvP4x4eJPNtjpD65YAuL8PazS+HeumlBZZokf3o5lwvd iVMMaJNXaDKw6Z0oWv1eNeK6MyuMIdu/CpuQkrH5Y0HuaDlfNP/9QL6TWpgVF1eKay V+iqAFkoR8sSqzeuv1DLzujhRFm9naJaPVFPzXwud+g4+Ozh7PuwF5p4zRibwCJtjE UxQJbT8OQkzdMshisVf+9fHDgVAWtWtum5z6U16KPaDn+OwbfLVnHZH8ifXTOUQ6tP 7v4/sEW+PqMcgjWqQIRmaS9GIbJ0jGrwZ9QiG/4Q5vOSGVKDxQURd5grtWNBExk5B/ kw2MQo2ZKgAvw== Date: Wed, 25 Oct 2023 13:47:38 +0100 From: Mark Brown To: Oleksij Rempel Cc: Liam Girdwood , Rob Herring , Krzysztof Kozlowski , Conor Dooley , kernel@pengutronix.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 2/7] regulator: Handle system-critical under-voltage events Message-ID: References: <20231025084614.3092295-1-o.rempel@pengutronix.de> <20231025084614.3092295-3-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="mdxULxN83Uy27oHH" Content-Disposition: inline In-Reply-To: <20231025084614.3092295-3-o.rempel@pengutronix.de> X-Cookie: There's no time like the pleasant. X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 25 Oct 2023 05:47:51 -0700 (PDT) --mdxULxN83Uy27oHH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Oct 25, 2023 at 10:46:09AM +0200, Oleksij Rempel wrote: > + if (rdev->constraints->system_critical && > + event == REGULATOR_EVENT_UNDER_VOLTAGE) > + hw_protection_shutdown("System critical voltage drop detected", > + REGULATOR_DEF_EMERG_SHUTDWN_TMO); > + This should probably be a switch statement for the event and also handle REGULATOR_EVENT_FAIL, possibly other errors this would also be appropriate handling but it's less immediately obvious and we can always extend later. --mdxULxN83Uy27oHH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmU5DmkACgkQJNaLcl1U h9AQGwf/TfaVoP11UEL9ECg1F1JcTUxtIKKbV2e5h8+gGyu/nUdTL2RCcBm0xYbi ngVCbCI0ei6qYIIgd0hfGwjxFk8+hOK9mQR1oUy3zJ2ICa+iQjXoH/6cYrRJ/8Hm k6sI8toUJNpUsFRNpOcuvcGCd1oCAQPOH1Xd2h67ay133OnFdWPrU+se41uC8Vg7 6eLPt2hMB2MKyaDCon4JYnYl9ZmIsQUHJ2Ik/2xEhxdkAngx27nOrlpAGy9ADyWa 1CyJIkW0bQhXx3qVvaBbI3y/BTybwQdyixxuch+6EmTXSFR/3lnTAUHvlhgLY2ZX tjH8WxzNCKXEw5I3UbM5/KZZ6t2TBw== =Sbh1 -----END PGP SIGNATURE----- --mdxULxN83Uy27oHH--