Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Wed, 25 Oct 2023 12:54:44 +0000
To:     Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
From:   Simon Ser <contact@emersion.fr>
Cc:     Johan Hovold <johan@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Andy Gross <agross@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] soc: qcom: pmic_glink: fix connector type to be DisplayPort
Message-ID: <EeTPIPMpLMJf5ZaAnmfLL8a1MUy4DRxST6oU_-N44pa3XfyglLs_sWXdnOvjJLTzahjZhkRqWIO9TwXj4bhSKwBIUYkuIufXms2UjZ7MJjA=@emersion.fr>
In-Reply-To: <65f841ba-5b70-4cbe-98e0-3d53e5b7944c@linaro.org>
References: <20231010225229.77027-1-dmitry.baryshkov@linaro.org> <ZTkIpMWpxKzSE7gQ@hovoldconsulting.com> <NDl6Ye92jJDp3fm20AwcuUKWuP8tzQ9CyWGGRltZ_DxYgxep2DO8Wil0Nmsfmhp1j4vAp9Yu1duiHeQkjBG-bcAdFoW3ZbWxvVqrCEpQe_4=@emersion.fr> <65f841ba-5b70-4cbe-98e0-3d53e5b7944c@linaro.org>
Feedback-ID: 1358184:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wednesday, October 25th, 2023 at 14:45, Dmitry Baryshkov <dmitry.baryshk=
ov@linaro.org> wrote:

> On 25/10/2023 15:29, Simon Ser wrote:
>=20
> > On Wednesday, October 25th, 2023 at 14:22, Johan Hovold johan@kernel.or=
g wrote:
> >=20
> > > I was just going to post a patch fixing this after finally investigat=
ing
> > > why the DisplayPort outputs on the X13s were annoyingly identified as
> > > "Unknown20-1" and "Unknown20-2" instead of the expected "DP-1" and
> > > "DP-2".
> >=20
> > Note, ideally userspace should use drmModeGetConnectorTypeName() from
> > libdrm to figure out the proper name for a connector type. That way we
> > only need to update a single spot when adding a new connector type,
> > instead of patching a whole bunch of programs.
>=20
> X11 does its own thing. It further "renames" DP MST connectors. So on my
> laptop I end up with DP-1-1 in xrandr, but DP-3 in kernel.

Right. But that function only takes in a connector type enum as input,
and returns a string for the type only. It doesn't include the suffix
with the number.

IOW: xserver could use drmModeGetConnectorTypeName() and then append
"-2" or "-1-1" or whatever.

But with the current appetite for xserver development this is probably
not going to happen (and doesn't matter very much).