Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
Message-ID: <c84f0999-5de0-1161-4061-75aa2795d45a@gmail.com>
Date:   Wed, 25 Oct 2023 09:16:50 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.12.0
Subject: Re: [PATCH v9 01/20] dt-bindings: PCI: Add PLDA XpressRICH PCIe host
 common properties
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        Conor Dooley <conor@kernel.org>
Cc:     Minda Chen <minda.chen@starfivetech.com>,
        =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= <kw@linux.com>,
        Rob Herring <robh+dt@kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lorenzo Pieralisi <lpieralisi@kernel.org>,
        Daire McNamara <daire.mcnamara@microchip.com>,
        Emil Renner Berthing <emil.renner.berthing@canonical.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-riscv@lists.infradead.org, linux-pci@vger.kernel.org,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mason Huo <mason.huo@starfivetech.com>,
        Leyfoon Tan <leyfoon.tan@starfivetech.com>,
        Kevin Xie <kevin.xie@starfivetech.com>
References: <20231020104341.63157-1-minda.chen@starfivetech.com>
 <20231020104341.63157-2-minda.chen@starfivetech.com>
 <8ced1915-7b94-4abc-bd8b-cb4bf027fa01@linaro.org>
 <bd441e1d-73ae-4abc-8eb2-877419acb2df@starfivetech.com>
 <97e2decd-f6a3-91cb-6ca7-539f53b686f3@gmail.com>
 <20231025-dotted-almighty-ae489e9eb764@spud>
 <3d7a2dba-53f6-4625-8981-fbeb469418c1@linaro.org>
Content-Language: en-US
From:   John Clark <inindev@gmail.com>
In-Reply-To: <3d7a2dba-53f6-4625-8981-fbeb469418c1@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

That is correct, I tested the entire series against Linux 6.6-rc7 and 
confirmed that pcie/nvme/usb work on the VisionFive2 device. I was 
unable to test the Microchip side of the equation. I will be more clear 
as to what I verified if I comment in the future.

John Clark


On 10/25/23 6:41 AM, Krzysztof Kozlowski wrote:
> On 25/10/2023 12:28, Conor Dooley wrote:
>> Hi John,
>>
>> On Mon, Oct 23, 2023 at 11:09:50PM -0400, John Clark wrote:
>>>> On 2023/10/20 19:04, Krzysztof Kozlowski wrote:
>>>>> On 20/10/2023 12:43, Minda Chen wrote:
>>>>>> Add PLDA XpressRICH PCIe host common properties dt-binding doc.
>>>>>> Microchip PolarFire PCIe host using PLDA IP.
>>>>>> Move common properties from Microchip PolarFire PCIe host
>>>>>> to PLDA files.
>>>>>>
>>>>>> Signed-off-by: Minda Chen <minda.chen@starfivetech.com>
>>>>>> Reviewed-by: Hal Feng <hal.feng@starfivetech.com>
>>>>>> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>>>>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>>>>> ---
>>>>>>    .../bindings/pci/microchip,pcie-host.yaml     | 55 +-------------
>>>>>>    .../pci/plda,xpressrich3-axi-common.yaml      | 75 +++++++++++++++++++
>>>>> Where was this patch reviewed?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>>
>>>> This Conor's review tag. v2 : https://patchwork.kernel.org/project/linux-pci/patch/20230727103949.26149-2-minda.chen@starfivetech.com/
>>>> This is Rob's review tag v3: https://patchwork.kernel.org/project/linux-pci/patch/20230814082016.104181-2-minda.chen@starfivetech.com/
>>> Tested-by: John Clark <inindev@gmail.com>:
>>> https://github.com/inindev/visionfive2/tree/main/kernel/patches
>> I suspect you don't mean that you tested this individual dt-binding, but
>> rather that you tested the whole series. If so, you should probably
>> provide this tested-by against the cover-letter instead of this bindings
>> patch.
> Yeah, otherwise I would like to hear how do you test bindings (other
> than dt_binding_check which is something similar to testing as compiling
> code).
>
> Best regards,
> Krzysztof
>