Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2567565rda; Wed, 25 Oct 2023 06:34:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG03O01fxiyjpvCElf+19hqXube7XPjsSac1+dxAtaKN/p00dLABwgR014USmEPIr2PV9Cb X-Received: by 2002:a05:6808:128a:b0:3af:744e:92ff with SMTP id a10-20020a056808128a00b003af744e92ffmr24480891oiw.34.1698240892289; Wed, 25 Oct 2023 06:34:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698240892; cv=none; d=google.com; s=arc-20160816; b=Gqe2Xv1Xuf1L8Hq68RCDyMZ9jCUWuGA9Cb31XtPMJjTPiRSh3ETTwNRYiynVLgwpSq lnhmSXYAI2dRyUSTH3N7Km6YJ21anaqbHHMQEjBspgTDKQRTPbtW2NCbTAKMi+O9h6sL 9KFxAj46I03ZUhZ7jGGwW+lJuXs+rwtV47YMC9ZBQaKm959/O/+GGrn3zawmCBs/AJ1P g4m17J4fJuGxevBBavmHIjdsf8NEr0rrgXZaJOU/mRJwbRcPgQ6Sc1izNxmDb4ClCARD bQ9zbPMtj5VrssaaXHboRH46LFuBReNs/zgXt05Ra16lukzRvLMjXFsOGg5NGW1M2af8 ufaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=yWRrV8TrzcGhn3y1mwcKlcTnHxjvKLZ2v/fGWRYHR+Y=; fh=ptQU3gpaN7TeuYf8G3uvZXE/0fEdmI5FvKsJWJFqOMM=; b=vho6fEs+NDSaeHeFJNmaccoJk0y0ZsWt1ZxKErFwc9cWHT23S4I95cqnj8nfV2R/u5 +E+Zs66E/UCkvSWYNu1it5LQteqGTUJVF19hST6StCOoYUmeUeBQy4keI6a3s26ZTu+X SPo3y122H+M3hTFgYbDbHq7aBqMAYWnciwYwMFgnEo8Fv0CryWjv0v5UQ591bbgac+iB Nk/S0QYHasTctAdyGxnrsF6N9dkvrG3dod9vwTAs6TqPsqBHCvKmqp2vaqME4R3Qh2ZU VMsfrwBaBUW4HmtqUBDsYY7iqZ5HdkbJ2Ca5prXQzOzeikuCKZvdMLExPxyyIkKG3Sd6 dzxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=DpG18zMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id k23-20020a25b297000000b00d9a5ec7105csi10182507ybj.610.2023.10.25.06.34.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:34:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=DpG18zMc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 9E32480FC704; Wed, 25 Oct 2023 06:34:50 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234778AbjJYNep (ORCPT + 99 others); Wed, 25 Oct 2023 09:34:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344564AbjJYNek (ORCPT ); Wed, 25 Oct 2023 09:34:40 -0400 Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9484F182 for ; Wed, 25 Oct 2023 06:34:38 -0700 (PDT) Received: by mail-oi1-x230.google.com with SMTP id 5614622812f47-3b2e4107f47so4029788b6e.2 for ; Wed, 25 Oct 2023 06:34:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1698240878; x=1698845678; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yWRrV8TrzcGhn3y1mwcKlcTnHxjvKLZ2v/fGWRYHR+Y=; b=DpG18zMcKs3ColGZAapMl1CKV1cFvDZaGTWUERIMODAkYeqzLUES7pVAxuspIFkhvc JeJ3hhaXWzyGa55J8V4yvjfe3JBsVcJaUi2hd95fXNuTY3BVfeq7NH8jjbFr7LdqrX4K JNYhYMD2+13IS9+jO3CjAb0ZwjVzAbnzDaMJBIwrDMUjVzySJUvGWnglRmbfjf7q3Qwd 4X+9eBDEjDy69CupQaNrrcjHh+U7Zj9HlL8OM4Vl+wC5sDFdXrY7S1xmB4xFkFp+QfV2 VS87FnYwB+/8te+5a9EbCbBivofXUjl6CXBaUrpyiUfX2noTw0rFtVvpwBbiGXXHDxlk /1uA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698240878; x=1698845678; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yWRrV8TrzcGhn3y1mwcKlcTnHxjvKLZ2v/fGWRYHR+Y=; b=STsNtwU8VubdeIU37JeQCsFUlDVaSQs4p8SJOYt2CrrBEds6sXCwAkCStK8Ztssz0e Jrw98SXPnEvbKnLQvUU08WuBfXeKzE880NlUirSndMuJaUD5sJ072h8dz3+VV7L6cG2g Zga7FWU5EyVFCESEmc6pS8hUM6vU2pg4BtPMh7DR1flOBepVMpwZpOqHbpTlEYndsRi4 5cUTwiB3iFbU6samz2MDWO5z6MllMuZlmzB8gGsVgBb50xenEJO6Zk5k6XJQyxTuryQm 3kYaV6qfDtXZWYOZ0VY02MO67Y3jY9Ok/mf+tiX8SsKD4XtnyA+7dQkx52kjvI2rFluq iA2Q== X-Gm-Message-State: AOJu0YzRxs3abyADlELPLHDk091V6PbKyhApdUHgZ4mwA/sduhoYNPtV qYx+HsPahOND4OyOdg6HaQK56B28ufVTVRQytJ4= X-Received: by 2002:a05:6808:b29:b0:3b2:f576:3f97 with SMTP id t9-20020a0568080b2900b003b2f5763f97mr15973522oij.12.1698240877826; Wed, 25 Oct 2023 06:34:37 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-26-201.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.26.201]) by smtp.gmail.com with ESMTPSA id a26-20020a05680802da00b003ae0e57874fsm2370339oid.21.2023.10.25.06.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:34:37 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1qve1s-004gmc-4f; Wed, 25 Oct 2023 10:34:36 -0300 Date: Wed, 25 Oct 2023 10:34:36 -0300 From: Jason Gunthorpe To: Lu Baolu Cc: Joerg Roedel , Stephen Rothwell , iommu@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Revert "iommu/vt-d: Remove unused function" Message-ID: <20231025133436.GP691768@ziepe.ca> References: <20231025131854.375388-1-baolu.lu@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231025131854.375388-1-baolu.lu@linux.intel.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 06:34:50 -0700 (PDT) On Wed, Oct 25, 2023 at 09:18:54PM +0800, Lu Baolu wrote: > This reverts commit c61c255e114c52682546447ed44d3470b5708134. > > The pasid_set_wpe() helper, which was removed by the reverted commit, > is still used by the nesting translation support in the iommufd tree. > To avoid a merge conflict, revert the commit. > > Link: https://lore.kernel.org/linux-kernel/20231025153455.283c5b12@canb.auug.org.au/ > Signed-off-by: Lu Baolu > --- > drivers/iommu/intel/pasid.c | 9 +++++++++ > 1 file changed, 9 insertions(+) Reviewed-by: Jason Gunthorpe Needed to avoid ugly conflicts with iommufd, Joerg please take it Jason