Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2573726rda; Wed, 25 Oct 2023 06:45:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJXKesfyheKxoqWQZKUhokXdsPPM7fdel/12Y/hil/dXBGfLE+SErLmNgh8H1k7OepVnim X-Received: by 2002:a05:6870:1202:b0:1e9:a5f2:aab3 with SMTP id 2-20020a056870120200b001e9a5f2aab3mr12044335oan.57.1698241504332; Wed, 25 Oct 2023 06:45:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698241504; cv=none; d=google.com; s=arc-20160816; b=H0NxqN7dpVy0buYKXbw1lvnWqYFaX3J6cbC+gRM7FzRY3rxfFMhl5FmKxTGl/tVpZZ PVVVyCq8S+tf9NqK3QxW08D/P++hC5n0Ya/ERuG3YSxOyaXo4XBwwi2/eHQll5adAwHm jaPe2ynnsEI6Dv6MZIuKpFIWR36JpSAN6bIo4ZLoJTyzmIwu6fHcVkXAyIPKIuB9f45t BCKcAsW0fCsm2EV4LUzvVsTd+jDvcEqlhywSxiHnVGp4jPGNxZCilKRefgmYZzY+eo/e hX0uk/9uX8w2WaAFkPafn+Z4zjrX55RT91f7eeYN5YGbcFK0eNi4P7LhjKAYHSw+mXqY apUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=+ieImtZGj+VOp5ccDeztXRroa/BoBO+stfynN77x4s4=; fh=+Mt4w7iswIcfKDweVL19UGZWfYWuNXRk0jBrOTrfUS8=; b=ySJs7eXxHumvmOKCmo1sx7IwCX49z70t802xViJx2cISUVCRmRG5GXQbwWkLSdV+b4 cR3odBFJCbORt3NFlV2RCR7axUqJdijoGDyRkZPFZpLbmZbv3CNbDHiR5WHPgbLBI4pJ Y9sl7ZjUldA1oRVd+3mNztc1LGICVnkRMIs4eQVQSnuINFQSd1112ac551lM5bM2EKDJ PdGvp1vAt4MysSuNssPCgTYDg3v1qul1K0bD8TrgDGUamzemFOBONtFkEUcSkV/hCe61 QON1KFtVYfLGT6w4yNdv9lnw2XzoaAdads0G1Qs1HJ4JuXyqVDRAc0XJW49Q3If77fLw zjiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=OMcAKbyU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id s64-20020a815e43000000b0059f4a492ebasi12369996ywb.195.2023.10.25.06.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 06:45:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=alien8 header.b=OMcAKbyU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7B28680FDDE5; Wed, 25 Oct 2023 06:45:02 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344527AbjJYNo7 (ORCPT + 99 others); Wed, 25 Oct 2023 09:44:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234901AbjJYNoz (ORCPT ); Wed, 25 Oct 2023 09:44:55 -0400 X-Greylist: delayed 11420 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Wed, 25 Oct 2023 06:44:52 PDT Received: from mail.alien8.de (mail.alien8.de [IPv6:2a01:4f9:3051:3f93::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB47F19D; Wed, 25 Oct 2023 06:44:52 -0700 (PDT) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id 8D95A40E00B3; Wed, 25 Oct 2023 13:44:50 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Authentication-Results: mail.alien8.de (amavisd-new); dkim=pass (4096-bit key) header.d=alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Fc0bnT_9t_Uq; Wed, 25 Oct 2023 13:44:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1698241488; bh=+ieImtZGj+VOp5ccDeztXRroa/BoBO+stfynN77x4s4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OMcAKbyUkyhuqj1UFc9ljgQxXx/4iDnowTXeq7KTMybgZzdM7S0yqlfMFwMNQogK+ o7cds6WEPJevCOXRK3/plplccqOSImH8RhAjRDu+ivVcaAoc4+flNZBJ7P9p8ExOz9 eE6xO9TRFbtCyPrNWN1aMmrvTXdra/rLEIhKFMcK+Z4FWklW+46Mr9NfRFTWdx442C vQf0ziYnpiAejiwLDVDqN/3skD2n8Z8VmLa5GFnLcfvXxT/EIk4OpvgDUK4Kw/5CU+ 2eZJh92QixzUyta0Vcn51qj3YFDBJbP1Qu2fLKY1Nqc3iTmCfvIZIa63Fmx8KRJAyb aGPCeBmtg5fkgb82mRF6wA3bM6IXyjEVs4QQm2Pare6nAha+WmH3QeCz+RSlhdN7iH cYkUWvfPzT8EspK1cwlTD6AHy7W2Zz0PYeC/aRQuiBN0ts4jvY6jpTRaJ+4Ak0MBBf dMe+r6HUKUPf5a8xS9nhwlgsmk7RaIIsNG35ykeiNGOJd8Ktxewx9K0xkXwYuSHMjR TGBdHsXswCUnMdLud8l56yK+te3+72BH2EL+90wue8aqWKUjRW+6AZDoIcsAvCPf0L L/HnqzY/x2fUdh7331lw3NQ5alr6ljA/L+9+f8+l5oeP3Xb7gR68t6Z+R0JI3jOSZr TgkiOe1BkQgz8i9OugTPbVGQ= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 6C1F840E0187; Wed, 25 Oct 2023 13:44:30 +0000 (UTC) Date: Wed, 25 Oct 2023 15:44:25 +0200 From: Borislav Petkov To: Juergen Gross Cc: linux-kernel@vger.kernel.org, x86@kernel.org, virtualization@lists.linux-foundation.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Ajay Kaher , Alexey Makhalov , VMware PV-Drivers Reviewers , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Boris Ostrovsky , xen-devel@lists.xenproject.org, Peter Zijlstra Subject: Re: [PATCH v3 1/5] x86/paravirt: move some functions and defines to alternative Message-ID: <20231025134425.GEZTkbua5w0bI2GQlP@fat_crate.local> References: <20231019091520.14540-1-jgross@suse.com> <20231019091520.14540-2-jgross@suse.com> <20231025103402.GBZTjvGse9c0utZGO0@fat_crate.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 06:45:02 -0700 (PDT) On Wed, Oct 25, 2023 at 03:31:07PM +0200, Juergen Gross wrote: > There is > > #define nop() asm volatile ("nop") > > in arch/x86/include/asm/special_insns.h already. Then call it "nop_func" or so. > It might not be needed now, but are you sure we won't need it in future? No, I'm not. What I'm sure of is: stuff should be added to the kernel only when really needed. Not in the expectation that it might potentially be needed at some point. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette