Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2603224rda; Wed, 25 Oct 2023 07:27:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE90X5/bfjdLGSZsMBBmbwLFMoFtd5kqGeAXhMWVnT1gYWHC+J3DNj59mig8FXRTDIr4b06 X-Received: by 2002:a81:4f92:0:b0:5a8:1812:a7ed with SMTP id d140-20020a814f92000000b005a81812a7edmr16145097ywb.15.1698244025199; Wed, 25 Oct 2023 07:27:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698244025; cv=none; d=google.com; s=arc-20160816; b=skL5pumU4hs+izePDihGmXmd1+b5BSkUiN+2u9SMgX8/AFUqBiAFDiD5yhE5rfazlB QCR21iN1BzOKgAUoXLoP96IR0ZKl45937kS4vWQGUFE3kUny/EBoT5QFw3bY1zhwtcdk nQSZ5klVl4YuZS5sKRU24Ifd5R+uhj3o1Bx9KhjQ46cz+9ATNMExs5cHTgOdL/TdqwJI HZ7GgDCVR1nAmS5KFs5DnCI1yB6DNpq9CZWpmitW49hc6k8LD1YwIQEiPGkl5vin+oSF 3pMb+0MDGQWNwutDqr4TB5Ej8MK7AFFfSYRF4OxGz8OV8O0X2WaNbwngXgvSxT7iseIl hOeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=eMGX5Z6Wb5FCBxvcVbzY1MCs8mEW8TMZB6RxH0+0Clg=; fh=HTcH9FwWfokSIxcREMnaC56gnwz2mltpvLaBMofE/C4=; b=y1dp5zmS1ycnfpW93dTN1ghYWMIEoVwk6wk3afEiaoScj/ceHziRRhB84FbWMFYd3B 4W4/WQnxXdGhrPqKWJDCGfjKYnuMhxF3iQ5wspVAZjB5FUZm91n+eeHub/LxqK94V454 a0L81hRqHL/boPHrQZg69aLgcXgismoC0kau3NJT4X2FZNjWrB6soByhXU2Tot3R5wNr 53E6sShk/PS7zc5mDzY1rIeOll9PHa2A0F1hBr2mMAgZ/1TENB5KatWnUiZIISdbSIZm Dfw3Lzsl8weWfNXnBCFCnOcnnKSMBnkzO1GOLUl09xwV4RMsRkUb+0hT2PDq7Op1Rbu0 Xn2w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=harvard.edu Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id c7-20020a0df307000000b0059f74697e58si11200470ywf.233.2023.10.25.07.26.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 07:27:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=harvard.edu Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 904C681167B9; Wed, 25 Oct 2023 07:25:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345001AbjJYOZq (ORCPT + 99 others); Wed, 25 Oct 2023 10:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344982AbjJYOZh (ORCPT ); Wed, 25 Oct 2023 10:25:37 -0400 Received: from netrider.rowland.org (netrider.rowland.org [192.131.102.5]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 799D818A for ; Wed, 25 Oct 2023 07:25:29 -0700 (PDT) Received: (qmail 495360 invoked by uid 1000); 25 Oct 2023 10:25:28 -0400 Date: Wed, 25 Oct 2023 10:25:28 -0400 From: Alan Stern To: "Li, Meng" Cc: "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "usb-storage@lists.one-eyed-alien.net" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] usb: storage: add shutdown function for usb storage driver Message-ID: References: <20231023054111.2744872-1-Meng.Li@windriver.com> <33bd0779-bfe7-4c87-8fe6-ea8455df3b6b@rowland.harvard.edu> <3fe5b43c-a5aa-4c6a-8614-03a4d9dd53e2@rowland.harvard.edu> <2023102428-zit-quickness-9b73@gregkh> <5107f6ca-e972-4af1-a21d-6c95778969f3@rowland.harvard.edu> <2023102459-protector-frequency-1033@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 07:25:57 -0700 (PDT) On Wed, Oct 25, 2023 at 02:25:17AM +0000, Li, Meng wrote: > In fact, the reported error is not critical one. In my real work environment, there is not the error because there is not PCIe-TO-USB card installed on board. > The issue is reported to me from our tester who used the PCIe-TO-USB card to test the PCIe feature, not test USB feature. > I am ok to NAK this patch. The primary intention of sending this patch is to raise up the discussion about whether shutdown function should be added for usb mass storage driver, and I have got what I want. All right, then we will consider the issue closed. Thanks. Alan Stern