Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2652825rda; Wed, 25 Oct 2023 08:39:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH+jOdLQcymUATEGBPgx/BQRNNqMSnAjz95eM6Pz+gadVMC5LSfWW9ivwCtTPwb/tPtRSsv X-Received: by 2002:a81:6d07:0:b0:5ae:15bb:466a with SMTP id i7-20020a816d07000000b005ae15bb466amr3442292ywc.14.1698248349295; Wed, 25 Oct 2023 08:39:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698248349; cv=none; d=google.com; s=arc-20160816; b=xJurZhOypYhQwMl5bfS/6X8JcYrfA8PSjVxWVTDF8XUkm+8GaLRAjAC1kXEr0je6+m pvY4I/BQOiXJfzTTTG1etTF3Vh5wrtuoHqc0XvlRHNdb+tzsWJPirdaiLzcXMzqRdtKH ZKXpJhnVlwouHERIDH1WQQSLjColQdl4hjInv/Ie9AXfixjdl3b/xHfnzszrZ/F+Peef 9JalsIrmzvtwvSgvIoZCMEK3Djw4vrEArEM7W4aZPtlgp0GYsbxcgT7XYBfk5MA8lUFr hQRIIY4RdOZEIufhHmb0BGfxONNw+Nj8rvmZALiL256xSHZLbhv2E7gYKUV6i0Qklqg1 eDuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :feedback-id:references:in-reply-to:message-id:subject:cc:from:to :date:dkim-signature; bh=s3OSHMGsk9AbX3O1+PeWpTjfY8iogU36oS0MMtzUkOM=; fh=dF7W+obL36DhqdnzbuuR9ffzEbE/yk6B1NJtg7atROM=; b=LGdRstMP78p9cKRnqMFsSn+r1NJ4R8qJ770nnrSnx6TDFPBafwKiF57k0HCciq3eGd SpiaDomYLKFPxWJjn6rVYjTvGeuFScwE6kMz6yAvhzWIy89d/5gjXBkTuuy+BEfZ1ZO5 PHU+9g8Y4E2Xl5s+oYL5WVJSjxO8JHXbEsWXvFKemx5oCWjiN8ROlCaCE/3M6bAaNrZO btvVaPhrejwl1dVnZr7p4QYPFg8HDLMapelg54lR/wYMNyCBbeaOtkJTpRg8cmnuHn9Z QroKlriAtgatiYV6F+IWIg7k6vZZgualsyoImL7WFXVIxI0wzSOY9lTOxF4LnlJBEfkm /1oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=HEtXXiSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id i62-20020a0ddf41000000b0059ea7117b43si9937661ywe.317.2023.10.25.08.38.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 08:39:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@emersion.fr header.s=protonmail2 header.b=HEtXXiSu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=emersion.fr Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id F2FE78029496; Wed, 25 Oct 2023 08:38:43 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbjJYPii (ORCPT + 99 others); Wed, 25 Oct 2023 11:38:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40006 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232621AbjJYPig (ORCPT ); Wed, 25 Oct 2023 11:38:36 -0400 Received: from mail-4323.proton.ch (mail-4323.proton.ch [185.70.43.23]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A100A136; Wed, 25 Oct 2023 08:38:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=emersion.fr; s=protonmail2; t=1698248310; x=1698507510; bh=s3OSHMGsk9AbX3O1+PeWpTjfY8iogU36oS0MMtzUkOM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=HEtXXiSuOfPyu+UaMN6/UV6yrkpJKijbGZmGy3nURSVNze4dfy2e3RthAItSDlvwg 4h90fPnJKu12fpPltCZKYZfw5bIINOVaXM4qBkH7mwBxzUJ4Ncjlvgfg+EQGBoBUNj GWr1x3gL0K3kZ0qd+jB+GIXt833zMOEnT0aiCVjZkVHUjNvTW2Oo9CHyZT0sjsc1eL 637VWZ8aIGINmiLfyCcHYWgDQaupiBrfRLAv0aRQuHpLERitwggQH1WtF5xJC4ndzr KFO4FuWJKWiWC2iFhXN9NyPrQct6vv3sJEOZ76zIxNofGuckAkOk0SmdEcP+cfdY8s 9YnsG/jJRnKYg== Date: Wed, 25 Oct 2023 15:38:10 +0000 To: Keith Zhao From: Simon Ser Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org, Krzysztof Kozlowski , Sumit Semwal , Emil Renner Berthing , Shengyang Chen , Conor Dooley , Albert Ou , Thomas Zimmermann , Maxime Ripard , Jagan Teki , Rob Herring , Chris Morgan , Paul Walmsley , Bjorn Andersson , Changhuang Liang , Jack Zhu , Palmer Dabbelt , Shawn Guo , christian.koenig@amd.com Subject: Re: [PATCH v2 3/6] drm/fourcc: Add drm/vs tiled modifiers Message-ID: In-Reply-To: <20231025103957.3776-4-keith.zhao@starfivetech.com> References: <20231025103957.3776-1-keith.zhao@starfivetech.com> <20231025103957.3776-4-keith.zhao@starfivetech.com> Feedback-ID: 1358184:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 08:38:44 -0700 (PDT) Would be good to have an overview comment to explain how bits in the modifier are used and how everything is tied up together, e.g. what the type and tile mode mean. Also some docs for DRM_FORMAT_MOD_VERISILICON_TYPE= _NORMAL would be nice. (If there is no other type, this can be removed, the bits will be left as zero and can be extended later if needed.)