Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <74a372a8-6908-4f9f-a79d-febeb6136379@amd.com>
Date:   Wed, 25 Oct 2023 11:01:22 -0500
User-Agent: Mozilla Thunderbird
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: mba_MBps: Fall back to total b/w if local
 b/w unavailable
To:     "Luck, Tony" <tony.luck@intel.com>, "Moger, Babu" <bmoger@amd.com>,
        "Yu, Fenghua" <fenghua.yu@intel.com>,
        "Chatre, Reinette" <reinette.chatre@intel.com>,
        Peter Newman <peternewman@google.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>,
        "x86@kernel.org" <x86@kernel.org>
Cc:     Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
        "patches@lists.linux.dev" <patches@lists.linux.dev>
References: <20231024181600.8270-1-tony.luck@intel.com>
 <2504daf3-16fa-9474-e9c5-cd6aa99d4776@amd.com>
 <SJ1PR11MB60838985036B7A3F2296448FFCDFA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Language: en-US
From:   "Moger, Babu" <babu.moger@amd.com>
In-Reply-To: <SJ1PR11MB60838985036B7A3F2296448FFCDFA@SJ1PR11MB6083.namprd11.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bzJBcTIrWDBBdkZiUml3NUhLTTFqSmVFOUNQb3pUVTArU1liVnZhd1p3b0s4?=
 =?utf-8?B?S2FPM3ppVTAvM2FDNnlJeHJQbWJ1UlFYSWoxTlVlQUNpSEw4bEtkeUF3aHFq?=
 =?utf-8?B?eXlBa3FhK09wQStVdjRRUUlDMngrZE53R2xFQmJieFZDYUpVQUpmMGJKSFVM?=
 =?utf-8?B?OXhwNkRjclN1V1p6ckFDQmpGYXMrNUZHTjZxaWpMU3FDR2VFN2dOS0tyUDFw?=
 =?utf-8?B?Z29IdWZVSUpjM09DN1FLdHRIcS8vTlg2dnNxRU9mMGF0T2VnWFB3cGZHQnpZ?=
 =?utf-8?B?NU5xTGRteDJYU0hiQVd4QldhaWhQL2g5czdrVUFERCtOdm40dTJVZ2lzL2x6?=
 =?utf-8?B?RjBOTFRjMWVPV21RZlliOExyalgxbFJqNWF4ekVmanFYWC9xMFZibFJ0MCtE?=
 =?utf-8?B?ckxGckhJRGU4QmFvaVpGaXp0dERNbTlGS0UrejFYbXdGNituNmF6NXgwZktj?=
 =?utf-8?B?dHhTRHh1c1Z1Si9mZ2tTaXQwK0E3cWVjbXhpOWx2TUFCN3hwNGZKdXltdDBi?=
 =?utf-8?B?UGp1YnJLb2k1OGNQYlZnTm1TZFR5a1pvUjJrdzMyWlc5MU5LUlVBaG5hSjFm?=
 =?utf-8?B?bFhzRXVZVm93d0pRL1Y4ejZXUFcrYktHZTEvSlRDT1lGVVBDSmZveFkvRU1B?=
 =?utf-8?B?eW1zcHR5R1dIR01oMkZqc1UwcVJZMVBvRCs5cWtSbEFhekd1eTE0ZmZXdHZZ?=
 =?utf-8?B?QjEwRFF4TUU1MXZuVmtqajUyZmkxcHp0R2xmeFVSMVlVWWs1MGdOWTh5NVkx?=
 =?utf-8?B?ZFJMR09vMllTcmkwZHdQRFVDRUVmSHlKQWx6S2p6V0tqWmRBelZ4c1Q4SWJv?=
 =?utf-8?B?TXUwckhmc0F3Rzl6TUd2RGROcnFJZHFNZHJTaUtxZWxGZnBncUJ1cUE0TnBC?=
 =?utf-8?B?VGljbFFFZFZxdFZJYUFCT3VqdWVpRFYyQWVEMWN6Smd5RjFZMlc5RlhjUHd0?=
 =?utf-8?B?Sm5oSkYvWE1VaDA5VlBmSGhjYnRXY0twWXJOYXRXV29NeUNlZ3ovRkZmS1FO?=
 =?utf-8?B?dzJWV1NtSWt6SkpaNTcwNHZraHUwdGs3TDZ6WUZrV2xCeVc2cXhKT3VsV0g4?=
 =?utf-8?B?YlQ3alVvT0c2TjFpQzBzTWxGdDZsNjlML2pLdFp5a2dEK3NRVFRmQkl1UVJE?=
 =?utf-8?B?ZHNoY0JnbFhJQWI1Nm9CUEdwQU9DWk5mNGF2VmZFYlZvSjB2ajNhWDZCWTJw?=
 =?utf-8?B?M3hEMlB1MzYrZ1lhNXpBcGNRYUdkMTRQcDlnVmg4aWgySVp2TnhZM1ExTFdQ?=
 =?utf-8?B?ZUxDdStzQkpGQTNNS0tiYjZrSGFwRExxWUZGNG5nTHR1Q2N2QWx5c2JjMWh0?=
 =?utf-8?B?dk9mbGFFVHUreHlyZmlRZVZNUkZaenVIZFFSbGtZbU1hMGJtRHN0ZUVlTTVO?=
 =?utf-8?B?T1hvQ3NaM1Rkc2pnS0Jma2Npc2p6NXM2ZGI1c0hXVXA3YnkwVE9VTmZNUWxn?=
 =?utf-8?B?cEk0MXlXWjRPRndHRzBBRzVpaitYZ0hCOEdDWEZlU0IreVRHN2JYR0psWlUx?=
 =?utf-8?B?akNTZGhaRXdDdEs5Nk1LVVBhbm9OOXlzRlU1bFp5VGthVDBnajhibXNQUjI4?=
 =?utf-8?B?K0xJalNTaVpXVmVZc1lGenRzL29xcFBMUW1XbG11aXVoNlFJN29LZmFZeit6?=
 =?utf-8?B?VVNUNDZJMnd5N2E1L2xKU2RwcUxVMHZONVdQUEZpczVvQ29pZHdEdWVIeDZM?=
 =?utf-8?B?U1NXRVYzTWhpQTJRRVVTa1N1YUMxQkVhTERZMEpPd05CeHZBdFJ0bjgxUnp3?=
 =?utf-8?B?MWJXWWhCM1ZaN2xzUXBvSEVzZU9PTUFLZlRkREM2bHNRK0NwUWowckxKOWla?=
 =?utf-8?B?N1BhcVd4K0VLV09ndXJXdysvaWFseldRNTZvdkQ4VVV0eElrYzFCNzhrQXRK?=
 =?utf-8?B?eEZBZ01kQm5ITlRHU1hRZDFpNVFoSVRnRGxieHJubDFNZGRlNkFvdEE2UlRO?=
 =?utf-8?B?N0FtNFRycWZjck9xd1cyWnZaQ29ncWJkR2tCWTJnNUdDejZZK21nV1d6Rmd5?=
 =?utf-8?B?ZFBEOGRlZDhkbnAxOE5JV001enkyMWVHTjJXNmdwRHVzcGVIMWF4Y0NoejNq?=
 =?utf-8?B?bjRXenZlUGJyclRxekhxQTN2TVN0MzF3NEtkMkNwMS9TN2ZHR05iTTZGZFJO?=
 =?utf-8?Q?i+t0=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9c03b596-1264-4d3d-6937-08dbd573a400
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 16:01:25.4018
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /kdkCeFpyI/fVAwCayNOa+cYXVqlUhn2NgIY1mJ4SgHUJNMQLqtYldtJC2czIqun
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6329
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 09:01:42 -0700 (PDT)

Hi Tony,

On 10/24/23 18:43, Luck, Tony wrote:
>> Is this customer requirement ?
> 
> Any customer using the mba_MBps feedback mount option will need this
> on platforms that don't support local bandwidth measurement.
> 
>> What do you mean by " If local bandwidth measurement is not available" ?
>> Is the hardware supports only total bandwidth and not local?
> 
> There's going to be an Intel CPU that will only provide "total" bandwidth.

ok.

Why dont you use get_mbm_state which is already available instead of
writing another function(get_mbm_data).

You can pass evtid, rmid, domain information. Decide the evtid based on
what is available. I think that will make code simpler.

> 
> The CPUID enumeration in (CPUID.(EAX=0FH, ECX=1H) ).EDX{2}
> will be "0" indicating that the local mbm monitor event is not supported.
> 
>> It can get real ugly if we try to handle one special case.
> 
> Hard to predict the future (I didn't see this coming, or I'd have had Vikas
> implement the fallback in the original mba_MBps code). But I don't believe
> this will be a one-off special case.
> 
> I'm also wondering why this feedback loop picked "local" rather than "total".
> I dug into the e-mail archives, and I don't see any discussion. There's just
> an RFC series, and then the v2 series was applied with a few small suggestions
> from Thomas to make things cleaner..

May be MSR write which feedback loop does only has local effect. This will
be interesting to know.
-- 
Thanks
Babu Moger