Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2673259rda; Wed, 25 Oct 2023 09:08:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHZAR/Sc3Vk/UbyjhNPXRGJ+yRYw7VlltMwk3oiJiyCZ/P7hg2huea43lj8oKjW+x+kLFEf X-Received: by 2002:a0d:cb8e:0:b0:5a7:c935:6cf with SMTP id n136-20020a0dcb8e000000b005a7c93506cfmr16391513ywd.24.1698250132805; Wed, 25 Oct 2023 09:08:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698250132; cv=none; d=google.com; s=arc-20160816; b=Y00wA2pSi1A65nk6D354SOevisZAcqfg3R2No0appHRevzYeiVMF4HUBDn/zuQ54cR J7jiGaoiMFWQ2s0Ck/UQsHY8Ee6ePcnWgapdylx7KI9P98SXpGipDsQn7HaPWJZrFarv 510KoT0reWFu4wPt0ZQtMkvE5a3FISfUtTbKQhcnZfRPqHR2ZKtuI9v+bc88EsIYre7B nR0RotAQXE0RF0FRjQS5lbvDxBnd7515xgMV3XqU34HIwYjZD/uxgab5v2mHzyt0ddDC 61GfqdE6z7niUneD6mZlRqyCKL3Rzj5kP1frLUZbi+IrieBYgwmdRFuy301aAWF2ztuW JJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=B1VoeUERc8uTBVmmS0AdhLCA2FbYQT4rr/Fv+tmZhTs=; fh=btVIbZbPMmeKRfMrW/zQ5YImjpaTzmCxbiMFvSebZOk=; b=EVOkZAIAVf83xqPjdRv1Mp1Rr++oTgAyjcFehCFW62/B85WJfmMiAHx3pqNFFfJWMG 0H5iTWou6RTuaz6/vxUnD9sBYu3bvgJHTUQYQ9exKjSb32gnx+YFUh3Vi2ai4XG4iTys 2e9XEUjT8cnZhBzfFhy7wJPMGAGIrFyxaBl5Uf6tqsA1t+BrA0z26wOsOArZ4KvyJAlR cK078fJ19e3f0wcgJsB1OacZzia2OnLv80F+XaP41FmYrjAebFCYAGTiznE4dK9UD46z ssMPHt1n3Zt9llmuMrnKu6ju4uUjT79/53GDpQpCuaUdQgpcnPcdJvoLGcbaaldty6hF d4iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hhe4jh7N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from howler.vger.email (howler.vger.email. [23.128.96.34]) by mx.google.com with ESMTPS id q129-20020a0de787000000b0059eae2bc317si11731488ywe.217.2023.10.25.09.08.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 09:08:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Hhe4jh7N; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id 0A1FE80756D6; Wed, 25 Oct 2023 09:08:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343542AbjJYQIj (ORCPT + 99 others); Wed, 25 Oct 2023 12:08:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233249AbjJYQI2 (ORCPT ); Wed, 25 Oct 2023 12:08:28 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 843D7B8 for ; Wed, 25 Oct 2023 09:08:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E0623C433C7; Wed, 25 Oct 2023 16:08:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698250106; bh=qujSkRF7+AONGoOyzL5iEs4HyhHB1A7/KwcVxpI/2zg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Hhe4jh7N3pSu+gEqdcyo7MNZVayhegtdhvTp999RtA/HrfW08chTo4Jn4dOi2LsGE V6BeYiJ12107KrejTtMO4sqS+Ggb+/Mv3Cqs2bKxy4JUDJ7/RHXr1xFsMKHd+cuOKN JEbdfCMnY+ipAb6YmSB9DIA+5NTYXYE4ho6tXpX4wRm2LaoUqCdBrX8SuyMmWslUqV cM2NX5WohOLtXxOVHn4uOrbHOl/zIUasH2D1G4libVed1KbRiFdRv7Wkr5BlTfTjLg cpGWVBwkPc/NczjX/MQ+xHLReVfTXxZeib+Klzj1PqYBrnrIqs9ob7sKG2pzZaqOti 2nva9RTu3q+qg== Date: Wed, 25 Oct 2023 17:08:18 +0100 From: Simon Horman To: Ivan Vecera Cc: netdev@vger.kernel.org, Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jeff Kirsher , Catherine Sullivan , Anjali Singhai Jain , "moderated list:INTEL ETHERNET DRIVERS" , open list Subject: Re: [PATCH net] i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR Message-ID: <20231025160818.GJ57304@kernel.org> References: <20231019135342.1209152-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231019135342.1209152-1-ivecera@redhat.com> X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 09:08:45 -0700 (PDT) On Thu, Oct 19, 2023 at 03:53:42PM +0200, Ivan Vecera wrote: > The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one. > > Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722") > Signed-off-by: Ivan Vecera Thanks, I agree that I40E_TXR_FLAGS_WB_ON_ITR is consistently used as a i40e_ring flag, other than the case that is corrected by this patch. I also agree that the problem was introduced by the cited commit. Reviewed-by: Simon Horman