Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Date:   Wed, 25 Oct 2023 12:28:03 -0400
From:   "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To:     Peng Zhang <zhangpeng.00@bytedance.com>
Cc:     Matthew Wilcox <willy@infradead.org>, corbet@lwn.net,
        akpm@linux-foundation.org, brauner@kernel.org, surenb@google.com,
        michael.christie@oracle.com, mjguzik@gmail.com,
        mathieu.desnoyers@efficios.com, npiggin@gmail.com,
        peterz@infradead.org, oliver.sang@intel.com, mst@redhat.com,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v6 03/10] maple_tree: Introduce interfaces __mt_dup() and
 mtree_dup()
Message-ID: <20231025162803.i66jc6u2hzfackfp@revolver>
Mail-Followup-To: "Liam R. Howlett" <Liam.Howlett@Oracle.com>,
        Peng Zhang <zhangpeng.00@bytedance.com>,
        Matthew Wilcox <willy@infradead.org>, corbet@lwn.net,
        akpm@linux-foundation.org, brauner@kernel.org, surenb@google.com,
        michael.christie@oracle.com, mjguzik@gmail.com,
        mathieu.desnoyers@efficios.com, npiggin@gmail.com,
        peterz@infradead.org, oliver.sang@intel.com, mst@redhat.com,
        maple-tree@lists.infradead.org, linux-mm@kvack.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <20231024083258.65750-1-zhangpeng.00@bytedance.com>
 <20231024083258.65750-4-zhangpeng.00@bytedance.com>
 <ZTfw1nw15wijNnCB@casper.infradead.org>
 <bf7d4005-d32c-42d9-a748-a7c421130be6@bytedance.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <bf7d4005-d32c-42d9-a748-a7c421130be6@bytedance.com>
User-Agent: NeoMutt/20220429
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHBWMlJvNENISDUrbWR3VHpRS1F6WE9CSnFCMDA5YVdMV3I1d2JmeWJqRWto?=
 =?utf-8?B?VkpkYklQeWRJL2V0dStJdElTV2hMYXhOSWFOcGdHWnlWZ0VEWGJHRERsNENQ?=
 =?utf-8?B?enRFekpZcnU0V1ExcjJ5Uklkdk1pTmxuQURONzZHNXJZT1FXR1ptTzAwODVB?=
 =?utf-8?B?K21ZeVlhTXNKWVFZMURIckh3NkZqelJJTHlBRFVBZ1dCTmtYYk9sekpuNnlV?=
 =?utf-8?B?d1c0MndyRWQ5djkrT1Znd2RkS1diUnRNekdKcjl1MnBBOTVOYXdrK0R3Uy83?=
 =?utf-8?B?NFRyeTc3UDBnWWJEQ0MwMWlFcEUwSXhyUTRvc3VGbnQvMzZxRlR0T3ltSHN6?=
 =?utf-8?B?UVhBaHk3aFRsZWk2d08xS3dHdWRFV3RFZ0F3RHJxNEhFWVJjZk9mcVNnOVlJ?=
 =?utf-8?B?MHRzakdUK2ZMbnFKaUprTFFWL1QzbkpXZmRGRlRHQklnUElkWkFSTWFIcGta?=
 =?utf-8?B?OEZEdmpzTGpINUt5bVMwc3c1ajUwSlA0NWNFVE9HWDg2STFWWWJEY2R4cFBS?=
 =?utf-8?B?L055WXlOc3FXRWdIQm5PWFpVY1Ntby92Z01Hb1hXOG42emhBdUpwTm52SWJ6?=
 =?utf-8?B?N2QyQjFFOURQK3N2U0VmWmJlSTA0WXZYcXoyVFE3SGJPRWdwdWZ4U21DTUxm?=
 =?utf-8?B?djI3d2xYK2hJa3ZsVDZVZE5ucUhnYXYxcGRMc09pL0FXWklKblRTeEtITk40?=
 =?utf-8?B?YnlndDMxc0FOTGpvNmNvbWpGdmh2eFpaVGtmYURYMS92VEJoU2phV2FaTmZr?=
 =?utf-8?B?MVFXT002bU5yd01QUk5Kak5ObnlOMFFLcmcrb0NRZ3hvTnNHL0VjNlhLUmlp?=
 =?utf-8?B?WitlcUhIQ0xhek5JYjhLYmRMSnNTd1dvaEtnTnMvZUx2dWl2YkNncXNsVkVu?=
 =?utf-8?B?NEgvV09EUnpacDA0bkhnTlkxV3ZTMDFJVkdiUlRwRFpMa2VOZ2p0UDJrYWFt?=
 =?utf-8?B?TW9tdmEvcm5tNHBmNTZkaGhKb3ZQVUtsMlRlVEYzc2JiNDVCRmxWWUZTY1Fy?=
 =?utf-8?B?YWxXUW02MU1wc3BDK1JSaGdtc25tK1dZak40V3daZEJnRGNQTDBubW1RTmlV?=
 =?utf-8?B?d0lpaFBFbFZUK25zL205ZTcvZ1p0L3Q4TUdUaUhYUFFTb0dXRDVWYWJIMEUz?=
 =?utf-8?B?ZlFmeE1UeHVpekp3Y1BqMzF4Nm9YRWpiczlkcnFTdC9Yenl5N25Mbzd4Z1pa?=
 =?utf-8?B?OCtMQnNncWlQRUxWSGxZZWhqT2lySys2YzhiK3BLUVZoNUhhTE9wdWh6VTZJ?=
 =?utf-8?B?NG80OEtkL1EwUDU4TGdacG5yOVYweTY5by9uSVNzdk5DSDNkZUZPejJqckpn?=
 =?utf-8?B?azZwY1pzN2pLZUVBSDZHSTFtUXp0ZUUvcEoyWGlhYkVEaVgyd04zenZjWWdN?=
 =?utf-8?B?dG5FZGxUci9sZU1ZSmF4a2dqWFBsSEJzZUdiSDU1Uk5ZRUpDcENaRHpqNDZP?=
 =?utf-8?B?Z2tYdzNjaUtUR1VFa0NSYlF3R3VjdlVodXJHVWNWajVtSXJ6am5wc3E2NnM0?=
 =?utf-8?B?T1d4bHoyd2dLbFdoVFdkbm1ncDRLM2w3dFp0NXJOWEVWdG5IT1VCWklqN29M?=
 =?utf-8?B?cUtGck9kbDIzY1ZGQ2RKU3cwTWt5bGZaNER2L09MbzYzNWkwT0lwejRNbi9v?=
 =?utf-8?B?TTZwQnhwS2VmUm5yYmpVY1VMalY2M2dzb25yaWtDTXNiejlvQ0R0OUtneUx3?=
 =?utf-8?B?Z3JaZE1lTDM5YTVTcEVQSzhZVUhEeFZyK3pBRG14c29aSjdWVVpOQWhrb2Zz?=
 =?utf-8?B?ZDVzWS9FY2xVT09tTGtGWGFDMnlHUHFOT1hjc0w1eHVyNE5MNUtFcHR1aDd4?=
 =?utf-8?B?bzZ1cklPdzE2VjM5NTBaaGRqeDlWc0NKbkY5dkpMUHRJVkJkVkUzRDVoZHhU?=
 =?utf-8?B?Y05DTWxHQy9ZUmxxRS94eGU1aEJiWlpBSkQ2NnNrVERoUUp2cmNxZkFwK0E1?=
 =?utf-8?B?cmZSREpmaUpRZm43cHNZK0F6MXVQL1doa2xwV1V5RHdCVlRGSmNkazZGd2Ix?=
 =?utf-8?B?MFl2WGxSdEk0MEpZMEN4ZUpOY2tsa2JyZWltSjdyQ2Y2Qk11bW44NjFOdnlu?=
 =?utf-8?B?dkhqWHdPQVNFR1FvK0lVMGI1WHdzVFN0VEtLdVp4SnkxUXZkRzU2cjhqUlgw?=
 =?utf-8?Q?ly2phmz/bTgy9WgiI78z9gDUF?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?b0JRL2xVVi94bmYxYUcwZjZvanRoNTZZcWIrMkUzY2tJSVMzVVFsdmVWaHJo?=
 =?utf-8?B?bkFGVEVWc3dLUFcvV20vRzYvOUxXaWdqNzlrWU1xdFlwWVhla1QxcDZvYVda?=
 =?utf-8?B?TVVkU3lsajFUb0QrRmZsQUhaMWlxcGpGQ002cXVuWkF2VG5SV05xejBpT24x?=
 =?utf-8?B?WmlYRUk1SUkzcE0zYWdxa1FTczNJSHEzZ1RmL01FV3JWdnIwTGpvZ1dHSkJL?=
 =?utf-8?B?akdhTkxPeThJWVRUeWhDSFlxcUZoZzloQ1VnN2s4eVRhMWZTeWtZWnZmdGhl?=
 =?utf-8?B?ZXBmaVZZRFI0VjF0WmJqZ29pYmxrTlJWRUdEbmFFa1UyWko2cG5LWFgrOEls?=
 =?utf-8?B?STUyaUtHL1VsaWIwSVBoem5McFdTYWs1VVJtYWExa2o1TE5ScjFsZnd5M2ph?=
 =?utf-8?B?M2ZRaVFNeDFJSUVBWHRna2N5Y25YVDJhTnVpNEorUXhzTUpsMUJRUXVxSm5t?=
 =?utf-8?B?MHVQeGRTWkxSQnJpeHpWM1EzT3NJR0lYamFNTEQ5UHJjMHdtMU9NVXlKN01R?=
 =?utf-8?B?TFhrMGorT1lSNnM5STFTdnBMMEErVy9YQWRiZndEZlRwSVhyNDBMUDAydCt0?=
 =?utf-8?B?SHpTVjFLMVY5OVQ4K3d1VDQxa2JxOGcxZ0FIbmNWTFVHbTJ1elk5QVJrODhT?=
 =?utf-8?B?YjdhRWk1YWEzU1pUc3BublBEU0NRNWhoMjFLa1JhZHQyVnRJYnJXcUZMNCtG?=
 =?utf-8?B?cmljSGN0TWl4WHFQdFAxQW1xbkJrditLZjMzVXlDRmRyVnFlV3h5OHRCR0tX?=
 =?utf-8?B?VEdIdVRVNjg1MWtVV2tSa2UrK3Ezelhhc1UrelpSelBMa1Qra0cwNTNFZXoy?=
 =?utf-8?B?aFBpRExJRGlGT0tWR1I2Q3RFaXhtRFRCdnNURktRcmlDZ2JHL2ZnMmRwcDJj?=
 =?utf-8?B?WStHQ3FrRVpDSVlRSlFmd2hRaEdJUnBvMUFCNkJPa0J0MllWbUtCQmFWVHVs?=
 =?utf-8?B?MDYyVFZLSzBjZkVQQmlHMVFUbDN6TGZyUFFRc3FHd29pckxjZlRhQlRsZDZJ?=
 =?utf-8?B?R2I1WG1yMUhrMTlhS2hBVTRhQVBGeWMxWUdXeURrTWcyT3Z6WUVoTGVWb012?=
 =?utf-8?B?eFZMeUg2dEM2V1BDOXJoQlQyalNQb09RK2ZTUm5hK0ZRTkVodFpGckNQNWRS?=
 =?utf-8?B?MGg4Z05LVFM5VnBtUmgydzVrSS9ZbU5sYm8yN1dObWtrT0N1M3NaazBZT2JT?=
 =?utf-8?B?WlpkNzRaRDI0aUx5TFBGUDRsUkdQTU5HOWtWK1dDZkhHakFhNWVMd3FCZDla?=
 =?utf-8?B?a3FVZUlTNEl5NzZ2VGozVUxlSlpUa3hndXZsUkJsR2ZWMFo3TzRpOUdkUnVR?=
 =?utf-8?B?c01BWXBSb1k3WkJWMWRsR0RXTWYyRENWS3ZqL2pQZmIzN21zQzlkcWxFTjhZ?=
 =?utf-8?B?QUQ4WXFPSXJhNDRpS0UrT3BNSTlQUWlSL2FCZzlqOHBuRDV3d0xkV2VaMEx4?=
 =?utf-8?B?T2F5b2xzMzB4dTNacERmeXQvN25BSmFZdWdKODlGUVRjdW5PL05VM296MmJu?=
 =?utf-8?B?by90MmNCSExnQmVKYmc2TXpXVmxadjZGQmlxTittY2M2QW9RVm9CUlExR25Y?=
 =?utf-8?Q?r1juq6RdSJFuw+ioHDXP+YFTY=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbe7a91d-02e2-4830-6331-08dbd5775e83
X-MS-Exchange-CrossTenant-AuthSource: SN6PR10MB3022.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 16:28:06.9432
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: fOFos7HjQFU/OA7s+BhOm9P91/DvC6q1vRR4shd4WbgJefS1MZX2rdGYI+JflpV/hZIfpauYGs/+83JXnBZEOw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR10MB4193
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-25_05,2023-10-25_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0 mlxscore=0
 suspectscore=0 spamscore=0 adultscore=0 mlxlogscore=992 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310170001
 definitions=main-2310250143
X-Proofpoint-GUID: AYKQFq4b7jR5aqUyfh_obqbUKEgsgnJj
X-Proofpoint-ORIG-GUID: AYKQFq4b7jR5aqUyfh_obqbUKEgsgnJj
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 25 Oct 2023 09:29:18 -0700 (PDT)

* Peng Zhang <zhangpeng.00@bytedance.com> [231025 05:20]:
>=20
>=20
> =E5=9C=A8 2023/10/25 00:29, Matthew Wilcox =E5=86=99=E9=81=93:
> > On Tue, Oct 24, 2023 at 04:32:51PM +0800, Peng Zhang wrote:
> > > +++ b/lib/maple_tree.c
> > > @@ -4,6 +4,10 @@
> > >    * Copyright (c) 2018-2022 Oracle Corporation
> > >    * Authors: Liam R. Howlett <Liam.Howlett@oracle.com>
> > >    *	    Matthew Wilcox <willy@infradead.org>
> > > + *
> > > + * Implementation of algorithm for duplicating Maple Tree
> >=20
> > I thought you agreed that line made no sense, and you were just going t=
o
> > drop it?  just add your copyright, right under ours.
> I'm sorry, I misunderstood your meaning last time. I will make
> corrections in the next version. Are you saying that only the
> following two lines are needed? This still needs to be confirmed
> with Liam.

I'm good with the two lines below being added.  Thanks for confirming.
I will try to look through the rest of the patches before the end of the
week.

> >=20
> > > + * Copyright (c) 2023 ByteDance
> > > + * Author: Peng Zhang <zhangpeng.00@bytedance.com>
> >=20