Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
From:   D Scott Phillips <scott@os.amperecomputing.com>
To:     Bjorn Helgaas <helgaas@kernel.org>
Cc:     linux-acpi@vger.kernel.org, linux-pci@vger.kernel.org,
        "Rafael J. Wysocki" <rafael@kernel.org>,
        linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
        Darren Hart <darren@os.amperecomputing.com>,
        patches@amperecomputing.com
Subject: Re: [PATCH v2 2/2] PCI: hotplug: Add extension driver for Ampere
 Altra hotplug LED control
In-Reply-To: <20231025172237.GA1754650@bhelgaas>
References: <20231025172237.GA1754650@bhelgaas>
Date:   Wed, 25 Oct 2023 10:41:46 -0700
Message-ID: <86ttqe4n1h.fsf@scott-ph-mail.amperecomputing.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sxsyKT4MzSrLTKUNgyziOBhuO4wpgg754SgJ2KOFsH3yllGdbwkr8p/97j08?=
 =?us-ascii?Q?icQU3+W1xt1x7FUEs5arsm2btGJP2JqTc7geXNCldWFrjP/zkY/boF0PpU50?=
 =?us-ascii?Q?PViWi5dmomB2L4n1zt2GL10Bv1CjTLSldXAWKvEaXYMYrHWicag4IrNuuyK9?=
 =?us-ascii?Q?9cM2O/zP1FPMghJRBmukrFumbS8kHkse/Ni77HCK4BgIyXvfFdBu2jceu5AM?=
 =?us-ascii?Q?gTGzCmd14gaHmvEazwD/dCYpkn5fv9O1cz7n62HSGmAvMCtBsDouF0nQWY1D?=
 =?us-ascii?Q?rb9syp6zrse5QwqsI3WHyEtXLLN1AfWHi6w0OIzOEusFQLHNT+j+EVgQq87p?=
 =?us-ascii?Q?Qmup4aOmmwFKq1OwQ2kiCcFXHHkY5yf/YBEgh+aaJUeloEljMLPQVDUnUQzt?=
 =?us-ascii?Q?dIqn4YoAm8RWd8izR85oIQE9LS3XiHdDq1XdybMAv6qvg39J/tq+NFKOVd+W?=
 =?us-ascii?Q?xHKq3GdQaDOTxrvTesMI4ULfpTnEUPfVMJ7crc/4eRh+9DcPKnR0G5PqbL8Q?=
 =?us-ascii?Q?vXIIzI2iCuZG1kMy1nAAP7GlflxhONvxHDjL4L0TVIBkfC9YuRDQNxO3bGbE?=
 =?us-ascii?Q?wX+N37qEJjdWX4jj7rWKECCUpbFhOk7DTeKIl+WDTk2u5EOVnVJ7rN3IYhFH?=
 =?us-ascii?Q?KvtFAVl6R0FGbVvoxRo6JSF3vQzepBQze2LD9OCeQfi+aCRK+QYn5nmyfrZB?=
 =?us-ascii?Q?qMWyMX/4sloivw9Usm2qum/KRmu3/S9PnQU3oc2sRmpq4TYkdxuRY0zPIwLJ?=
 =?us-ascii?Q?c3y4CtADV0zzqYmqw+Nt5gV0n+u4zmCyORoOZahX1m4D2NJ28k1dGPGY5K7m?=
 =?us-ascii?Q?hGxwBbWmvyfWZWJ3QVoZ1NtV2/2b0m6VDPvhwAi/FLivxSeMDybWjZH0AYC1?=
 =?us-ascii?Q?6gpTs72UTAElzMQsDgWvLyfTdHiGStvOJOfRto6zgVAN/P6xyV7+I4eBFVhW?=
 =?us-ascii?Q?Wi6n/emj2rS7uFaByMe2LMKtTE3z8ncedgk4pY3jIEpw+LyTH0KfCQsYa2G8?=
 =?us-ascii?Q?yTce3WEkHkaUywfAgxdtWQCLbRWy+cPJV4FWs/IeG4tEnC9YqFX/qgkqrgBC?=
 =?us-ascii?Q?lGmDxBqyh/0SQea9raMh+u9+62C3huQrLDX7K3Ks44fz2w3ncpo5pVe7FbUt?=
 =?us-ascii?Q?mOUdphLqFhkBQliPj0oVBOl3MwcsEnS4L7OcmxHnf2+Yp3QYze++l5ixKdNY?=
 =?us-ascii?Q?Cp+nyO/8aXGUFT28RcUzUCp8E25dVJ2u3DeWX8KD8rUWLZ7jCZ+S7hdFJXw2?=
 =?us-ascii?Q?pkFaNG3J5keuBsACsxKGuqCWxsVc89KyW8p1NljtfitkjeJdWuuDXrB64G62?=
 =?us-ascii?Q?AIeL6rq+ieIS+77gZLVt2Kjf2x7uwnJvxvHst3WfzLH4UHHDNg29KE+F4p1D?=
 =?us-ascii?Q?qEso2qEVapwrX39w0qSviW1Su33j2Ch78Qwuj3tMizfL0W79O1xj5/x5AQog?=
 =?us-ascii?Q?P1kCxLjHjPE4Rotqvevgxb69i0EAuuvcYd429YQIiDHGRpsnXiFTqkMJPCnZ?=
 =?us-ascii?Q?krk/71xR7VSRcSRGQP+7GcjHwkMPKQTRHaI6hILJo1GZn7a1zez+xJnWJs0K?=
 =?us-ascii?Q?w3974stHuOWgwtkbniczbifR1LQiGujcOOKUpUgLz8LlI1NTcXz6B5RA9ZBC?=
 =?us-ascii?Q?xQMmwkWmiTcO4ujjnTNCMus=3D?=
X-OriginatorOrg: os.amperecomputing.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e396ec66-e606-4139-0669-08dbd581a9d5
X-MS-Exchange-CrossTenant-AuthSource: MWHPR0101MB2893.prod.exchangelabs.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 17:41:48.3127
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: x5IxGWYTrBKUT+BSJfbG9M4qgku1E3phyz9L21fZBKCh3ijSdjU9/TFOWfLgSfFdAJLnQkJb3SemhBbfCPxvQXbMGEGowZvuYJcGlpefArHPKY+Ww/epgOn4oyPJ0ARY
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR01MB6280
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 10:42:18 -0700 (PDT)

Bjorn Helgaas <helgaas@kernel.org> writes:

> On Fri, Sep 29, 2023 at 05:20:36PM -0700, D Scott Phillips wrote:
>> On Ampere Altra, PCIe hotplug is handled through ACPI. A side interface is
>> also present to request system firmware control of attention LEDs. Add an
>> ACPI PCI Hotplug companion driver to support attention LED control.
>> ...
>
>> +	arm_smccc_smc(REQUEST, LED_CMD, led_status(status), LED_ATTENTION,
>> +		      pci_domain_nr(bus) | (PCI_SLOT(root_port->devfn) << 4), 0, 0,
>
> pci_domain_nr() returns "int" (normally 32 bits), but since this is an
> ACPI system, the domain comes from _SEG, which is defined to be 16
> bits (ACPI r6.5, sec 6.5.6).
>
> So it looks like ORing in the "slot << 4" clobbers the upper 12 bits
> of _SEG.
>
> Is this code doing the right thing?

Hi Bjorn,

on these Altra platforms _SEG is limited within 0-11. I can add an `&
0xf` to pci_domain_nr() to make it clear that the segment number is
encoded down into 4 bits in the smc request.