Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Message-ID: <022960b9-dfd1-4ed8-9b46-9cc11ba060e2@intel.com>
Date:   Wed, 25 Oct 2023 10:44:07 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 1/2] i40e: Remove VF MAC types
Content-Language: en-US
To:     Ivan Vecera <ivecera@redhat.com>,
        Wojciech Drewek <wojciech.drewek@intel.com>,
        <netdev@vger.kernel.org>
CC:     Jesse Brandeburg <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231025103315.1149589-1-ivecera@redhat.com>
 <20231025103315.1149589-2-ivecera@redhat.com>
 <8a8f54a8-1a18-4797-a592-b57bc6fc45c1@intel.com>
 <cbb2e9f4-03f8-4a46-99e4-e952bb754a2f@redhat.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <cbb2e9f4-03f8-4a46-99e4-e952bb754a2f@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NnMyL1NDTnAwTG1UUnFITE1SSHg0YzZTKzUzVzVDSHgzazFHVjlwd05JQmNj?=
 =?utf-8?B?djFGSVltQWtCZG1NTlNIdVdPbGxpRFMvYzJxaUgzUUxJVmc5MXZLOWdzVkVI?=
 =?utf-8?B?ajg2aWxvenV6dk1VZXNybi9BSGh0ZUVRclpzWmk0UzhFTG1zMmFiUXM3OTNV?=
 =?utf-8?B?M2svYjNWQ1FkZ0ZYM0VkLzBuWVNaWkVUY3plSjFmQzdLTHBGdW1zMmk0T3JU?=
 =?utf-8?B?ZWdWaXkvTFlZUmpGQ09NRzVsRWxLMGx0TmpjcGdwUkZPM2pQNVAvT3YxUGI4?=
 =?utf-8?B?NGJxcDQ0WDBSWW9PR0lEdlkxOEMybzNKS2dwU1Z2VVA0MHBsNi90VEIrVklT?=
 =?utf-8?B?dUVwSUc0eFVQTnBkZWZDUkZnYzZ1bHpFdmh2dVlmdWo2OFJoU0xJS1huaG1y?=
 =?utf-8?B?SU5RSi9YK1NXMnlrSTkzRzlGRzZmWEdrc2MxbTVPRnZ6WkltV2oydm0wMzMz?=
 =?utf-8?B?dnRKUmE2RkJoZGYzTDg5TDhjc2VxZ2YxaFFNY3VzQWVhRGlpT1lvYTlqdW1K?=
 =?utf-8?B?U3NFNHZjNEFCQzRwMGU2a3M5ZFJOSGRVMHpuZmFYSGNNa0ZZVTZYT1kxZEgv?=
 =?utf-8?B?MTlCZGJGREU5VmFBN0ErQnBDZFUzeThQb0d5SXYzZ2JNZzBpckgwcHN5dlNu?=
 =?utf-8?B?MXBlMHJESVFCbXVXbC9BU2xUdm1pbE45cTNENlNiVXRqUHRPc0xueEkyT1Fx?=
 =?utf-8?B?UCs2Y2RwTVdFUFNNNVc0TGVMbXVUQlRvelAzMW5DelNKbGU5V00vbVRrS1FU?=
 =?utf-8?B?ODZKUmZzY0FMNEpHV1NGQk1rdkdtMm8xbjd3ZkpkM0UzSUR1aTVKSGVoT2lZ?=
 =?utf-8?B?NTIyc3loN0d5K2NkVlRTNFZIOEJCVXIyR1pRaFFtZHdFZEQrQ3dzNEdpM3Qr?=
 =?utf-8?B?eTY2ckFiMkxlVkRseVVzZ3dxcDd2S1VuNndsN01rd0VtWXlrWkMrUWlJcExl?=
 =?utf-8?B?aC9oMGdSKzh4RnpsN3BoU0tLb0swRU44c1RKNWZ2a3JrUGZCcVNRK2lXdk1I?=
 =?utf-8?B?a3JnNGIxTmlwZzhSdHlYWlk4emJnOS9CTnYyRm5jYzhGQk9tL1FUU1RPd1pi?=
 =?utf-8?B?ZDVwVkNBTU9iSE0zVzhIWEQ3Mjc1bU1IRm9qeDMyRHIyOWc1WVZlQWpqY0lZ?=
 =?utf-8?B?RExSUUpNSm9kcXA4T0liUXBEeXQwVFFJRW8wT05ENDVhYThMUEo2ekIrK3NG?=
 =?utf-8?B?UEtEMU03M0Q2Y0ljcGZqR0hwVUw5djkxc2JITEFQOXFyMEk0eW1jNzI1R1lD?=
 =?utf-8?B?TkxUNllDM2dDWm9BUndmQ3VZKzV0cEpLOG13bnl2T3BwQ3QrK0J5WFpacWZh?=
 =?utf-8?B?ZS80OHNzdk13bkNxZ2VrTW9MWC9PZ3ZNTjl1eGVSNXdSKzhlRU53RlhtY1Ey?=
 =?utf-8?B?eUZiZ1A3TGgrOFNzZTJvWVZBSGswditWemV6anVueGhpV1krbVMvNTladW9l?=
 =?utf-8?B?NC9aVjZzY1BIVDAzQ0JPZ0x6REtlRi9qZnBVcEpYS2ZtYnZTSG1YeWdUNUkv?=
 =?utf-8?B?TVFVa0RTU2RRTjAvcDd5WVcwZHRzNWRGcVgyZzhmUXE1cEk5R29oY20zZTlr?=
 =?utf-8?B?YkI3K2RTYytvL0JGZStsMVYvejQ3NG5SZlk2Z2lyemNHZ1hVeDVnSU94VEpV?=
 =?utf-8?B?Q0pyUWo2T3RQVHN3Y21qYWd1dVpRczIxL0ZDZ0xyZGpjYTVLU0p4dzV1dkV2?=
 =?utf-8?B?VXNzQzMySTZDenNTWE9OMnlXb0RLc0d4dzd6Yk1qdS9kNmhqQlpGMCt6aHl1?=
 =?utf-8?B?RnZtMTFhTWsvckxmTVJUdmFFQkdEeGpYVWU2MWxqUllqcG1XV2dYenBwVXQr?=
 =?utf-8?B?R25kUXBLOHE3QUNRaCtFYUNORnowbThaYnc2dzVPdlBGOFhveDdZYlFCU0dr?=
 =?utf-8?B?ZmxRNmtCK21GL0pXWTlpWE1GRGJwZlpoekZjTGc1MGZNc2ZadWNzdVl0VThB?=
 =?utf-8?B?VG1qbkpWMWVXeUpWY2RHeFdyc2k5N0xBVnpBUDBsOXZKOFdCMkMwTVJ3STZ4?=
 =?utf-8?B?djlSQ1pYeXFZRlMvOEsya1EwYk1udzJyNFppRlFMYlZwK1ZHai9jNkI2VWNJ?=
 =?utf-8?B?djlidk1XUysvMVdTcDBibEljbkV2YWk1VEpKSGRXWlRseUI2MTZVTnUyNHlG?=
 =?utf-8?B?ckNTSzNPWlNwb3VlUy9jV0RUY2dsZXNPVWJrdGlJVzlJeGVmMDJVOHc1eDlM?=
 =?utf-8?B?YlE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0ca96753-b06b-47e7-39e4-08dbd581fd70
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 17:44:08.3665
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +3qxKq9e0wSevBC+k/kD6Mya/3WA2Z0uuIJHNxT88ZYJtgu+QhMGzG+Hw/IyfqXeufbgbKCc4GoSg+cVeQqhs8JAfJWkg1OHAhNV5d0B5QA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6038
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,
        RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 25 Oct 2023 10:44:22 -0700 (PDT)


On 10/25/2023 7:39 AM, Ivan Vecera wrote:
> 
> 
> On 25. 10. 23 12:48, Wojciech Drewek wrote:
>>
>> On 25.10.2023 12:33, Ivan Vecera wrote:
>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
>>> i40e_adminq_init_regs() and remove enums for these VF MAC types.
>>>
>>> Signed-off-by: Ivan Vecera<ivecera@redhat.com>
>>> ---
>>>   drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++++++-------------
>>>   drivers/net/ethernet/intel/i40e/i40e_type.h   |  8 -----
>>>   2 files changed, 10 insertions(+), 31 deletions(-)
>>>
>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>> index 29fc46abf690..896c43905309 100644
>>> --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>> @@ -17,29 +17,16 @@ static void i40e_resume_aq(struct i40e_hw *hw);
>>>   static void i40e_adminq_init_regs(struct i40e_hw *hw)
>>>   {
>>>   	/* set head and tail registers in our local struct */
>>> -	if (i40e_is_vf(hw)) {
>>> -		hw->aq.asq.tail = I40E_VF_ATQT1;
>>> -		hw->aq.asq.head = I40E_VF_ATQH1;
>>> -		hw->aq.asq.len  = I40E_VF_ATQLEN1;
>>> -		hw->aq.asq.bal  = I40E_VF_ATQBAL1;
>>> -		hw->aq.asq.bah  = I40E_VF_ATQBAH1;
>>> -		hw->aq.arq.tail = I40E_VF_ARQT1;
>>> -		hw->aq.arq.head = I40E_VF_ARQH1;
>>> -		hw->aq.arq.len  = I40E_VF_ARQLEN1;
>>> -		hw->aq.arq.bal  = I40E_VF_ARQBAL1;
>>> -		hw->aq.arq.bah  = I40E_VF_ARQBAH1;
>> What about removing those I40E_VF_* defines?
>> This is their only usage here, right?
> 
> Yes, do you want to remove them in this patch? Or follow-up is sufficient?
> 
> Ivan
> 
> 

I'm fine with a follow up.

Thanks,
Jake