Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Message-ID: <5d8cbed6-45ff-449e-a849-d7707852a877@intel.com>
Date:   Wed, 25 Oct 2023 10:43:42 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 1/2] i40e: Remove VF MAC types
Content-Language: en-US
To:     Wojciech Drewek <wojciech.drewek@intel.com>,
        Jiri Pirko <jiri@resnulli.us>
CC:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231025103315.1149589-1-ivecera@redhat.com>
 <20231025103315.1149589-2-ivecera@redhat.com>
 <8a8f54a8-1a18-4797-a592-b57bc6fc45c1@intel.com>
 <ZTkHJ6IP4tj3EmCV@nanopsycho> <ZTkIH68kCzb+4VME@nanopsycho>
 <6cb52295-a20c-47ae-b75e-c841f665fdaf@intel.com>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <6cb52295-a20c-47ae-b75e-c841f665fdaf@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?K3lnMkxFcHRESytGTlRodEIxc1NzMHhvT3liY3J2TlVqTTEyZ1dyTHlId0gx?=
 =?utf-8?B?U3R5cGtPWU1UL2tqN2FlR0pzK0RBbWNwYmdXMzR3dlg4TUhlcXd4d2w1NjJr?=
 =?utf-8?B?UHozaEZaNHBDSGVUaldVaXMvaXdmY3phWFFSbDV2ZzJ2RFE4WmNTaUgyMVpG?=
 =?utf-8?B?OUJLcGtHOVNVb0FuN0dnNzZqc2k1NkhnQko3dFIwNlZmMWt2NkhmV3JWUEpO?=
 =?utf-8?B?QUZpaVBzWXVER1NJK0U0OXBPL1FrcW1WL0E2bzI5ZFYxNktPSGJLcGdIbUth?=
 =?utf-8?B?R2o3WVcrSVNQVmtHSjg1bUhSelMrZGFHUFYrMkVqS0hBMUhiSG01RHZRMmk0?=
 =?utf-8?B?bFRET2M5Nm1qVlJXQXNwTWxaRmJ6UStUSlVwVGkyR3Npc3JFODEzWFFIMHdX?=
 =?utf-8?B?WHJsWHFEQURCWlF0VmV5SGo0dldYTFlRLzZqQklzcFczTkc3NnZ2SEZlUFgr?=
 =?utf-8?B?NmtNNGVqM2JXK1k0RzNiZ20xbTlGMmgxOWZ5UG94WlhBMytDTm00dVk4bjUv?=
 =?utf-8?B?MlJHejIwZXFSeGRrL1pucUFmMVhKM29ZNEVYekNrYVZJU0tONmU1aWNyWkNh?=
 =?utf-8?B?RXNOTFluU3lDZTlLYkZUT3dJaDVjaUkzVUNWTzkrazd3U3dNTW44UHd3ckhX?=
 =?utf-8?B?ZXlTRUlrZlBaU0llMDZpQWNlQldFWFdleE02N1RHanVsT2kreWF1aHN5Rjcz?=
 =?utf-8?B?VXZ3L2sraUMzcUJOV2ZMZ0VxaTVLaGVmWDRSSG13UHZwaGZ2UElkQ0EyQ0py?=
 =?utf-8?B?VFZDL0JLNFU0disvVkFEcTY2RkVwQlc2M1hQS0l3dnlnZ0p1V0NGTzdMaTJo?=
 =?utf-8?B?UExRSTFxZVNEVFVSNUM0enJ1MkpLaDFZSHRVMktwT2Q0ZFJ4MXNqNFc2d3ZN?=
 =?utf-8?B?alhmdTN1c0RNYnhlOVJjKzJ3Z3lIY2RDeHI0QTFsRVFhcFhERnNKbklNd1Rw?=
 =?utf-8?B?c1lrVW1ReVFHQVlLWWZEK2dWbStmTXhBZ0hac2o5L3FNQ0JHeUxib0c1eVZn?=
 =?utf-8?B?ZXBRUlV5RCt5RjFQL3dma0xoTVo5anpOZWx0dXRFOFE0MVJBd1d6ZFgzKzlP?=
 =?utf-8?B?emRGQ3RnN2RXVjBjSXNOb09UUUZ0WEZzUTBDMVM5aFk2RFJYQUpIOGxyWU1z?=
 =?utf-8?B?Q0ZRYmV3ZkQveHBtU3NUTG91bTlES2xWaEdJNDJkTjFDN0I5SXNHTlpLYlNy?=
 =?utf-8?B?MnlONklQRmZzbzhVYXJ5TVRjK1dlS3NoblZ1WWY2RXkrbmNUcU5ySTZKVXRh?=
 =?utf-8?B?aU5oZGhiUUVpVURFUnVMVkRMdG5kT0IzSkZyTmdkOE5pR2g4eDZnOWtFRHZp?=
 =?utf-8?B?SUprSGVwSkpGVjJlVC9uUlIwQ3Z5ejIxbVZWVnpWRkRJanc5OTV3Um0wYUFK?=
 =?utf-8?B?ckhwRThDQy9wd0ZtbkdmUHc1cWRGYklmVmJ4NkNaM0E2MWdPbWZNbStCdy9h?=
 =?utf-8?B?Z3dJVllPenArWUlWZWpZMkZzbTRET3Z5dEhOeXJ0c0pnWis5d3VhWUlkU3NN?=
 =?utf-8?B?UFJ5cjBoQ1Z0RDA2bnZzOEtTR2VZb3BpbU5mL3VLNmY0WkwyTGJMYkpsWjRn?=
 =?utf-8?B?RW1yVlJNRUovR1IwU3pUeW1pcFlYUXR2Y3VqckplaUVDV05NOXRTR05YQTNZ?=
 =?utf-8?B?Wm9JQit5MjdrNU8xRDI4aXcxa2FaTkVKQ3JVVGljNkJ0MGQyMnJRZDNkS0hm?=
 =?utf-8?B?djU2V1Q4WFpDUHZEL3RERkVnR1VLam94OHVhNXMrRml5SVMrTHY3RzhRd1Bp?=
 =?utf-8?B?eGtsd0d4NWkyZTVTdlNIY3BJeUdOeW1CejgwWmtmN2dTdzh0MU13a1RjWEtK?=
 =?utf-8?B?czkvMUhtVXZyZ3dRMGswUnhiSzl2KzNraGs0N1pEa0RKQWVrditGOXYyakdm?=
 =?utf-8?B?c3ZGcVd2OTM4dnRFUFZmSjRzTjR6ekZhN2cwMGk0UWIyemJJeGw0MVBBT3la?=
 =?utf-8?B?ZFFleG5mRlZzRjQ3SkJoREhSWEI2SlRITTNSMGhEempMMUppU2xWdkhWTnhi?=
 =?utf-8?B?OFVTYTRFMXFoYUdQSEc1YW9SK05oZlNMQWFaZnk3SkJ0QUUrTTcxbDNJNFdk?=
 =?utf-8?B?T2c3YjhQS2dTV2NFd09USFZtU3RoUHdpQmZOQ2ZMVUt0Ni9zQ1RVclNiQWNJ?=
 =?utf-8?B?a2VqQ1ZQcUN6aW1GaklmSTN5UFIzYzNMckk5ZjZWNDlEQU9XbGFkbllBSnlC?=
 =?utf-8?B?aVE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e95136c2-619f-440e-30f7-08dbd581ef30
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 17:43:44.4702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /B4WNOpDhAxK/1frDArTdMDAGRzxPioeECK947O4WUldEtrncDZtXAVJE8sPU1n0WMC0IHDA0iQJMOoW63Ud85PNaoAFshBDgAs6ics9csE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6038
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 25 Oct 2023 10:44:31 -0700 (PDT)


On 10/25/2023 5:27 AM, Wojciech Drewek wrote:
> 
> 
> On 25.10.2023 14:20, Jiri Pirko wrote:
>> Wed, Oct 25, 2023 at 02:16:39PM CEST, jiri@resnulli.us wrote:
>>> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.drewek@intel.com wrote:
>>>>
>>>>
>>>> On 25.10.2023 12:33, Ivan Vecera wrote:
>>>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>>>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
>>>>> i40e_adminq_init_regs() and remove enums for these VF MAC types.
>>>>>
>>>>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>>>>> ---
>>>>>  drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++++++-------------
>>>>>  drivers/net/ethernet/intel/i40e/i40e_type.h   |  8 -----
>>>>>  2 files changed, 10 insertions(+), 31 deletions(-)
>>>>>
>>>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>>> index 29fc46abf690..896c43905309 100644
>>>>> --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>>> @@ -17,29 +17,16 @@ static void i40e_resume_aq(struct i40e_hw *hw);
>>>>>  static void i40e_adminq_init_regs(struct i40e_hw *hw)
>>>>>  {
>>>>>  	/* set head and tail registers in our local struct */
>>>>> -	if (i40e_is_vf(hw)) {
>>>>> -		hw->aq.asq.tail = I40E_VF_ATQT1;
>>>>> -		hw->aq.asq.head = I40E_VF_ATQH1;
>>>>> -		hw->aq.asq.len  = I40E_VF_ATQLEN1;
>>>>> -		hw->aq.asq.bal  = I40E_VF_ATQBAL1;
>>>>> -		hw->aq.asq.bah  = I40E_VF_ATQBAH1;
>>>>> -		hw->aq.arq.tail = I40E_VF_ARQT1;
>>>>> -		hw->aq.arq.head = I40E_VF_ARQH1;
>>>>> -		hw->aq.arq.len  = I40E_VF_ARQLEN1;
>>>>> -		hw->aq.arq.bal  = I40E_VF_ARQBAL1;
>>>>> -		hw->aq.arq.bah  = I40E_VF_ARQBAH1;
>>>>
>>>> What about removing those I40E_VF_* defines?
>>>> This is their only usage here, right?
>>>
>>> Wait, do you suggest to use the values directly? That would be
>>> wild even for i40e :)
>>
>> Ah, sec. This is duplicated in
>> drivers/net/ethernet/intel/iavf/iavf_register.h. That confused me.
> 
> Indeed, in case of i40e they're going be unused after this patch so
> there is no point in keeping them, I think.
> 

Ya, this is all a relic from early days when i40e planned to share code
with i40evf.