Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2751705rda; Wed, 25 Oct 2023 11:11:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF62Qv8DG1YqPxTzqpalbkd5jI/OXTQixGVNeAeHyyZs7zCaJVsLLA/yFnjeKm4mPSXwLSl X-Received: by 2002:a05:6122:114d:b0:4a4:887:514c with SMTP id p13-20020a056122114d00b004a40887514cmr13921412vko.6.1698257479112; Wed, 25 Oct 2023 11:11:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698257479; cv=none; d=google.com; s=arc-20160816; b=ENHDd+yLJsGjfwAaUCi7zbj4R8GcPqWiU/IvoYzQRfH7wxWmAZ7K6z4CkUs/heb70I bSoGrQ2XKrX5bI2eS8B9z+aDCoEyIzixScE9/+rF7zeStMkJ5zO4Bn9ZWuS/fmuxMhb1 hb+cQT5h/OI4RPEJgGPP8X3t6khm0wGqy651Q36a7oirN+QK2KJpgCONfVWB9yYHL3mW 2AeTHplgKjVA1wB/PEPwNj+S4PjzE6mqLodgdIda7RP+OxmBsaG3FsayKUQYWkjQwBna BEvUhwGWuQQ2wKGELK6AppSR2Rs8GrRL6ZaSCxW/1WawxklyeyKqKjWKm0BXkGD2UUKR I1pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id; bh=2iMDVchob+o0oV/0w+uz7B6gj0y4M0k4PlyjKILH9gA=; fh=fclPsNw7Qtmd9XuuefFPtrMocPvUR66X7osfYkQ6KYc=; b=vQXQBFe6lyz3TuCj1c3dYTSGUOQ4xSGgLayt4EEVJtKXDKXI+NZohIUw9BeXu8nGeM BaUbapnCNY+jAotyKh6J0HlKYRSCHYLweIAZKIIW08uEfKoNR4P8LPDVGexJHs2wIQFk gZH0tQLEb91bcUVnRga6eK9k4OHKiqInup+sVFHK3cFrpHd/Pplvv2ypCBx7qKHtjV3x +pFagkFVGyfuZinH8PDcaSZLbY3f9WdVuWi7ehNvM1fa/PiB8fUsxmQ2JIzAygXkZ8So gf3jbWuvvUrnSg7Yw3DqCWg5DOfoIm+iAm3ij3LX2F9z3ToM4sL5GQWqeNbkNxOqUzn5 yJXw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Return-Path: Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id i8-20020a0ddf08000000b005a7baace908si11839452ywe.67.2023.10.25.11.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 11:11:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=acm.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 4FEB581603BF; Wed, 25 Oct 2023 11:11:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234162AbjJYSLG (ORCPT + 99 others); Wed, 25 Oct 2023 14:11:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229826AbjJYSLF (ORCPT ); Wed, 25 Oct 2023 14:11:05 -0400 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37610128; Wed, 25 Oct 2023 11:11:03 -0700 (PDT) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1ca215cc713so40362875ad.3; Wed, 25 Oct 2023 11:11:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698257462; x=1698862262; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2iMDVchob+o0oV/0w+uz7B6gj0y4M0k4PlyjKILH9gA=; b=kakwnop5YKW5A/1QduLU5CmgOPA9hmCBGJYyrgVHkixLlQVxiDigm/oWJnnp1E8bTi UCbY5e/OHx2DEzr9xsq+9ZTGiDj/PeFHhO797dz2KaWGST7HvrUd51u/K4XQRt4DyMPW WxJbAVVHtfp37o3JI0VO2yGc2k3wfdl/ySh31WL5t6+v0Hmm2oiOi2ys/DQNqZnxllmf k7RAdQtHIFIkbvtUxRn/PDKSPB3MjkybPIWOyR7rgm8K5oselq3Yz+9hDqUXDXwiAG1L lRqXrnkpSQUJlYWEM0gS/QB5vZyc0/fPZPcmaLuZw64plUR9HIwZVebJFk6j2NGfGQZi +8Qw== X-Gm-Message-State: AOJu0Yxt0kGoSyZjzkVbBwjOk1TiP1zla2saBstxfgnhtPy3c7A+KHOv 43JrJTcXrcm6UhKU9A49C8o= X-Received: by 2002:a17:902:c404:b0:1c7:8345:f377 with SMTP id k4-20020a170902c40400b001c78345f377mr17227158plk.29.1698257462403; Wed, 25 Oct 2023 11:11:02 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:4dcf:e974:e319:6ce8? ([2620:15c:211:201:4dcf:e974:e319:6ce8]) by smtp.gmail.com with ESMTPSA id jw15-20020a170903278f00b001bb99e188fcsm9560717plb.194.2023.10.25.11.11.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 11:11:02 -0700 (PDT) Message-ID: <3056c6d8-1e54-4954-9141-e0760a0d935a@acm.org> Date: Wed, 25 Oct 2023 11:10:59 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] ufs: core: Add host quirk QUIRK_MCQ_EXPAND_QUEUE_SLOT Content-Language: en-US To: Chun-Hung Wu , Alim Akhtar , Avri Altman , "James E . J . Bottomley" , "Martin K . Petersen" , Matthias Brugger , AngeloGioacchino Del Regno , Can Guo , Manivannan Sadhasivam , Asutosh Das , "Bao D . Nguyen" , Yang Li , Eric Biggers , Keoseong Park , Arthur Simchaev Cc: wsd_upstream@mediatek.com, casper.li@mediatek.com, peter.wang@mediatek.com, powen.kao@mediatek.com, alice.chao@mediatek.com, naomi.chu@mediatek.com, cc.chou@mediatek.com, chaotian.jing@mediatek.com, jiajie.hao@mediatek.com, tun-yu.yu@mediatek.com, lin.gui@mediatek.com, eddie.huang@mediatek.com, qilin.tan@mediatek.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-team@android.com References: <20231025085656.10848-1-chun-hung.wu@mediatek.com> <20231025085656.10848-2-chun-hung.wu@mediatek.com> From: Bart Van Assche In-Reply-To: <20231025085656.10848-2-chun-hung.wu@mediatek.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Wed, 25 Oct 2023 11:11:16 -0700 (PDT) On 10/25/23 01:56, Chun-Hung Wu wrote: > This quirk needs to be enabled if the host controller cannot > distinguish queue full or empty. From the UFSHCI 4.0 specification: "When the head and tail doorbells are equal, the queue is empty. [ ... ] When the head and tail doorbells are not equal, the queue contains queue entries." How is it possible that a host controller cannot distinguish queue full or queue empty? Which (head - tail) values cause trouble? More information is needed. Thanks, Bart.