Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Sender: Guenter Roeck <groeck7@gmail.com>
Date:   Wed, 25 Oct 2023 11:58:13 -0700
From:   Guenter Roeck <linux@roeck-us.net>
To:     Zhang Rui <rui.zhang@intel.com>
Cc:     jdelvare@suse.com, fenghua.yu@intel.com,
        linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
        lkp@intel.com, dave.hansen@linux.intel.com, len.brown@intel.com
Subject: Re: [PATCH] hwmon: (coretemp) Fix potentially truncated sysfs
 attribute name
Message-ID: <c5c1fb9a-2569-487f-9e16-9c637ba0db04@roeck-us.net>
References: <20231025122316.836400-1-rui.zhang@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231025122316.836400-1-rui.zhang@intel.com>
Precedence: bulk

On Wed, Oct 25, 2023 at 08:23:16PM +0800, Zhang Rui wrote:
> When build with W=1 and "-Werror=format-truncation", below error is
> observed in coretemp driver,
> 
>    drivers/hwmon/coretemp.c: In function 'create_core_data':
> >> drivers/hwmon/coretemp.c:393:34: error: '%s' directive output may be truncated writing likely 5 or more bytes into a region of size between 3 and 13 [-Werror=format-truncation=]
>      393 |                          "temp%d_%s", attr_no, suffixes[i]);
>          |                                  ^~
>    drivers/hwmon/coretemp.c:393:26: note: assuming directive output of 5 bytes
>      393 |                          "temp%d_%s", attr_no, suffixes[i]);
>          |                          ^~~~~~~~~~~
>    drivers/hwmon/coretemp.c:392:17: note: 'snprintf' output 7 or more bytes (assuming 22) into a destination of size 19
>      392 |                 snprintf(tdata->attr_name[i], CORETEMP_NAME_LENGTH,
>          |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>      393 |                          "temp%d_%s", attr_no, suffixes[i]);
>          |                          ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    cc1: all warnings being treated as errors
> 
> Given that
> 1. '%d' could take 10 charactors,
> 2. '%s' could take 10 charactors ("crit_alarm"),
> 3. "temp", "_" and the NULL terminator take 6 charactors,
> fix the problem by increasing CORETEMP_NAME_LENGTH to 28.
> 
> Signed-off-by: Zhang Rui <rui.zhang@intel.com>
> Fixes: 7108b80a542b ("hwmon/coretemp: Handle large core ID value")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202310200443.iD3tUbbK-lkp@intel.com/

Applied.

Thanks,
Guenter