Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2779028rda; Wed, 25 Oct 2023 12:02:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEtlSijy+LTHROb2t7IaCDPBqdzpfy3WXj63Zy2Wea+sfRVaEdL/Bpcc3Xd5sNzfDctvlUd X-Received: by 2002:a25:7614:0:b0:d9a:c31a:c0d0 with SMTP id r20-20020a257614000000b00d9ac31ac0d0mr17464874ybc.8.1698260528264; Wed, 25 Oct 2023 12:02:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698260528; cv=none; d=google.com; s=arc-20160816; b=HDeFKIyr/2ZFhz7LkC9eclDsjoKDkn22c/wzReSX6PToMst4p7dsUYvQksKq+1SUzv EH0uyXmr9jfQjqovznnJzG3FxmFDvUeY5svMv0Kcjw9qmiBGJb8euc31rVt4fGQ4p7uI GYlQmUft3KVLJLwOISF8vu1oj7iJ3PJuW0iMVzUEkJ9kC2/8dPIjIqnjGRUTSJ01I4VC 6UnfW1eBizRBVsJehRyGbdkBhfXdE8PiTHY4TX63gBk2ygRSuW0VR/ECuKNcXXDp3OFr yMjxrCxKqUfHGj3qPwU9PcmtLuF+xdAtIQ98Zb4w9OGam70U+Drh+SXF4EaIlCKhX1wE 4R/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version:date :message-id:subject:references:in-reply-to:cc:to:from:dkim-signature; bh=OQAl/PTqwfVgnwzoqGM8ShtV+6jsVpx6sSFnaC8ctL4=; fh=/xvwTKjHRYtCDowK/iD5dZXfvIdr/FcpNkFe2ndiu7U=; b=QRp56FyJI+blYo1CGspMp8TUyTJapR7a98uSDGcdJG5bdtjE6x3D6SoRxeZlyy81fN XryOJIz/J5kZVsQ+3V1uj8SXH23SLMWboFMMahBPa66tEJwOA4VvxORJ5BQuUnDibF4C qoYb3nxpGDFZI7FNDU34oahZbUB/ne3fWrdsSubh7WlBp+cDB0S0iBObKbKnvM8qtWBq OKoMk40bl2BBHcVegwiD6wMwVINsWQGUH7OU8feyRfzQLKcMwWI9MYMdtWX9jjGJXv0T QlHjLoFsewd2tCiIcFroiA9zEpL/0acFea4LOoK/1RAyhby1r2J5RG6Z/rUzu2yuu1Ps lxJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oNnDSGbZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id o132-20020a25738a000000b00d9ca4aca9aesi10779650ybc.292.2023.10.25.12.02.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 12:02:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oNnDSGbZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6D8F780CCD35; Wed, 25 Oct 2023 12:01:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234762AbjJYTBi (ORCPT + 99 others); Wed, 25 Oct 2023 15:01:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229733AbjJYTBh (ORCPT ); Wed, 25 Oct 2023 15:01:37 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 483C8195; Wed, 25 Oct 2023 12:01:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 411BEC433C8; Wed, 25 Oct 2023 19:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698260493; bh=cqpNLxz8QEJ10N9YfPvQwxHo4wYWmPCwAExeIfzZku4=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=oNnDSGbZgeOKtnZPz02wgvr7xlTPSdbewbHLDaI3iNXWB3jUzAPT3QHtEuRaVemYj yWmrvfz73TYLTO37Jsg9eeBpTCiEXux7zpx+ltlPUjrYLFBCYF4uaN7/ERRDvdjdng 02py9nJro2mhHDoPw6M0ALY6aH3NbIaHoIwF4aaZk0vWTX4vz+SCtTMX+1V9ItZ+u+ DvVY1PDiD9Lqu5YpZxbBQKCTQJ2kZE/2PR1Sxg5zEJtG1lGS8YxmcC8W+B9o1fub5V RWuDnuUG/5w/cxeoVpsqUiX4OEi8mqH8z8iF0MVzxElofEmxwsRctY4tYEf7hVx56y OsTlLRZ2RieCg== From: Benjamin Tissoires To: jikos@kernel.org, benjamin.tissoires@redhat.com, jm@lentin.co.uk, linux-kernel@vger.kernel.org, Martin Kepplinger Cc: linux-input@vger.kernel.org, stable@vger.kernel.org In-Reply-To: <20231002150914.22101-1-martink@posteo.de> References: <20231002150914.22101-1-martink@posteo.de> Subject: Re: [PATCH] hid: lenovo: Resend all settings on reset_resume for compact keyboards Message-Id: <169826049199.324677.14789310817428601000.b4-ty@kernel.org> Date: Wed, 25 Oct 2023 21:01:31 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.1 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 25 Oct 2023 12:01:58 -0700 (PDT) On Mon, 02 Oct 2023 15:09:14 +0000, Martin Kepplinger wrote: > The USB Compact Keyboard variant requires a reset_resume function to > restore keyboard configuration after a suspend in some situations. Move > configuration normally done on probe to lenovo_features_set_cptkbd(), then > recycle this for use on reset_resume. > > Without, the keyboard and driver would end up in an inconsistent state, > breaking middle-button scrolling amongst other problems, and twiddling > sysfs values wouldn't help as the middle-button mode won't be set until > the driver is reloaded. > > [...] Applied to hid/hid.git (for-6.7/lenovo), thanks! [1/1] hid: lenovo: Resend all settings on reset_resume for compact keyboards https://git.kernel.org/hid/hid/c/2f2bd7cbd1d1 Cheers, -- Benjamin Tissoires