Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <5f157c65b07eee357f7682be0945d638.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <be119e71-0456-4806-8c0a-e77732553f70@linaro.org>
References: <20231025-topic-sm8650-upstream-clocks-v1-0-c89b59594caf@linaro.org> <20231025-topic-sm8650-upstream-clocks-v1-10-c89b59594caf@linaro.org> <467bc514-1cff-4bc5-a553-fd1ef0886ee5@linaro.org> <be119e71-0456-4806-8c0a-e77732553f70@linaro.org>
Subject: Re: [PATCH 10/10] clk: qcom: rpmh: add clocks for SM8650
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Conor Dooley <conor+dt@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        Neil Armstrong <neil.armstrong@linaro.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Rob Herring <robh+dt@kernel.org>,
        Taniya Das <quic_tdas@quicinc.com>
Date:   Wed, 25 Oct 2023 14:47:13 -0700
User-Agent: alot/0.10
Precedence: bulk

Quoting Neil Armstrong (2023-10-25 05:00:54)
> On 25/10/2023 10:47, Konrad Dybcio wrote:
> >=20
> >=20
> > On 10/25/23 09:32, Neil Armstrong wrote:
> >> Add RPMH Clocks for the SM8650 platform.
> >>
> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> >> ---
> > [...]
> >=20
> >> +static struct clk_hw *sm8650_rpmh_clocks[] =3D {
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_CXO_CLK]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 =3D &clk_rpmh_bi_tcxo_div2.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_CXO_CLK_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_b=
i_tcxo_div2_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK1]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_=
clk6_a2.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK1_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpm=
h_clk6_a2_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK2]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_=
clk7_a2.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK2_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpm=
h_clk7_a2_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK3]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_=
clk8_a2.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_LN_BB_CLK3_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpm=
h_clk8_a2_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_RF_CLK1]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 =3D &clk_rpmh_clk1_a1.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_RF_CLK1_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_c=
lk1_a1_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_RF_CLK2]=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 =3D &clk_rpmh_clk2_a1.hw,
> >> +=C2=A0=C2=A0=C2=A0 [RPMH_RF_CLK2_A]=C2=A0=C2=A0=C2=A0 =3D &clk_rpmh_c=
lk2_a1_ao.hw,
> >> +=C2=A0=C2=A0=C2=A0 /* missing RPMh resource address for clka3 */
> > So, the downstream driver suggested it's there but CMD-DB disagrees?
> >=20
> > Can we get a confirmation whether it should be there?
>=20
> There's a clka3 on the PMK8550, but it's undeclared in CMD-DB since
> unused/unconnected on the MTP & QRD platforms.

Can you add that comment here so we know why the resource is missing and
not just that it is missing?