Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8;
Message-ID: <4f6181c8-07f1-471e-a186-6a129a2f0b2b@amd.com>
Date:   Wed, 25 Oct 2023 17:06:56 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] platform/x86: Add s2idle quirk for more Lenovo laptops
Content-Language: en-US
To:     David Lazar <dlazar@gmail.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@amd.com>,
        Hans de Goede <hdegoede@redhat.com>,
        Mark Gross <markgross@kernel.org>,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Cc:     Mark Pearson <mpearson-lenovo@squebb.ca>
References: <ZTlsyOaFucF2pWrL@localhost>
From:   Mario Limonciello <mario.limonciello@amd.com>
In-Reply-To: <ZTlsyOaFucF2pWrL@localhost>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGhDcTluUnp1K3JORjZlQUQ5bDRQMDF5aGc1S2JidjNkcUZRb3lrei9EOGFY?=
 =?utf-8?B?MzROQXZrdlRLbnc5OXVvUWNNeGVtN0tpaUE1V29ONDV1S0wxdDFsTmZkOUtl?=
 =?utf-8?B?N3hhbXhiY0xJc1Z4NytCOXZMbE02QkhERVh6KzJqTE5PakdOVVpQUGZjbTVG?=
 =?utf-8?B?cVFoZWpUWFNtUENaODNBRGwveEdxL3NxVm9YSW9PUUtnMWI5d0tLVXlNRTFt?=
 =?utf-8?B?cHdzK0h2WlRWUGJyZUk2TzlDY2RBdFZzbzhLd2VIUWp2Vk5SWmRWdzFrM3Fj?=
 =?utf-8?B?cmJvVERJY1RkOStsQmpWMm0xUXdxUU12cEFHY0U2RXk5Mm9Ed3EwcWxBZGhy?=
 =?utf-8?B?VlZRQU9EdXdPR28waWlrcHdZV2o1MFpwTTV4REJ3bHV0aE95MU9vbFR6MTVL?=
 =?utf-8?B?VlpFcExmMGRmRy90ZVhKR243VDllbGhIWTFGSlVETDVvdWdCQ3lrckdXbisx?=
 =?utf-8?B?N3puZlk2ZUtoemVWMS80cm1HVkR3Q05GZFg0aDFzMFJldE80RXFLWnc2VFdO?=
 =?utf-8?B?Mng1c25Kcmt3T0xNNFF2UUV3eEdDeGF0N2dUSHRzZEluZ2NDQWhISElRZmRq?=
 =?utf-8?B?Vnk5NjlaYTNPNXliNWNKZ3lyZ3dzR0c1N3p5VUZ1YTJPeVRaUGU0L2tWa2gr?=
 =?utf-8?B?UkZsempORmw4aExlZnhQcjlIdmNGMGF4US9nMitlaHlneHVOVklvaG9OYm5B?=
 =?utf-8?B?dFZxdGxWL3NZMUpjYUNhQXEycmV6Qm5KbURsR3FpU0pYRkpMOHM5V2ZSclM4?=
 =?utf-8?B?dWVFZTlrS2VDMWVCZmF4M2pVYlNLcTFobzQ5eTBZYWh3RkNSSzNycXVyeElt?=
 =?utf-8?B?SXczbG5hT3cyUWZJblUzV0FjZ09VOGMvUXdUZWdYUUJia2x5Z1BKdjhmSGo4?=
 =?utf-8?B?YkNBSlhYU0JDMWY4VFJuTmthT1BUTlR1UUZrTDAxc2lUcCtvTWhIUEdoL0tr?=
 =?utf-8?B?ZHNpLzAxV1IvMVUvdnVkblpaUDR4bTI0elRuUEptK3RoLzFUMnU2bWhBNUZQ?=
 =?utf-8?B?YzZkd3ZsQXZ6TnZSdnFrNzF6OVp6MVJzbTJTTVhZMWQ4QU1wTnRDVXdIMnlp?=
 =?utf-8?B?ZG1oTFpVVmR1YU9XMGI2Y1RlU3lCTDc4S1RBNlhkQ2ZnTDVPb0U4YTEwMVBV?=
 =?utf-8?B?Q1pWam83T2M3S0xwU3hBR2taUkc0UWszZTJxeWlkRTdacGk2SVA2VW41am9o?=
 =?utf-8?B?cTdNa3pjT2dPcmVzZHR5YnJ6ZmZVZzQ0K09mdEVUL2JjSGV0R2R6dnJTN1FH?=
 =?utf-8?B?SURya0ZTc1htYmFHdnJBdEpVQlNzc2FOQzJXVjV1bUg2b3piNTFoOTEvN0No?=
 =?utf-8?B?enVFRENHZVhwUnFoNGdEZnRRR3BGdnFqNHVrN1F5Si9zUDh2bDUycGEyYm9M?=
 =?utf-8?B?RXphRVpjOGdYL2lLL2hTVDBPeU5kckFQU1p2ZFBjZmVUTFJuYW5kS0trRmJp?=
 =?utf-8?B?dFZvaXdVRkV5Ykg1OFBUSExUR1FjWHAvMkFUVFJqY1ZVa0k5cHV1cGNCOW9F?=
 =?utf-8?B?a2NDYTVxYWtqSERJVHZZRXVEL0dKOHZEdkp3OVdzc2lVamRia0VjV1BRRmJu?=
 =?utf-8?B?TFdIcGNmc3J5Sk4ycGdPd1I0QnBrdUMvNDRSdVdIaThGdHI5K0ZYdU1reFpt?=
 =?utf-8?B?c0Z5a1VOWFNwZVFyTFByOE9DRytYbnVqTUo2NGtNZWoxWEZsL0o0eUlXYUxY?=
 =?utf-8?B?UDVEemNoNmd4bXJLamtiUHFReTh4Y25iMFRsUzMxaG13RjhrSC8yNXdtS2Jr?=
 =?utf-8?B?YUxncFhoeGoxeUc4ZUkzTmhYZTVHcm5xVXNjeXUwTzJwNzEvU3FneGFqYTE1?=
 =?utf-8?B?WnYyQXZacm9XTFpCUFBHbzhFbWVOOHRXTWxjN05iSDd6V1hGb3V4bXVWZnRQ?=
 =?utf-8?B?bGdlK2NrOFJrQ2c2d1IyZ2lmT3JueGpFZzdCb1VrMWI4bWFlQzAxenBrUGJX?=
 =?utf-8?B?YW5nd1M3ZG9HSSs5cTE3Z09RL2lyNFRjYWlUbFhHalZKRDVUNkRNUGowQjQ4?=
 =?utf-8?B?TlZDSC81bGNZbXU5QnBDQjBHRW9WZlpNZEJRcmNqYzVoMEZiOHJ2SjFseE9l?=
 =?utf-8?B?SmJka29CWGE2RTNtN2xPd3NxUW4xejRaWWd3Mi82ajJKUEk3Y005eXVsamR1?=
 =?utf-8?Q?IAr/TcwqV/s8M+F0vYCj8KJko?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5e17a30f-4f62-4b63-83d3-08dbd5a6b541
X-MS-Exchange-CrossTenant-AuthSource: MN0PR12MB6101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 22:06:58.7911
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: cWne7krd6HcUVjJIUu3jKMpuQvLG13s6tHawHtwcsCMGtgPvnMoiNU8Kc8q4WJmu8aKw4BqBxnUboVdeEB34Lg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6542
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 15:07:20 -0700 (PDT)

On 10/25/2023 14:30, David Lazar wrote:
> When suspending to idle and resuming on some Lenovo laptops using the
> Mendocino APU, multiple NVME IOMMU page faults occur, showing up in
> dmesg as repeated errors:
> 
> nvme 0000:01:00.0: AMD-Vi: Event logged [IO_PAGE_FAULT domain=0x000b
> address=0xb6674000 flags=0x0000]
> 
> The system is unstable afterwards.
> 
> Applying the s2idle quirk introduced by commit 455cd867b85b5
> ("platform/x86: thinkpad_acpi: Add a s2idle resume quirk for a number of
> laptops") allows these systems to work with the IOMMU enabled and s2idle
> resume to work.
> 
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=218024
> Suggested-by: Mario Limonciello <mario.limonciello@amd.com>
> Suggested-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Signed-off-by: David Lazar <dlazar@gmail.com>
> ---

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

>   drivers/platform/x86/amd/pmc/pmc-quirks.c | 73 +++++++++++++++++++++++
>   1 file changed, 73 insertions(+)
> 
> diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> index ad702463a65d..6bbffb081053 100644
> --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c
> +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c
> @@ -111,6 +111,79 @@ static const struct dmi_system_id fwbug_list[] = {
>   			DMI_MATCH(DMI_PRODUCT_NAME, "21A1"),
>   		}
>   	},
> +	/* https://bugzilla.kernel.org/show_bug.cgi?id=218024 */
> +	{
> +		.ident = "V14 G4 AMN",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82YT"),
> +		}
> +	},
> +	{
> +		.ident = "V14 G4 AMN",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "83GE"),
> +		}
> +	},
> +	{
> +		.ident = "V15 G4 AMN",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82YU"),
> +		}
> +	},
> +	{
> +		.ident = "V15 G4 AMN",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "83CQ"),
> +		}
> +	},
> +	{
> +		.ident = "IdeaPad 1 14AMN7",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82VF"),
> +		}
> +	},
> +	{
> +		.ident = "IdeaPad 1 15AMN7",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82VG"),
> +		}
> +	},
> +	{
> +		.ident = "IdeaPad 1 15AMN7",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82X5"),
> +		}
> +	},
> +	{
> +		.ident = "IdeaPad Slim 3 14AMN8",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82XN"),
> +		}
> +	},
> +	{
> +		.ident = "IdeaPad Slim 3 15AMN8",
> +		.driver_data = &quirk_s2idle_bug,
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "82XQ"),
> +		}
> +	},
>   	/* https://gitlab.freedesktop.org/drm/amd/-/issues/2684 */
>   	{
>   		.ident = "HP Laptop 15s-eq2xxx",