Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Message-ID: <88541b20-6745-28e3-6ba8-803a71554d6f@amd.com>
Date:   Wed, 25 Oct 2023 18:41:49 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Reply-To: babu.moger@amd.com
Subject: Re: [PATCH] x86/resctrl: mba_MBps: Fall back to total b/w if local
 b/w unavailable
Content-Language: en-US
To:     Tony Luck <tony.luck@intel.com>, "Moger, Babu" <babu.moger@amd.com>
Cc:     Peter Newman <peternewman@google.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Shuah Khan <skhan@linuxfoundation.org>, x86@kernel.org,
        Shaopeng Tan <tan.shaopeng@fujitsu.com>,
        James Morse <james.morse@arm.com>,
        Jamie Iles <quic_jiles@quicinc.com>,
        Randy Dunlap <rdunlap@infradead.org>,
        linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
        patches@lists.linux.dev
References: <20231024181600.8270-1-tony.luck@intel.com>
 <CALPaoChftF-H6GauKq4-c_qBJP1GJbR3-ByE5krsaQF4y4y9oQ@mail.gmail.com>
 <ZTluypa9bCWv4k2n@agluck-desk3>
 <e4994218-a7a2-4505-868e-a5c825ca4db0@amd.com>
 <b8ea0a74-347d-475f-a36d-8944ced16951@amd.com>
 <ZTmAFVuYlMuCbQHz@agluck-desk3>
From:   "Moger, Babu" <bmoger@amd.com>
In-Reply-To: <ZTmAFVuYlMuCbQHz@agluck-desk3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dUpMNU5sSEVlQXlCT0xUc29Ic1RRSzRKVEE2bU1Ya0Vpdm9paXhoWjRNYW1y?=
 =?utf-8?B?a0VqbndvSDY5L2t3aGYyTHB4N1plOTZkeHljOTlLSkkwV3d2UFIzNEtHTXZa?=
 =?utf-8?B?d2xJNXFCamUxb0NrU2U1YnpqMGJPcmhlcGpEcTBudkZRVTQ5RGdOTW53cDVD?=
 =?utf-8?B?d295YmlyV1BsYmI2b2JBd2dRdjlXZjNxRjMrNndxMGFsQ3U1RGE5SUw3Umly?=
 =?utf-8?B?bjRqVmllalA4UWFrRy9YRmk0RVYyNmc4QTBVQjdRYjU1U25ZeU1FUGVEL25r?=
 =?utf-8?B?NWdaMGxHNjg5WEZkbVdJTUFRajZiTTNGa1JuMHJEQnZWQnNkRnZ0Mi8ramZH?=
 =?utf-8?B?dW0wY21iU0M4c2crV0EvUDlCU0VndlMyTlV5TGszSVJxZ3c4UXRIRWtpTjFx?=
 =?utf-8?B?bmI2YVQzWnpnYXM0VnFFT05ETWZCYis3cUZXWHV6WFB4b3hsWGlsTFBkdTJ1?=
 =?utf-8?B?ZzRWRkF5b1JJa2M0dzRaMkZrOTRBekpCN3MyekZJbUhoSENWR2k0SHN0YW1m?=
 =?utf-8?B?blVvVXBGYk9jSnRpelRLcXJNVjYrN20weUZnbEw2SWpvbFhsajNiYUlxT0hU?=
 =?utf-8?B?MUJQbVo2Vk84RlgvMzNTbFNUNDhsZlE5clc5WWFyeHpzdUw2Nk03MzRCL05J?=
 =?utf-8?B?dFpGbG9UYXkxTW5nRFF4NVBHNlBNbmsvNGFSK2tKdHFtSk9EbS9MbzVhbU9o?=
 =?utf-8?B?am9sUkgrKy9UaDJwd1Jnbk5kSnBlemIyWSthSTY2aExMMm5DRFpJN0U4R0ZZ?=
 =?utf-8?B?Z3gzanVoQllDb00ycDBENURNakMvaHVRN3VsbjZvYzlVK0J0di9Vcmx5TzFL?=
 =?utf-8?B?YlZJSWpTNTR6dkJuY0RYNWxmOXc3ZVE3eDQyOXZrSUZRNGJMd241U1lVbjhq?=
 =?utf-8?B?NkRjM3FBVXB1MmxuV2pMV0N3US9HSFYzOXdRR1BmTGFMUUwrNTRpUytoL0ho?=
 =?utf-8?B?VllsY2V0R0oxOXN1Q2hJaVhkZWZQQWV4YTNiQVdIWXdBUU5UODJPd1VTNDBn?=
 =?utf-8?B?RkIwQnQ2cnNIRG5Nd2hyTWxkaHIzZmNrODVVNmU1Z0xDTDdPTWxZdFkyUUlk?=
 =?utf-8?B?bmxrMGdzZFA5MEFiejB4MCt6V2JOYVZrVnA4cm5VTVg0ODc1bzJYLzlaRGZ5?=
 =?utf-8?B?Rml5aDQ4ZU9NV1FIcm5kejhMR2xGcit5RGozTjZvcTc2TE1Mb0tzS2VHQ1ZY?=
 =?utf-8?B?cC9XZUMxekZ1c2Q4SXFvU0lKSm03a0RpV0NzTVlpZzE3MW9zNFYrUTB5dHpJ?=
 =?utf-8?B?L1ZJRDZkeFhGaGhIMW5WNE1UcXM3c2Y2eTJ6d0pZTS84UXhBZzcyb0xZT3l5?=
 =?utf-8?B?Yk1qTWh2Z3R6NEN6NDRyaFRrUnhEUkxWaFFBVVUyeTQ0UmFsZE9EMU11WFZq?=
 =?utf-8?B?MnJ1RzhIdG9YY1R2bjFqZEZVbTdOL05ucGVGV2ZZZmwyd0NDTG9XMERiVmsr?=
 =?utf-8?B?QlgxenB2ZkVDVXhSRVEvbkhWdi9QVmt5MGFYcTVtRTI2L3RTZnMwa2ViNXV6?=
 =?utf-8?B?bXArZ2VVUmJCTjVGeW4zTnFUaHppU3BTejlYYkIxTkgxS0FzTUJaMzRHS2dR?=
 =?utf-8?B?VXNaNkpKQWNmVGo4TkMzZURZTGFNM2FNbGRIbmxvekhBWHc0bVo3N3dZVWlL?=
 =?utf-8?B?bkZpK1lXUUZyTFlsajVDTXFxbzY4Y3ZNNE5CdDlWN3ROcnZkOUhBNmp4MHBM?=
 =?utf-8?B?VzdrelEvTEJNb1lsVnRSWGpWM2VqT0ZjZUlmTG1tbWY5Y0FaNE5RQVMzY3hn?=
 =?utf-8?B?ZE9NUCtYcDg0VE5CZTlaWGtjN2xQTlJXTUYzNUZObC9pRFBYTGw2VEd2cFp0?=
 =?utf-8?B?SjM2SnR5Z2ExRGEvaVU0ckVFQXhKdW1FV2Jya3NVTHhEUUpGUnJicm1mL0Jv?=
 =?utf-8?B?NEdlVXlzODQyR0JrQm9hNUlkVExnc24rcVNKZUJ6R1FqbVNRS3RCL0cxckMx?=
 =?utf-8?B?bXBzYU80Y2oxODNKbVp0ZUQrWG9LN3cvVEVvRjIvN1hnMVdRL0VZTkRscjN2?=
 =?utf-8?B?cE9aYkxLSnRUVDEvcEVNTFNGaW53aDFFbUJNWENzUjFvMjBkc1QxYlN3MmhF?=
 =?utf-8?B?UjU2OEkxTUlRQnE0dTZhazU1RkdZbC9qeTd1RFhad0ZCU3dZWjVJMVdYYmN4?=
 =?utf-8?Q?4ezw=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2309f36c-b695-4445-efca-08dbd5b3f7d2
X-MS-Exchange-CrossTenant-AuthSource: MW3PR12MB4553.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Oct 2023 23:41:53.8498
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: gtwjWc83VyDs6/MjNqRD/4JvkLHnAw4znXbuW69xdqyEu9FwLZfZ6Dh8cXdx9RPE
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR12MB6778
X-Spam-Status: No, score=-4.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS
	autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 16:42:11 -0700 (PDT)

Hi Tony,

On 10/25/2023 3:52 PM, Tony Luck wrote:
> On Wed, Oct 25, 2023 at 03:42:14PM -0500, Moger, Babu wrote:
>> I meant, I was thinking bit different.
>>
>>> You need these changes in only two functions, mbm_bw_count and
>>> update_mba_bw. You decide which event you want to use based on availability,
>>>
>>> Something like this. I updated mbm_bw_count.
>>>
>>> diff --git a/arch/x86/kernel/cpu/resctrl/monitor.c
>>> b/arch/x86/kernel/cpu/resctrl/monitor.c
>>> index 0ad23475fe16..302993e4fbc3 100644
>>> --- a/arch/x86/kernel/cpu/resctrl/monitor.c
>>> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c
>>> @@ -436,8 +436,16 @@ static int __mon_event_count(u32 rmid, struct
>>> rmid_read *rr)
>>>    */
>>>   static void mbm_bw_count(u32 rmid, struct rmid_read *rr)
>>>   {
>>> -       struct mbm_state *m = &rr->d->mbm_local[rmid];
>>>          u64 cur_bw, bytes, cur_bytes;
>>> +       struct mbm_state *m;
>>> +       int evtid;
>>> +
>>> +       if (is_mbm_local_enabled())
>>> +               evtid = QOS_L3_MBM_LOCAL_EVENT_ID;
>>> +       else
>>> +               evtid = QOS_L3_MBM_TOTAL_EVENT_ID;
>>> +
>>> +       m = get_mbm_state(rr->d, rmid, evtid);
> Ok. Yes. That seems simpler.
>
> Maybe I should just set a global "mbm_evtid" at mount

Lets not make it global yet. This is only affecting couple of functions 
when mba_MPps is enabled.

> time. No need to check every time to see if is_mbm_local_enabled()
> somehow changed and local b/w measurements were suddenly
> available!

What changed suddenly? Can you please elaborate.

Thanks

Babu