Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.34 as permitted sender) client-ip=23.128.96.34;
Message-ID: <6d12707c-4666-40ac-9c8e-79b65f011263@intel.com>
Date:   Wed, 25 Oct 2023 17:20:02 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH iwl-next 1/2] i40e: Remove VF MAC types
Content-Language: en-US
To:     Jiri Pirko <jiri@resnulli.us>,
        Wojciech Drewek <wojciech.drewek@intel.com>
CC:     Ivan Vecera <ivecera@redhat.com>, <netdev@vger.kernel.org>,
        "Jesse Brandeburg" <jesse.brandeburg@intel.com>,
        Tony Nguyen <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        <intel-wired-lan@lists.osuosl.org>, <linux-kernel@vger.kernel.org>
References: <20231025103315.1149589-1-ivecera@redhat.com>
 <20231025103315.1149589-2-ivecera@redhat.com>
 <8a8f54a8-1a18-4797-a592-b57bc6fc45c1@intel.com>
 <ZTkHJ6IP4tj3EmCV@nanopsycho> <ZTkIH68kCzb+4VME@nanopsycho>
From:   Jacob Keller <jacob.e.keller@intel.com>
In-Reply-To: <ZTkIH68kCzb+4VME@nanopsycho>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?LzRMOUF4WUtBdlFXdmFBUmZyL2kzQ0ZwdU55OU1RLzJXRDE5T0xOT2ZOZ2NU?=
 =?utf-8?B?Nmxhd3RHM2s4ZmFNVkdtczR1UUNLaVkra3RnK0RNQWhuem1oYysydTV1V1ha?=
 =?utf-8?B?UUw1WnZkeTk1Nk5OcjM5WlV6T1ZWMWlvRDBpUkozRjBjVzdXSm1mNVkwTnJp?=
 =?utf-8?B?NXhQRHE4RlJ6dWFLa3FZcHZRSm1jdXIwUFBOR1dYWW14R25iRm9wQUJQZml1?=
 =?utf-8?B?ZGRkNnpsOHBTOURvTUxmeUVoY3NIY21FQW9mTDFjcDZKcjl6Z0d2ejNwUHFF?=
 =?utf-8?B?NEwzTld2R1pPUEsrcU53YmEzVk5WVU5YQmRlSjNVT3JxN1FvNTJTcU14V3lV?=
 =?utf-8?B?eG9MS2Z2M01UUGk1c2ZxZXU3WTdBYjdGVEhWK3ZMRitObm5lTzVzNDh1Wm12?=
 =?utf-8?B?WGdhNWR0OWlObEZhNjFhalowNEZqZVVjaXQzK2wvOG5teWoyL0ViK2NqOW1E?=
 =?utf-8?B?YWNobkhGY0lQWUp2TFdEb1FxUWo1dldLbzdtakxVclpmOUhVY3d4cmlCcGhu?=
 =?utf-8?B?VndaMVVueXNPTUxKWFIrVitaT1hBdHRYN2hnMndUR1hUQllyMW9rQy9yQnFw?=
 =?utf-8?B?RWtJbDdkZFdyRE1IOThnOEN0UmxwQWUvbDVvSWhUVjdtSzNYcDdRRkdyOUlr?=
 =?utf-8?B?Q0ZNbGZ0SDV5dHNsbWhsR2tEQmxFelpGK0FFc2NaS1QzUE1JODg1dnU3aXJs?=
 =?utf-8?B?bTZwbnJCS283b0hyVDh2WHZxR1VseTFtdld0cHVob1lwaklUNTI5NmxTNFR0?=
 =?utf-8?B?VDVlaGFNcFJZWmx1ZUdIbTc4dzFrSDhpRlIyNjZqMFl0Z1VYWm1COE01Z3dV?=
 =?utf-8?B?b2NlSXdrNFFEZkYyWEhRaXpqOUxlUTVIbmk1N2ZhMitOMFE5TWtMM2pGSXhU?=
 =?utf-8?B?UHI1ZXJ6cnJBZVVUbDI5MWpYTk1waW5ibGtUOHVJR3pPclZ4VU9hRklpVGpU?=
 =?utf-8?B?bWJ3U3o4QUJDQUlkNFNFTzUzS2NzRXVqb0NnUkVQYmJ4cHF6cGdFYlg5cWJl?=
 =?utf-8?B?NkpNcTNMV0NZNExVTHZiY3JKZEhmTE84T3ZnVkdnOTArK0lKZzVDTVB1OTY5?=
 =?utf-8?B?dWZTdW5ZdXEyRTMzQUdMd2V6OHpZdjQvdkI3QStGWmFXZGlpbGo0S3RvOG5G?=
 =?utf-8?B?N3NNNUZUdjVHM1VIb3VIL2VPU25EOWVZU2srMzBVTlBJNyt0ZklRQzREdUlV?=
 =?utf-8?B?MTd1ZklrcDFRejFnSmFUYjdubWU5RkZFaTdqMnB4SjQyUlY5TjJhMUlycTdP?=
 =?utf-8?B?ZmNHY25XaVRFVDBQZ2FLN2JBWUphcFhFVWY4eW5za0ZoNUh5QmVuTmd3OFd2?=
 =?utf-8?B?SUhQWnFtcENvK1hHbG0yM3VtcjJEWkpVOHlkd1p6Skt5eDNlckZEb1RXZ201?=
 =?utf-8?B?YWNmS01RSXFtcjk1ZEdKTGtWSkZocDZpQktoVHNpb2t0ZHBXdDk4cXIveEI2?=
 =?utf-8?B?NGZoYUhwZ1crMjRBZVFiQjFzdEVtOXk0emJrbnFIcUZTQ2NIaG5hTFpFc0VS?=
 =?utf-8?B?MXRXd2VYUUVyclVSU1Vqc3lTM2V4L2pZMTFiR0FYNVQ1OGZSNG4waVdXZ25q?=
 =?utf-8?B?TjY1a29EbzlFK3EvalVoSit5NUx0THd2cDNVQmEwQmlueU1NaC8xWEZ4SWlx?=
 =?utf-8?B?cFpTYUtKUHBiWGpHN0xjQmtqQTcyeEtBbm5SdGQvelJMVGdpZ3F2bCt2WVNa?=
 =?utf-8?B?MDJKUmJ0S3czN3FJNWhQZ29oeGg0VGhsK21adlpKSFdydW1mWTFSUW5DK2tC?=
 =?utf-8?B?M1IwQXNxQW16OTZralFoUjVOODFlSFVHWlZWZzh6L0FZckRzZGI3YjVsYk1j?=
 =?utf-8?B?aTdZK3FYcGxVdEFrSHBhUDNQRzI3dUw3enFwWlRPWEJDcW5OV0pGNnpZYUxy?=
 =?utf-8?B?UFBMUDZtNlBPMkExMmhZQjJrMzBYYi9Tcm1tclk1VGFveHFNbUxINzNINHg0?=
 =?utf-8?B?REd0UmZyNjVRVWs1OVM1ekpOOGFjVnVuV3podDF3R05NejBCL1lHNVVIendy?=
 =?utf-8?B?YlZHWlg1U08wNFRDNWpWa0p0c3hNWVdQTGZzOXNRdm16UzczRm5XTFlHdllp?=
 =?utf-8?B?dWtLMWhaWVVZOVBoMWtYa0JHVS8ycUQ2Wm9heUc2NkNPOVMxNm5uY0xWMEls?=
 =?utf-8?B?dmxtQUFMWmJWd1ZueTZKU3o1bWJJQitQQjlJRHRUQTZxemkwcFR5T05mRFBL?=
 =?utf-8?B?S0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: cff095cf-90e0-4380-46f7-08dbd5b94dea
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 00:20:05.6982
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CtBU8vlfocR5CxvD+CZ6Dkqpldr13iuW+WuHio09Lh2xCyA1sXk18FGHcuk5EEXFgYuryBuiTLNAwqUJY5H1JhAwzWJoN86raqHBAGLwh0Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB8333
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Wed, 25 Oct 2023 17:21:07 -0700 (PDT)


On 10/25/2023 5:20 AM, Jiri Pirko wrote:
> Wed, Oct 25, 2023 at 02:16:39PM CEST, jiri@resnulli.us wrote:
>> Wed, Oct 25, 2023 at 12:48:37PM CEST, wojciech.drewek@intel.com wrote:
>>>
>>>
>>> On 25.10.2023 12:33, Ivan Vecera wrote:
>>>> The i40e_hw.mac.type cannot to be equal to I40E_MAC_VF or
>>>> I40E_MAC_X722_VF so remove helper i40e_is_vf(), simplify
>>>> i40e_adminq_init_regs() and remove enums for these VF MAC types.
>>>>
>>>> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
>>>> ---
>>>>  drivers/net/ethernet/intel/i40e/i40e_adminq.c | 33 ++++++-------------
>>>>  drivers/net/ethernet/intel/i40e/i40e_type.h   |  8 -----
>>>>  2 files changed, 10 insertions(+), 31 deletions(-)
>>>>
>>>> diff --git a/drivers/net/ethernet/intel/i40e/i40e_adminq.c b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>> index 29fc46abf690..896c43905309 100644
>>>> --- a/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>> +++ b/drivers/net/ethernet/intel/i40e/i40e_adminq.c
>>>> @@ -17,29 +17,16 @@ static void i40e_resume_aq(struct i40e_hw *hw);
>>>>  static void i40e_adminq_init_regs(struct i40e_hw *hw)
>>>>  {
>>>>  	/* set head and tail registers in our local struct */
>>>> -	if (i40e_is_vf(hw)) {
>>>> -		hw->aq.asq.tail = I40E_VF_ATQT1;
>>>> -		hw->aq.asq.head = I40E_VF_ATQH1;
>>>> -		hw->aq.asq.len  = I40E_VF_ATQLEN1;
>>>> -		hw->aq.asq.bal  = I40E_VF_ATQBAL1;
>>>> -		hw->aq.asq.bah  = I40E_VF_ATQBAH1;
>>>> -		hw->aq.arq.tail = I40E_VF_ARQT1;
>>>> -		hw->aq.arq.head = I40E_VF_ARQH1;
>>>> -		hw->aq.arq.len  = I40E_VF_ARQLEN1;
>>>> -		hw->aq.arq.bal  = I40E_VF_ARQBAL1;
>>>> -		hw->aq.arq.bah  = I40E_VF_ARQBAH1;
>>>
>>> What about removing those I40E_VF_* defines?
>>> This is their only usage here, right?
>>
>> Wait, do you suggest to use the values directly? That would be
>> wild even for i40e :)
> 
> Ah, sec. This is duplicated in
> drivers/net/ethernet/intel/iavf/iavf_register.h. That confused me.
> 

Its possible the iAVF code could be cleaned up too... Historically the
i40e and i40evf duplicated quite some code.