Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp98492rdh; Wed, 25 Oct 2023 17:49:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE3favI+ezX3OkdHD9quSYi8jqvMDmCBL5jBvUHI2sXAyxCUn8pd9rHT+04LJWoXTYyG7Fm X-Received: by 2002:a67:ef1d:0:b0:44d:482a:5444 with SMTP id j29-20020a67ef1d000000b0044d482a5444mr16667363vsr.21.1698281384818; Wed, 25 Oct 2023 17:49:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698281384; cv=none; d=google.com; s=arc-20160816; b=Ii70DtxevaXI4FEdghHsCp3uBBvWvXaaRHM2CINM7oHYTGquqUu7zQLnTc4let9fog FyErNKZkzq5XkIZPqQkVHq/93ns4HWXowqz7D+B6FNosDKHh+McvwF0N27v8jNBqkzgE RnyfE84bRmI7sqBrbzolOjqoUac3ITSkkGNNSiMRdK6ljB0/NdsPTrGiKZgsWUEujIQt sMrcB3/VHztgh0MSWm53xI4VnJi+X9hvXxc/lH9pfeG+9SzJyizIvp2C0zWxQ+tJUv/d 8Xm5CvFvYoHzE4x+DAQg9bCKVeHhq272OSRtq3KjeHO1SC8+ue8qsATIiS4i3S62ySSj rgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=LbvC3Jr6GlBODTrG4s/DZw4mHWi0s4/azQU3339hmps=; fh=ws9tdfdDo3u2vXenRBhjgGUsTEvsfkTsPWmz6rHUJho=; b=q/YBI46WlI2Wq5XVVjxTth3hFht3H0cnkE2TvePfmrQLGMUIGe/37FkGKS19c1XW6H X2lfHs0nG4UmP8w1ncd9/NzeAQd0uV8XlhaCv5kA6vwlLYyW+XMUfsdV+WRtHmI2vb5f 3oSyyESQLuw2JbS8iVbPyO5Y3jz3cwRGm266W8/1mIfKrgWFO/xl8LrBofGTmAv9OUL5 p0Xi6rM7f6qf1+Ut0Yty3yf7lPh4uVqekPQ71oOw1WMloMfUWq+QnJZVpPWpQUQ29Xq6 fFoE/ZxwVAvS2yHbRKtBa1tL13l3jIu0IQbAAzHXJU/OqN1ZaVbWrpKpsUH1Yyste6yQ 2hgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BFUDTZUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id k2-20020a056902070200b00d7e3d3d586csi17156862ybt.267.2023.10.25.17.49.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 17:49:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=BFUDTZUX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 39F6D81D2703; Wed, 25 Oct 2023 17:49:42 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231232AbjJZAsU (ORCPT + 99 others); Wed, 25 Oct 2023 20:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54042 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229877AbjJZAsS (ORCPT ); Wed, 25 Oct 2023 20:48:18 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77365132; Wed, 25 Oct 2023 17:48:16 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id d75a77b69052e-41cd1fe4645so2430491cf.0; Wed, 25 Oct 2023 17:48:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698281295; x=1698886095; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=LbvC3Jr6GlBODTrG4s/DZw4mHWi0s4/azQU3339hmps=; b=BFUDTZUXwX4W9xjfJUdy61TiKqPCLJSqofh2NEiG4SnqgvFQTFt/VnkN3VRvnN22mI p03lnj/8EAuD9JjEJNeuJisFPVO3zObwsiFdPT4IBxgIAkho6F7PcTylBX79ncqzDCq/ kI62lghnJJ+g9VfMeDrk011N8VvXb4KzvtP/Vk7AA4WL+YYdPBC1ixBKv3h3wijeEsCI +d3PxDsDHbFsH/fft2+LX/iCVZeoXAPbMlTmE1TW+mAUXe5ahZIcxnRFKnKSi3YxEZfL Ru2b9n5vWyoW5SLyi+fLKCobrt8Ux5i/zhPF0j+dAgeqkDfYYgboJ8OwILhtaVm7j+bp 26gQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698281295; x=1698886095; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LbvC3Jr6GlBODTrG4s/DZw4mHWi0s4/azQU3339hmps=; b=CVEvRQ+t/3Sdl5qWFPozQCKUbIOG/4R1OeCl1egFVYe/85UTqutp6AQBC5zHzP5Cpp qhVCYmTUx3tgmx2mehRFOmhghQyKxRj01v5wDwla5Y1Lhtb3DvvQ/CDKpz7fZOyuE2a7 1C6xv95RKBUXQ2hfuH/IOuQ2Sq+3iwSg42I8tJqFyn0UiesACzO9cGzsWOVwl3H9IyZh pFO0sMyQZjEtpfDtnKJrO8Tq/3AN859+CWn9UTWM7rTRn/4Ncn6G7RMeyhsk0XLCkip8 RzWzTvr/rOKMS29SOrieqz4UR9BlGu4O9dGDHLCrLjh8UtbidoKAoohTM+9P+IlBk/8D N/yA== X-Gm-Message-State: AOJu0Yyq/leW3rp60R+DXcubKi/wbYgAHSXN1gx/c5NthNqwS3FCwTlg 2BxKLHgfD+WYblZRUvIZZJSmsNGAQa8= X-Received: by 2002:ac8:7e8a:0:b0:418:1b8f:4cde with SMTP id w10-20020ac87e8a000000b004181b8f4cdemr23683078qtj.45.1698281295449; Wed, 25 Oct 2023 17:48:15 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m124-20020a0de382000000b0059b2be24f88sm5448010ywe.143.2023.10.25.17.48.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 17:48:15 -0700 (PDT) Sender: Guenter Roeck Date: Wed, 25 Oct 2023 17:48:13 -0700 From: Guenter Roeck To: Lakshmi Yadlapati Cc: joel@jms.id.au, andrew@aj.id.au, eajames@linux.ibm.com, ninad@linux.ibm.com, jdelvare@suse.com, linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] hwmon: (pmbus/max31785) Add delay between bus accesses Message-ID: References: <20231023180804.3068154-1-lakshmiy@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023180804.3068154-1-lakshmiy@us.ibm.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 17:49:42 -0700 (PDT) On Mon, Oct 23, 2023 at 01:08:03PM -0500, Lakshmi Yadlapati wrote: > Changes since V1: > 1. Changed the max31785_wait macro to a function, following the conventions > used in other drivers that had the same issue. > 2. Changed the function names from max31785_i2c_smbus* to max31785_i2c_* and > from max31785_pmbus_* to _max31785_*, making them more concise. > Please check Documentation/process/submitting-patches.rst for the expected patch format, specifically details on how description and change log are supposed to look like. Guenter