Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp106920rdh; Wed, 25 Oct 2023 18:10:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG5n6SgwT0EsUzd/V/ZsMw6SaVGhQ6/dXj7rYYy2ZcziETYwgT9xt05SU1sAKAu+Ibn3ByR X-Received: by 2002:a81:8341:0:b0:5a7:bbd1:ec1d with SMTP id t62-20020a818341000000b005a7bbd1ec1dmr18044127ywf.17.1698282631983; Wed, 25 Oct 2023 18:10:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698282631; cv=none; d=google.com; s=arc-20160816; b=pI9ACLuv/eY8/uWwcrxLRW1R/HrCvjWyH77MYtxluAQRxy+5mxfC1BELl43hQ+loJJ +Q5vTBJwfwIH8hYeKHnqYy/X6DHCj3iRtxMa3R0QJKvV3EPTCoNZHj10/14e8DeYtKUc fYgp8/r7SjZM0Uk3RGk1e78x0Z6Vv1c7BtDRytZ9g0nGhK+oqBD64kW7fc48rJIcOvD3 Kc04gH1Eawgi6+fSWKfRY/Lcfhi5OfWFFkxKGz/rYYGM58w8vCWlhwUyP4brDVjYeXkr YaHMvPgY+srJp7zwVYhj3aFI5NyuZFrHiCvD0bWm08w5Bz9lN4AZnzAsQIECwY/c1ZfZ TBVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:dkim-signature; bh=DyTK0dPzGluAcQuuHIU80+KHFmV8NJJH2jk5jCqZTKI=; fh=/T5Qkv9WI0AN3zFPS9T++sBvQ1rzQZFolOIqcUlv5us=; b=Q3VtLNBGd14ZPb3FZHXK1a9l5QMmWZnlYF3rUyUC+mjIw5nBjQhfiRb3lSgYDR4Wfv h0TTLSLSr6lzksdtEjcjgw+DC3+Od0CjuedOfCd5Xq4BKKO56p+WBaqsqJ29C+UySRVl NjCHzF5C4uo6/7sFgIjRQiWywa9V18AaoAcCnHvjXX6lRT37ckK91iBoJJpxc1fGnLIc snB/Q4xk7svmXkRSH0ZomapFPNnhZfSGM4WwTEbKeCcu5I2y8/C4Z189eoV73c5xDS3X 5FdA+OTX0zQT1a+5QZTKYJRn1v2dZDA3IpYLRJE+C52CSC90QWaj62qgChxLJ+kS/wd1 9hMw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=minly+N+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id y125-20020a81a183000000b0059bce05d922si12975858ywg.84.2023.10.25.18.10.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 18:10:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20230601 header.b=minly+N+; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 9C19E81E9F47; Wed, 25 Oct 2023 18:10:29 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230372AbjJZBKR (ORCPT + 99 others); Wed, 25 Oct 2023 21:10:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229638AbjJZBKQ (ORCPT ); Wed, 25 Oct 2023 21:10:16 -0400 Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D544ECC for ; Wed, 25 Oct 2023 18:10:14 -0700 (PDT) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d9cb79eb417so290327276.2 for ; Wed, 25 Oct 2023 18:10:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1698282614; x=1698887414; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=DyTK0dPzGluAcQuuHIU80+KHFmV8NJJH2jk5jCqZTKI=; b=minly+N+qkV7I0IFo1WfqDNN0b12/zoxtsjCi3i6hlmXXkujg4SMjup3ho6bYrIAH6 cSsoKJER8wdF2FjpNJfokvS3eIc130UoyLxd1lUlvChfvU2Hwhn6Y5uauUQXxoDZYfbU 9eXxB38+PtUIjZRnZFehDwv5CCHShAw2VB1SOfr0cdUCxJkE2uYAvl9BBwVErKhvuLET 8cHANFe08OCTpJT0Bw8GsdmG4P9toEFRkEDm6wekUziD4VqadzT5YCT9ILIqU22VJRS0 wGmzJSigCI7nyraH7GRd9GrYdZS+Dwn7qB21zhiVdj7CO5MdVaCZ18L5E319Jm0DbXef TTnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698282614; x=1698887414; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DyTK0dPzGluAcQuuHIU80+KHFmV8NJJH2jk5jCqZTKI=; b=fbLBjv16WMGzfafoE7w3nxG4Rb051+sOullNOq5+hDvdmjytwdmPnndIDBxExjfUd+ tmJVHvkl7n/mvNTM+9Ks4i3TlgYrXhn1etNCQlwUoKkAuk2QYRDNTdgRySrvt2b4Wh6u zqJdkyjJbXYysUeEHYSt580tGE7ASKHHlUtyAtJ/2k2J7U5FgYVFfTYfdbOr4nGymdMl AvvvLBV5IVzvRO5+8tWxk1vlu6AugEuDaCSTjoxf4hp9gjlrkf/AwNP7xBexXvMW6hVp ZdOnTwaCuSrckQBFUK+3V1Y07XjfArkupyUG7AgXUjU4jtu+sYDXGTyr2iyg1741eYwJ 8xuw== X-Gm-Message-State: AOJu0YxrI6eDcnSqoj3qEyAlcN9+UW0Vrhvp+cqUYoNYgXYQQHxAbFN2 RCBsZAxSPku4p755iUhKOpu/cSJKMXw= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:1083:b0:d9a:6007:223a with SMTP id v3-20020a056902108300b00d9a6007223amr473790ybu.8.1698282613921; Wed, 25 Oct 2023 18:10:13 -0700 (PDT) Date: Wed, 25 Oct 2023 18:10:12 -0700 In-Reply-To: Mime-Version: 1.0 References: <20231007064019.17472-1-likexu@tencent.com> <53d7caba-8b00-42ab-849a-d8c8d94aea37@gmail.com> Message-ID: Subject: Re: [PATCH] KVM: x86/xsave: Remove 'return void' expression for 'void function' From: Sean Christopherson To: Like Xu Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Maxim Levitsky Content-Type: text/plain; charset="us-ascii" X-Spam-Status: No, score=-8.4 required=5.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Wed, 25 Oct 2023 18:10:29 -0700 (PDT) On Wed, Oct 25, 2023, Sean Christopherson wrote: > On Wed, Oct 25, 2023, Like Xu wrote: > > Emm, did we miss this little fix ? > > No, I have it earmarked, it's just not a priority because it doesn't truly fix > anything. Though I suppose it probably makes to apply it for 6.8, waiting one > more day to send PULL requests to Paolo isn't a problem. Heh, when I tried to apply this I got reminded of why I held it for later. I want to apply it to kvm-x86/misc, but that's based on ~6.6-rc2 (plus a few KVM patches), i.e. doesn't have the "buggy" commit. I don't want to rebase "misc", nor do I want to create a branch and PULL request for a single trivial commit. So for logistical reasons, I'm not going apply this right away, but I will make sure it gets into v6.7.