Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
MIME-Version: 1.0
References: <20231023131550.487760-1-james.clark@arm.com>
In-Reply-To: <20231023131550.487760-1-james.clark@arm.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 25 Oct 2023 21:14:05 -0700
Message-ID: <CAP-5=fW3k19j4aSGXBEzCE24c4+CvhLqA4MZ_F+etgtqjAWFug@mail.gmail.com>
Subject: Re: [PATCH] perf tests: test_arm_coresight: Simplify source iteration
To:     James Clark <james.clark@arm.com>
Cc:     linux-perf-users@vger.kernel.org, coresight@lists.linaro.org,
        suzuki.poulose@arm.com, atrajeev@linux.vnet.ibm.com,
        tianruidong@linux.alibaba.com, linux-kernel@vger.kernel.org,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        Kajol Jain <kjain@linux.ibm.com>,
        Tiezhu Yang <yangtiezhu@loongson.cn>,
        Anushree Mathur <anushree.mathur@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Oct 23, 2023 at 6:17=E2=80=AFAM James Clark <james.clark@arm.com> w=
rote:
>
> There are two reasons to do this, firstly there is a shellcheck warning
> in cs_etm_dev_name(), which can be completely deleted. And secondly the
> current iteration method doesn't support systems with both ETE and ETM
> because it picks one or the other. There isn't a known system with this
> configuration, but it could happen in the future.
>
> Iterating over all the sources for each CPU can be done by going through
> /sys/bus/event_source/devices/cs_etm/cpu* and following the symlink back
> to the Coresight device in /sys/bus/coresight/devices. This will work
> whether the device is ETE, ETM or any future name, and is much simpler
> and doesn't require any hard coded version numbers
>
> Suggested-by: Suzuki K Poulose <suzuki.poulose@arm.com>
> Signed-off-by: James Clark <james.clark@arm.com>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>
> This was discussed here previously:
> https://lore.kernel.org/all/20230929041133.95355-2-atrajeev@linux.vnet.ib=
m.com/
>
> I chose not to add a fixes tag like the original because shellcheck
> isn't part of the build so it doesn't really fix any real issue yet and
> is just a refactor.
>
>  tools/perf/tests/shell/test_arm_coresight.sh | 17 +++--------------
>  1 file changed, 3 insertions(+), 14 deletions(-)
>
> diff --git a/tools/perf/tests/shell/test_arm_coresight.sh b/tools/perf/te=
sts/shell/test_arm_coresight.sh
> index fe78c4626e45..65dd85207125 100755
> --- a/tools/perf/tests/shell/test_arm_coresight.sh
> +++ b/tools/perf/tests/shell/test_arm_coresight.sh
> @@ -11,19 +11,6 @@
>
>  glb_err=3D0
>
> -cs_etm_dev_name() {
> -       cs_etm_path=3D$(find  /sys/bus/event_source/devices/cs_etm/ -name=
 cpu* -print -quit)
> -       trcdevarch=3D$(cat ${cs_etm_path}/mgmt/trcdevarch)
> -       archhver=3D$((($trcdevarch >> 12) & 0xf))
> -       archpart=3D$(($trcdevarch & 0xfff))
> -
> -       if [ $archhver -eq 5 -a "$(printf "0x%X\n" $archpart)" =3D "0xA13=
" ] ; then
> -               echo "ete"
> -       else
> -               echo "etm"
> -       fi
> -}
> -
>  skip_if_no_cs_etm_event() {
>         perf list | grep -q 'cs_etm//' && return 0
>
> @@ -149,7 +136,9 @@ arm_cs_iterate_devices() {
>
>  arm_cs_etm_traverse_path_test() {
>         # Iterate for every ETM device
> -       for dev in /sys/bus/coresight/devices/$(cs_etm_dev_name)*; do
> +       for dev in /sys/bus/event_source/devices/cs_etm/cpu*; do
> +               # Canonicalize the path
> +               dev=3D`readlink -f $dev`
>
>                 # Find the ETM device belonging to which CPU
>                 cpu=3D`cat $dev/cpu`
> --
> 2.34.1
>