Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
MIME-Version: 1.0
References: <20230926205948.1399594-1-irogers@google.com> <8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.intel.com>
 <CAP-5=fWk12jKjVmV+aJ_U5A=ao7L1ha-wOHaM+ytO9oF0nP9zA@mail.gmail.com> <CAP-5=fURbve928P5CGi-dQ7Y8mZhxRmi9wucFc_gP+aDGMftYw@mail.gmail.com>
In-Reply-To: <CAP-5=fURbve928P5CGi-dQ7Y8mZhxRmi9wucFc_gP+aDGMftYw@mail.gmail.com>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 25 Oct 2023 21:19:58 -0700
Message-ID: <CAP-5=fU5W=97NFvL1yUKw+rrbBrcd8c-S_y3=86SYv+pszNjmQ@mail.gmail.com>
Subject: Re: [PATCH v2 1/3] perf vendor events intel: Fix broadwellde
 tma_info_system_dram_bw_use metric
To:     Namhyung Kim <namhyung@kernel.org>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc:     "Liang, Kan" <kan.liang@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Adrian Hunter <adrian.hunter@intel.com>,
        linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
        Perry Taylor <perry.taylor@intel.com>,
        Caleb Biggers <caleb.biggers@intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, Oct 25, 2023 at 2:56=E2=80=AFPM Ian Rogers <irogers@google.com> wro=
te:
>
> On Thu, Oct 5, 2023 at 3:16=E2=80=AFPM Ian Rogers <irogers@google.com> wr=
ote:
> >
> > On Wed, Sep 27, 2023 at 6:47=E2=80=AFAM Liang, Kan <kan.liang@linux.int=
el.com> wrote:
> > >
> > >
> > >
> > > On 2023-09-26 4:59 p.m., Ian Rogers wrote:
> > > > Broadwell-de has a consumer core and server uncore. The uncore_arb =
PMU
> > > > isn't present and the broadwellx style cbox PMU should be used
> > > > instead. Fix the tma_info_system_dram_bw_use metric to use the serv=
er
> > > > metric rather than client.
> > > >
> > > > The associated converter script fix is in:
> > > > https://github.com/intel/perfmon/pull/111
> > > >
> > > > Fixes: 7d124303d620 ("perf vendor events intel: Update broadwell va=
riant events/metrics")
> > > > Signed-off-by: Ian Rogers <irogers@google.com>
> > > > ---
> > >
> > > Thanks Ian. The whole patch series looks good to me.
> > >
> > > Reviewed-by: Kan Liang <kan.liang@linux.intel.com>
> >
> > Would be good to pick this up in perf-tools-next.
> >
> > Thanks,
> > Ian
>
> Ping.

Thanks Namhyung for picking this up. There were two other patches in
the v2 patch set that Kan reviewed:
https://lore.kernel.org/all/8a6b9556-c82c-4253-a4c1-74d696ad26df@linux.inte=
l.com/
that I don't see in perf-tools-next.

Ian

> Thanks,
> Ian
>
> > > Thanks,
> > > Kan
> > >
> > > >  tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json | 2 =
+-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metri=
cs.json b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json
> > > > index 8fc62b8f667d..d0ef46c9bb61 100644
> > > > --- a/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json
> > > > +++ b/tools/perf/pmu-events/arch/x86/broadwellde/bdwde-metrics.json
> > > > @@ -652,7 +652,7 @@
> > > >      },
> > > >      {
> > > >          "BriefDescription": "Average external Memory Bandwidth Use=
 for reads and writes [GB / sec]",
> > > > -        "MetricExpr": "64 * (arb@event\\=3D0x81\\,umask\\=3D0x1@ +=
 arb@event\\=3D0x84\\,umask\\=3D0x1@) / 1e6 / duration_time / 1e3",
> > > > +        "MetricExpr": "64 * (UNC_M_CAS_COUNT.RD + UNC_M_CAS_COUNT.=
WR) / 1e9 / duration_time",
> > > >          "MetricGroup": "HPC;Mem;MemoryBW;SoC;tma_issueBW",
> > > >          "MetricName": "tma_info_system_dram_bw_use",
> > > >          "PublicDescription": "Average external Memory Bandwidth Us=
e for reads and writes [GB / sec]. Related metrics: tma_fb_full, tma_mem_ba=
ndwidth, tma_sq_full"