Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp178386rdh; Wed, 25 Oct 2023 21:38:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHNRjZDEk+kT+Tp7GRWHxpmTArBl9aOyCWtRaSgYUogPHpuLplTbrgeU3DyoaW9YJdir+l X-Received: by 2002:a25:ac07:0:b0:d9b:d0cb:db74 with SMTP id w7-20020a25ac07000000b00d9bd0cbdb74mr17506316ybi.33.1698295133863; Wed, 25 Oct 2023 21:38:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698295133; cv=none; d=google.com; s=arc-20160816; b=JdcM0ud/feWTqcSutxz3hh7UAeZ7t7e34F6EFcrau8LFUUrb/cR7JvGDTPOzfkkI4p mzpKgNRfJosfPOJx4irXoio3fv4196IQXHHFZdYQyZFQeK4uonFs290L0L/3kh4qVBpP 2w/twqsvH5z281D/0a4kucKH2CXLNe2k9amyBXoLqt2pcrDtsZeuJdZf/0PHAoIMfK5v gJ5t80d8O4vgvZt93g7kZ+fOK0R5wXc1Y+JWYHTHGRFK4GqpUjNxO7oOjfZBrswwM+wW Qn9IPSck36Xx4KM+GtU8ENuyBkYhdZdomMu/wuirL2DlJSm8do0LMqMTsMTtlk0dULVL nbCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=VQfPVTlNxNs5d5jXM9r1QgUiEU5LPOzadsgQUw42pws=; fh=gJrorOl/1YrYuR2h+EU6Al32lkbPFTKx0S3JNDLZhEs=; b=G/u+xjRYT4FHHjv5T7h3q1lflpS4p1xT4nGyrjlqLoq+GUe9JokkQiMwIEODpQ3c+a 8xBHV1QAHcqiq0bvNWQCqLp0YkCx0mxxcwGlbaemsXWslkImwTlASsbKhLrVESNTlV1y P6HPQ8uisGA/X82xHgArN4dMRu8EIJWhZDqYfBwo06cS7xQk0bCuUzbfvRODM5ltvjdO a8tLOKZ0SqX7YdJc/SK2QUsZ8pOs8HkAMu9v/t5o/ELIJPDk2WHKJPnEOO/+rNS7RPyo RvefR8MZeX/hnFR7PSw8iFAbP9GaVdyhQfQiK1tTg/kLPuQi1g8aPDdjFkD8k080kZB7 cMsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SrmRGDX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id l62-20020a25cc41000000b00d9ac2049cf0si14892899ybf.377.2023.10.25.21.38.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 21:38:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=SrmRGDX7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 9FBB98080D46; Wed, 25 Oct 2023 21:38:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229954AbjJZEhw (ORCPT + 99 others); Thu, 26 Oct 2023 00:37:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37616 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229554AbjJZEhu (ORCPT ); Thu, 26 Oct 2023 00:37:50 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BFD1186; Wed, 25 Oct 2023 21:37:48 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-5a7c08b7744so3541747b3.3; Wed, 25 Oct 2023 21:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698295067; x=1698899867; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VQfPVTlNxNs5d5jXM9r1QgUiEU5LPOzadsgQUw42pws=; b=SrmRGDX76S4eqY/cRYUq+j0/xYZNR5I4a2AO2d8Nt82dr03fAaYE0BtVYIWvNlHZ5o xpBKmAH3HR21DPQwEAy0WcwO95GSoQYBGqlwUiyiJqL2+3qpewWfuBDqrjeC6xf9o5Jo cL+HIRcF1hqvNwQhG11AMZP0oKrOZs3iIzSaCb/KXYVcvmVa8q+qSm008JLBcI7OZEX4 1+BAt5uDD25sUsWeSbcI8fwiOnDok6oNPM+OD5i5kfmFi/5nnEugTq4w4w+9AjPw1/pM tMpQhMvn0UPLVyNyUygAE/7ST3szUVVVgzkYRU+Fz9DDU3lri7w9wzSdehXqddQ7oWPV YhvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698295067; x=1698899867; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VQfPVTlNxNs5d5jXM9r1QgUiEU5LPOzadsgQUw42pws=; b=Ds1B2GpeO5vF9S/JaNDg0CEhKOhHFxUEcbpLINd8+HKeQMRGN4Y3IUpV8lE96Z7nsm aJXZlTRs77c86e8ih5NqhyhnxWCyz26e9+18/vb3L1XXGMjscOm+cQrvs/0LDWImbcNi 55N6BzZvoWqhC8MaI9F4OXguWcSMxTsRfyq5rChOqPoERMS5+fLsSxDguUun/6yowBOB uD1zMily4Rsc+ySMpzsifiGmwFknTQY5WtJi3z/I8Fbq7p8dN4sMvMy5EL2Bzel2H7Oe d4VBvnSBhlboeWXm8sgPxacrWsnbyAaQdSb9WYlx21hZxc5rY6+PuuhVsAfXTSAJL2Jr JLZw== X-Gm-Message-State: AOJu0Ywfuv/n1/Gvy0D4j14jCTPvbcGf4wfhYQgXl2yNgvR0CXvAa8ic Z1PUHFdKoeo6UYcW1Vkvrx0= X-Received: by 2002:a0d:d810:0:b0:5a7:cfdc:d7b1 with SMTP id a16-20020a0dd810000000b005a7cfdcd7b1mr19298114ywe.4.1698295067160; Wed, 25 Oct 2023 21:37:47 -0700 (PDT) Received: from ?IPV6:2600:1700:6cf8:1240:8355:61d5:b55:33e7? ([2600:1700:6cf8:1240:8355:61d5:b55:33e7]) by smtp.gmail.com with ESMTPSA id s13-20020a81bf4d000000b005a7fbac4ff0sm5638687ywk.110.2023.10.25.21.37.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Oct 2023 21:37:46 -0700 (PDT) Message-ID: <563d1ae7-8d1f-48d5-b742-989ce482c4f1@gmail.com> Date: Wed, 25 Oct 2023 21:37:44 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH bpf-next v2 0/2] selftests/bpf: Replaces CHECK macros and adds malloc failure checks to bpf_iter Content-Language: en-US To: Yuran Pereira , bpf@vger.kernel.org, yonghong.song@linux.dev Cc: shuah@kernel.org, ast@kernel.org, daniel@iogearbox.net, song@kernel.org, john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com, haoluo@google.com, jolsa@kernel.org, mykolal@fb.com, brauner@kernel.org, iii@linux.ibm.com, kuifeng@meta.com, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: From: Kui-Feng Lee In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 25 Oct 2023 21:38:22 -0700 (PDT) On 10/25/23 19:03, Yuran Pereira wrote: > This patch series contains the following updates: > - Replaces the usage of all the CHECK macros in bpf_iter > to the appropriate ASSERT_* macro calls > - Adds appropriate malloc failure checks to bpf_iter > > Changes in v2: > - Removed unused "duration" variable which caused compilation error > as reported by Yonghong Song [1] > - Improved malloc failure handling as suggested by Kui-Feng Lee [2] > - Ensured propper patch formatting (i.e. sending it as a set instead > of two distinct patches) > > [1] https://lore.kernel.org/lkml/3531360b-c933-4c5f-a84c-17edf0592519@linux.dev/ > [2] https://lore.kernel.org/lkml/7d703c4c-1a24-4806-a483-c02efb666059@gmail.com > > > Previous version: > v1 - https://lore.kernel.org/lkml/DB3PR10MB683589A5F705C6CA5BE0D325E8DFA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > - https://lore.kernel.org/lkml/DB3PR10MB68356D7CDF6005480BE5876CE8DEA@DB3PR10MB6835.EURPRD10.PROD.OUTLOOK.COM > > Yuran Pereira (2): > selftests/bpf: Convert CHECK macros to ASSERT_* macros in bpf_iter > selftests/bpf: Add malloc failure checks in bpf_iter > > .../selftests/bpf/prog_tests/bpf_iter.c | 88 +++++++++---------- > 1 file changed, 44 insertions(+), 44 deletions(-) > For the cover letter, you can just put it at the same directory of patch 1 and 2 and sent them with "git send-email" at once. All of them will be in the same thread. "git format-patch --cover-letter ..." will generate a template of the cover letter along with patches. FYI