Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <8148dae9-e3fc-4589-ba57-a3f7a3e63b80@intel.com>
Date:   Thu, 26 Oct 2023 10:03:49 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mmc: sdhci_am654: fix start loop index for TAP value
 parsing
Content-Language: en-US
From:   Adrian Hunter <adrian.hunter@intel.com>
To:     Nitin Yadav <n-yadav@ti.com>, ulf.hansson@linaro.org
Cc:     linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20231026061458.1116276-1-n-yadav@ti.com>
 <8b7f948d-316c-4135-875a-de455ff4849c@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki
In-Reply-To: <8b7f948d-316c-4135-875a-de455ff4849c@intel.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 26/10/23 10:00, Adrian Hunter wrote:
> On 26/10/23 09:14, Nitin Yadav wrote:
>> ti,otap-del-sel-legacy/ti,itap-del-sel-legacy passed from DT
>> are currently ignored for all SD/MMC and eMMC modes. Fix this
>> by making start loop index to MMC_TIMING_LEGACY.
>>
>> Fixes: 8ee5fc0e0b3be ("mmc: sdhci_am654: Update OTAPDLY writes")
>>
> 
> There isn't usually a blank line here
> 
> Perhaps a Cc: stable@vger.kernel.org tag?
> 
>> Signed-off-by: Nitin Yadav <n-yadav@ti.com>
> 
> Nevertheless:
> 
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>

Sorry, sent that prematurely - see comment below

> 
> 
>> ---
>>  drivers/mmc/host/sdhci_am654.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c
>> index 544aaaf5cb0f..aae9d255c6a1 100644
>> --- a/drivers/mmc/host/sdhci_am654.c
>> +++ b/drivers/mmc/host/sdhci_am654.c
>> @@ -606,7 +606,7 @@ static int sdhci_am654_get_otap_delay(struct sdhci_host *host,
>>  		return 0;
>>  	}
>>  

Isn't the MMC_TIMING_LEGACY information read at the top of
sdhci_am654_get_otap_delay()?

>> -	for (i = MMC_TIMING_MMC_HS; i <= MMC_TIMING_MMC_HS400; i++) {
>> +	for (i = MMC_TIMING_LEGACY; i <= MMC_TIMING_MMC_HS400; i++) {
>>  
>>  		ret = device_property_read_u32(dev, td[i].otap_binding,
>>  					       &sdhci_am654->otap_del_sel[i]);
>