Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp235725rdh; Thu, 26 Oct 2023 00:06:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnqivhMzqGYEML8WTNzn3C6v/t3wIug0Y6ZGDbxjZNcJdNBpep1ykyj60goHvpgTWtg8Na X-Received: by 2002:a05:6902:1083:b0:d8b:1407:f61d with SMTP id v3-20020a056902108300b00d8b1407f61dmr20449838ybu.26.1698304018623; Thu, 26 Oct 2023 00:06:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698304018; cv=none; d=google.com; s=arc-20160816; b=I2KB6kt/NMexzkvS7MRcDnicGShE3Xi3z0kdRMQ79YWLxtZnyL6ckRkt9PnrP5MvQ0 d2/1/CRe4ooHz4rjim+WyCYVT5OMlk6ur651CJQAtZL5Ohhg51zdoGZbemcmmdH+XaF/ DFbRW3aB0x7FD5Iv/eO35o7FvpGv/D9hFqX+Ih7nWy6QWygT0p7EC3SulzYlfy7z7o1l xHhZ+I7UblcxfrqoXxCJMjaI9xE8nN/S924Ym35wShNTmipXAFqqW/GHukzNjuWsEhXI rOmesc3h+tGgzs9BhmxmRIk/pUN+u9BT5jh9qxHGX8Z0F6u8rD6vF5lDepZErB7oUbFz 2E2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; fh=MACNm/hKd64puopOfXkZGQVej07DsewSqn2127vY9SQ=; b=lwzm1k4Y+WUBqUYt25iGeTPEbqrkiVP75ZBwd1sWMpLxXvfkb8zfgLL6KC/M53d+PZ L6lIv78/BDtLqyRZVLVOhn6hfkMAJHrUvY/kkXSrqMdiqLyFLSa0iFYhwAgflNgostOi u3P6IqgSBMt8cohA3nfL3zTKKCqwDUUYTIHCWDQPb+Kpe/J4wZpWRh5P9zje5CHxAj9X TiXt3CU4dTYix5lKUF4/tCt2LEwjuiqKEybEachO9HaaJzLDX/P8dv279lWFWlau5oU9 wpIWxEK0k3hqpdy+CXLabKh/yif7EqE4EJ+8KzMIjE12zQkSwo4bWWL2D5HPP/zvadNu SL7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="ixD/WJ73"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id y197-20020a25dcce000000b00d9a5b63cdecsi14187362ybe.105.2023.10.26.00.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 00:06:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b="ixD/WJ73"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id BE9A181A7D2C; Thu, 26 Oct 2023 00:06:55 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230029AbjJZHGt (ORCPT + 99 others); Thu, 26 Oct 2023 03:06:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229647AbjJZHGr (ORCPT ); Thu, 26 Oct 2023 03:06:47 -0400 Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81A16129 for ; Thu, 26 Oct 2023 00:06:45 -0700 (PDT) Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1cac925732fso4354315ad.1 for ; Thu, 26 Oct 2023 00:06:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1698304005; x=1698908805; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; b=ixD/WJ73VL6PzyLB/IeIZWO1I9/G+Noqw7o0qSb8dcA0Nt3efnXSui475gBT0UvSc2 gPcSUfClpcbfvc0BD8ulupLMsglO3uf7mG8Y/19c09D7YnO3GGrGgWqZD5+oH/0SL1yO tVhcv6pe3gFAFHquCtVcNL/bagRgHUnAsjWPs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698304005; x=1698908805; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wMNJftQVf2QXKCuFxZZxgj6EiiH5We62gPsWdhpccM8=; b=oq1ScnzjijLgD1YR76YNyz600BfTH7Cq4pvIaIeyoGqy3dJ9t9afmdRYXrvxoc+wq3 pR1a+p2xHlqIyKQqf+WmKgzuVX4ZiR0ScF0Dn0HM1x9L+/9DDgmYUQAXfnkxDRv+riiY wG0ayIy31s4Uh5RlyUS+wGcL30WQCCbaMrtUZlQKWdLxLihI60gxwCvHjGXt4l3Iij72 1xm3v+wV3G/heIhhaen9zt+q/rr0PtgPpAb7XoBFe9uGipvSDNV8IvYSZCw+BDDl/L4H d9PVrjFWhg/v0QC/XPkxb2717TniEfQtdnsBcoSPLGeIxmQ8gMtkz1lybBOeWpxcrmxe guqA== X-Gm-Message-State: AOJu0YxeneLVZplw1ZRgALoCiuUZtTIp9Rtu9m125+jAfZikpBNyj3xk Ur7RPFi1LOdFJ7R6itrXQJW8Fg== X-Received: by 2002:a17:903:110d:b0:1c9:e508:ad43 with SMTP id n13-20020a170903110d00b001c9e508ad43mr17082989plh.8.1698304004990; Thu, 26 Oct 2023 00:06:44 -0700 (PDT) Received: from google.com ([2401:fa00:8f:203:f228:3a07:1e7f:b38f]) by smtp.gmail.com with ESMTPSA id f11-20020a170902ce8b00b001c5076ae6absm10295706plg.126.2023.10.26.00.06.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 00:06:44 -0700 (PDT) Date: Thu, 26 Oct 2023 16:06:39 +0900 From: Sergey Senozhatsky To: Nhat Pham Cc: akpm@linux-foundation.org, hannes@cmpxchg.org, cerasuolodomenico@gmail.com, yosryahmed@google.com, sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, mhocko@kernel.org, roman.gushchin@linux.dev, shakeelb@google.com, muchun.song@linux.dev, linux-mm@kvack.org, kernel-team@meta.com, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH] zswap: export compression failure stats Message-ID: <20231026070639.GB15694@google.com> References: <20231024234509.2680539-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231024234509.2680539-1-nphamcs@gmail.com> X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Thu, 26 Oct 2023 00:06:56 -0700 (PDT) On (23/10/24 16:45), Nhat Pham wrote: > > During a zswap store attempt, the compression algorithm could fail (for > e.g due to the page containing incompressible random data). This is not > tracked in any of existing zswap counters, making it hard to monitor for > and investigate. We have run into this problem several times in our > internal investigations on zswap store failures. > > This patch adds a dedicated debugfs counter for compression algorithm > failures. > > Signed-off-by: Nhat Pham FWIW, Reviewed-by: Sergey Senozhatsky