Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6;
Date:   Thu, 26 Oct 2023 10:09:12 +0300
From:   Dan Carpenter <dan.carpenter@linaro.org>
To:     Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/10] staging: rtl8192e: Convert array rx_idx[] to
 variable rx_idx
Message-ID: <008844f2-4cc6-46ee-be7c-50446ef11290@kadam.mountain>
References: <cover.1698295861.git.philipp.g.hortmann@gmail.com>
 <f9e3ee95cdc2de810687a9c71f1a9f8d8fdbeac1.1698295861.git.philipp.g.hortmann@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f9e3ee95cdc2de810687a9c71f1a9f8d8fdbeac1.1698295861.git.philipp.g.hortmann@gmail.com>
Precedence: bulk

On Thu, Oct 26, 2023 at 07:44:24AM +0200, Philipp Hortmann wrote:
> @@ -1614,7 +1610,7 @@ static void _rtl92e_rx_normal(struct net_device *dev)
>  		skb = new_skb;
>  		skb->dev = dev;
>  
> -		priv->rx_buf[priv->rx_idx[rx_queue_idx]] =
> +		priv->rx_buf[priv->rx_idx] =
>  								 skb;

I really like how you split these patches up.  Like there was a bunch
of different ways to do that and you chose one which made it so easy to
review.  You made the right choice to avoid touching unrelated white
space issues.

But could you send a follow on patch to move this lonely skb back with
his friends?

regards,
dan carpenter