Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38;
From:   "Rong.Chen" <rong.chen@amlogic.com>
To:     Ulf Hansson <ulf.hansson@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Jerome Brunet <jbrunet@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-mmc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
        Rong Chen <rong.chen@amlogic.com>
Subject: [PATCH v2] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
Date:   Thu, 26 Oct 2023 15:31:56 +0800
Message-ID: <20231026073156.2868310-1-rong.chen@amlogic.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sb/egRTSWN2tuvHtqV2hu7yWgnY0F+drAWI78vJ/5ezVZA8eYR7aPJ67uzNq?=
 =?us-ascii?Q?IZjPtkjivd2cl350UXGGG7vZLXEM+5zGEgo/suIo04hn2v5m+iUAouXT0pux?=
 =?us-ascii?Q?OCOneJ9QlpwNlRGVc0Sw6J1FiBu2Szr7FCJNCkdVzkYki23Xme1wvBONnH5i?=
 =?us-ascii?Q?B5hWxYrW6xwIyNT/gn1WVN9pdgB0SdYW+zxzT+5wkFW3cfYhTgzD1lYfPUA7?=
 =?us-ascii?Q?rvwIoAhvDeteW4Sy2kit0RzlX83z0V8vsu1JLczt/MiP+YAygDiMHxeB5nd/?=
 =?us-ascii?Q?qMbGRFXVM+Fpyfjr+ZoW2yvw6Zrw6bJnSfmZEtCsCH11QTwKMbO3N4dcI+59?=
 =?us-ascii?Q?SQ9yGE/jcYIFyAN0hilqVclccAXhG1RCCTo5sdZzmQQLt85s9MASksANqDTJ?=
 =?us-ascii?Q?yXlwUFDih3hgjPNlcVBTwDMSZ8bMWiCsDKSc1vMlcgAI4F3uHThRJ0mzoMDs?=
 =?us-ascii?Q?hv/vHixw/IMurw0rR9QDD8CsMib9AwVm3KQkq42L9k0p+l+xwJbvqnkpUMLi?=
 =?us-ascii?Q?XGqwyiR6x/8gt8BEcRedJJwTlBuAdy6oiTdeSgnLYTkcjpfXMy7y2+UuoJ8j?=
 =?us-ascii?Q?OvZrF0KzvVlU4jG8FJx2wgjtks9Q0O8imsKALQcr1DMfup7bDRVARtxGgzNT?=
 =?us-ascii?Q?fIa1lWwOcoHWETxFyPrdaAllg20WsMyZi0+1f9LaGTn/J2XqJU97bvcl35o2?=
 =?us-ascii?Q?JoLhWiLCrdRERHmvOXhtb8gZrFf23IA5qQN/+n2m8yyhuImNxlblVjgk2ukG?=
 =?us-ascii?Q?RPrFd5ekhXMbDArHmF5i6XpZ12DlnroGmEVNPKPireBVtwQpSM6ejW+IL3eh?=
 =?us-ascii?Q?DLJpYw5mIfHXtbrgMIUpU0RveUcknPWJj21PZI8HgrNKjkwGE8ViW9Dyrmy2?=
 =?us-ascii?Q?Act+RzLMs5H0i+N7aS1HukvW68vGzC8oy5HL3h8timUSC5lQ6bsOgQrqQLwC?=
 =?us-ascii?Q?7R9zuV7AHVVF+Pn2vgI1xyPGEl6diToakYCSyzCamPO3FFA9m9B/90mpwQvz?=
 =?us-ascii?Q?o1oshlrL6yR3ojbOLH+jMVE+WBZvJHvdSr8S5BlTgJtwssWrDJOutYCIDW/S?=
 =?us-ascii?Q?o1Yoz8dGFQq15N5i/ZIxTWRIg/lKE5hgq+/f5CNvChYtp5WLjRsCDDncZtae?=
 =?us-ascii?Q?wYRayrUzGHqUBrh5bIBoHPhlG0AFvJ4rsxtDpqmno7ljmgaT/Mc46gTQNcFS?=
 =?us-ascii?Q?0vTjCuF3i0Vuhe5yTAfYcslEuoJu5WBMHxB7EgPo+vQ44JR2l+S7U/bAPfmN?=
 =?us-ascii?Q?7X5LKRZ5RhTtnwTN9vFHBrWpDH1+UqQhX+s4pf9VQ7KC4rLKv6ARgHgzIbq5?=
 =?us-ascii?Q?Pg20RVUxDU0K8RPWcnuncm7/1jnb2BwgcOw+ev2dxjB3gp1hDkuhXEhW/KFK?=
 =?us-ascii?Q?SWwQxJtDR7ViOIXVNIMRIOcG5byzmUhKeermAayktw9kzdGRsHyJ2k+rlbgQ?=
 =?us-ascii?Q?5wpzgD1YbymNG8Dd0H+Sj/+GX0znTxsYXi9Q9Oc7z28OQo8Dj9OUO5KLm74a?=
 =?us-ascii?Q?PSWg8jYmPLbcpYtfBwa2S8P7sdto/SgE5nFpHxxEzMCKyRfj85z7MijxMY7h?=
 =?us-ascii?Q?10uvuHjjXa0aE98CPSQiuQu5pLWF9Rzf42chVWEFRy0gKBoMXYYKxkcvMYaG?=
 =?us-ascii?Q?rA=3D=3D?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dd02db07-2199-4393-357a-08dbd5f5a8a0
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5939.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 07:32:08.5250
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yCslIWsvkbIswQOIbvlGsROXFg/pJngLA6PPgXB8sHlBH+Snhf3yEd5p02HYV03b4fAPe9X/Ug+/2M1eNNAW9Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR03MB5830
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 26 Oct 2023 00:32:24 -0700 (PDT)

From: Rong Chen <rong.chen@amlogic.com>

For the t7 and older SoC families, the CMD_CFG_ERROR has no effect.
Starting from SoC family C3, setting this bit without SG LINK data
address will cause the controller to generate an IRQ and stop working.

To fix it, don't set the bit CMD_CFG_ERROR anymore.

Fixes: 18f92bc02f17 ("mmc: meson-gx: make sure the descriptor is stopped on errors")
Signed-off-by: Rong Chen <rong.chen@amlogic.com>
---
 drivers/mmc/host/meson-gx-mmc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
index 9837dab096e6..c7c067b9415a 100644
--- a/drivers/mmc/host/meson-gx-mmc.c
+++ b/drivers/mmc/host/meson-gx-mmc.c
@@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
 
 	cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
 	cmd_cfg |= CMD_CFG_OWNER;  /* owned by CPU */
-	cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
 
 	meson_mmc_set_response_bits(cmd, &cmd_cfg);
 
-- 
2.42.0