Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33;
Message-ID: <7c81e31f-3ece-4a95-80db-dfe7fcd4de0a@amlogic.com>
Date:   Thu, 26 Oct 2023 15:40:31 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
To:     Jerome Brunet <jbrunet@baylibre.com>,
        Ulf Hansson <ulf.hansson@linaro.org>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Kevin Hilman <khilman@baylibre.com>,
        Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc:     linux-mmc <linux-mmc@vger.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-amlogic <linux-amlogic@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <20230927072544.764285-1-Rong.Chen@amlogic.com>
 <202309271651027503622@amlogic.com>
 <1jil7wkl39.fsf@starbuckisacylon.baylibre.com>
From:   Rong Chen <Rong.Chen@amlogic.com>
In-Reply-To: <1jil7wkl39.fsf@starbuckisacylon.baylibre.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?N0RjV0dLUzdOYVZleHNPbWxZZk85anhVZjJCRXhSeEJ1bkttT3FucEZZTzFz?=
 =?utf-8?B?K0hTeXBhTWlJVTVRQkJHaWZmM2ZnSk9QL2ZjMG1FQ1NQcVFVV1NvS2Z2a1FZ?=
 =?utf-8?B?VUk4MmJIaVdRZUlBam1XRlZUNkh6YTlxTGVWcmdMMFQ2Z2JCRjRIY08rQXMr?=
 =?utf-8?B?ejJnZWlXSXpPeTFLN05SZjdmWi9wYnU1TytXNmtFRHdXQm1iUldqa2I4N1Er?=
 =?utf-8?B?bkdOZW9aU1BzK1M0Z2VmeFdzb2FxZmtwVDBlNnBzdk1rUGtiRGdVamNYL3VF?=
 =?utf-8?B?QVZFZ1dMbDdaQXJlS3BRaXFDRHRDWUVlWnZQNTBvb2p0eTFRSHFJOFVhMmJn?=
 =?utf-8?B?VU8vSHJyak9WekwxM1JrWnRjbm5lQ1pDMjJzQ1drV2hQZWdyeUZNTy8wWSsw?=
 =?utf-8?B?bWljSDQ0WWJBd0pZV2VDTEw0OEVnb1RUK21adVZaaDMrMWszcWg2Ymt0Z1ZV?=
 =?utf-8?B?YW4wWXVsS2l0QzF3TzluM3RqenVWTGFaTDI0THNPaWZYQ29kWVFWQytTNXdP?=
 =?utf-8?B?QVFMaW93d0xFb2owdUhMMWczN2pFZW5vcGx5b3lGMjFZS1VDM3BLN3ZUenNo?=
 =?utf-8?B?akV3NUtmdU9xRnNyb3krVmRZRjM1alhFYjNYR055SmdvMlZDMDlaZmhuck01?=
 =?utf-8?B?R1FPVG00aDcvN0s5bXgvMzZNUjY3c1pydW5pc0YzNmZnM2NRcWlXTDhtTTgr?=
 =?utf-8?B?OWNRVjdJM2hWRldVRndHWHdJajNCWFhGeTh0K2hBKysrY3dIdTB4OFVtc0pE?=
 =?utf-8?B?bzZpeTdaQnJrVUJBcW5kWUVtK1p0N3U0WGZZeWd0QnJJWWVuTXZRZ1B3Z2Jh?=
 =?utf-8?B?ZW9zMHBtOTNERVZFN2xMYkdtb0J5N255ZUlzaCthL1ljZkhhaG1nSy8zNUho?=
 =?utf-8?B?R1ZiSTVjOU9WS0xXUFVsRVZ1aEdVY1kwTnR4cTFSMC85MlNLOEt1TGlnL05G?=
 =?utf-8?B?b0Q4b1ZhUldodnlaTm1kTlc5Yk9sS1QyQWQ5dmhDaGVma0lsQ2xNaXRqNWRi?=
 =?utf-8?B?LzNjYXNpanZNOU1CSjhRd1BLTnlXNkVFSWJPS2VnNjBzaFo2T21adUFrcnNX?=
 =?utf-8?B?amRhMEdJcXVLZWxHOVZNajAvZUZISDBFd040L29TbDF2c2tzT3ExcGh2aTJq?=
 =?utf-8?B?R0lqQUVGRHpReE9Bc29aN3NEblF6OExLQ0pVL0laYno5Nm8wd1lZQkJTRWhX?=
 =?utf-8?B?N0Fjc21VU1JjWVFQbnEvWEIyUk42eHdxOXh4d3JLeUg5TU1aVzhlclV0bGgx?=
 =?utf-8?B?UXlwaUdpWlphcVhpVjFzaWpPZWlFSVp1Mko3d2ZFL3l2OFU4azJxVXNoWFp2?=
 =?utf-8?B?QUorT2Jxdm9WMk0wUVhPS0t1VHZwUGMxaWJLUjE4VXY5bVZmVXpIZytzSEJx?=
 =?utf-8?B?eEFVNTdIK2o2Nk9aSTZ6SnIwUDZsM2FZamR2SlcwYWNNbmxRR0E2S3RNclB3?=
 =?utf-8?B?alZudTIyWTVBdThmbUs4RGVHRGJwREZoS3FXUmlNUU1CMkRMTHZ6VGczaVIz?=
 =?utf-8?B?dUlZV2VvbDV0S1R4RjdlSnFqTDdZcDZsMEd5MnMzMjRZU0FmT1YxR0VSTGkw?=
 =?utf-8?B?T0ZHZDhORE9MT0hmN0NEZkxoeml0dWg4TzdoQkZaN3R2Nkl0RVZXd0diSVZ1?=
 =?utf-8?B?Qk16cDkzWjdYTnpOSXlMMmZvUEhTT1RzWmZ4OXBhQTF5T0Q0NHF5MWViOG15?=
 =?utf-8?B?bjZ4S0gxVGx5dnZGTzNxRFdDR1NTbGhRTnRhNmkvbVdIVGJIUldjNWE5SEo0?=
 =?utf-8?B?THY1Y2dvNVJLUzFjVHNyOFErTVVXdHVqTnhJOC95YUdSWUQxdUtKRnlXamlM?=
 =?utf-8?B?a2ZlWFFaeGV0aEttOUc0VUlNUFd0WUZsVFBqTmdyaHJ5L1loYmpnaHY4Ykh6?=
 =?utf-8?B?VThYdmNVQzdQVEswa28yQ0dXdldzQUd3TG50bDhmQnNOak5IdmlZam1sdDBu?=
 =?utf-8?B?dUt3U0xtZEV4UWFMSmZGSlA3dnRqb2lReW01dWU2YXVRYmJtYk9XcFRJaEZp?=
 =?utf-8?B?b2ZMTEJpSHpBNVR1UmtHQ2VDeEJuR05iSmJ6bVBwak51RGQzNEJKMjZFTEpk?=
 =?utf-8?B?b0M2K1QzS3Zna0s3UUVpam9uZk0wVDR4dkhQV1ZKbnBpcTF0c0JHL0JiVmpX?=
 =?utf-8?Q?sucqJj40TUcZasRLzsBOMFTlH?=
X-OriginatorOrg: amlogic.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 10cce0aa-cbe1-44dd-6d60-08dbd5f6d7fb
X-MS-Exchange-CrossTenant-AuthSource: TYZPR03MB5939.apcprd03.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Oct 2023 07:40:36.6868
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 0df2add9-25ca-4b3a-acb4-c99ddf0b1114
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JhFNyW2fLvzPpdTMbVtXypJNz6stMWSWXSbkRzUQrNk9wqjZLIbrH/zcUEZIwjdgFKJ/AdUecZWsMoOlcdPJJA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR03MB7503
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 26 Oct 2023 00:41:46 -0700 (PDT)

Hi Jerome,

I tested on meson-g12a-u200 and meson-sm1-sei610 board successfully.

*meson-g12a-u200:*

[ 1.308436] mmc1: new HS200 MMC card at address 0001 [ 1.309223] 
mmcblk1: mmc1:0001 AJTD4R 14.6 GiB [ 1.314724] mmcblk1: p1 p2 p3 p4 p5 
p6 p7 p8 p9 p10 p11 p12 p13 p14 p15 p16 [ 1.321724] mmcblk1boot0: 
mmc1:0001 AJTD4R 4.00 MiB [ 1.325727] mmcblk1boot1: mmc1:0001 AJTD4R 
4.00 MiB [ 1.330427] mmcblk1rpmb: mmc1:0001 AJTD4R 4.00 MiB, chardev 
(511:0) [ 11.368251] platform cpufreq-dt: deferred probe pending [ 
29.695649] mmc0: new high speed SDHC card at address 0007 [ 29.696402] 
mmcblk0: mmc0:0007 SD16G 14.5 GiB [ 29.708053] mmcblk0: p1 [ 48.132967] 
mmc0: card 0007 removed

*meson-sm1-sei610:*

[ 1.815416] mmc1: new HS200 MMC card at address 0001 iled:[ 1.819542] 
mmcblk1: mmc1:0001 016G30 14.7 GiB No such file or d[ 1.826207] 
mmcblk1boot0: mmc1:0001 016G30 4.00 MiB [ 1.831692] mmcblk1boot1: 
mmc1:0001 016G30 4.00 MiB [ 1.836250] mmcblk1rpmb: mmc1:0001 016G30 4.00 
MiB, chardev (511:0)

[ 5.857437] mmc0: new high speed SDHC card at address 0007

[ 5.858046] mmcblk0: mmc0:0007 SD16G 14.5 GiB [ 5.869727] mmcblk0: p1

[ 9.958449] mmc0: card 0007 removed


在 2023/9/27 17:30, Jerome Brunet 写道:
> [ EXTERNAL EMAIL ]
>
> On Wed 27 Sep 2023 at 16:51, "Rong.Chen@amlogic.com" <Rong.Chen@amlogic.com> wrote:
>
>> Hi Jerome,
>>
>> Socs containing previous controllers are gxl, gxm, gxbb，g12b，g12a，sm1，axg, a1，s4 and t7.
> That is mostly all the SoC we know of in mainline ... This why the way
> you explained is confusing.
>
> And below, you say 'on latest controllers', okay but which ones ?
>
>> The bit CMD_CFG_ERROR is used for selecting SG LINK of data address on latest controllers，but
>> data address don't use SG LINK at present，so it will cause an IRQ and stop working on latest controllers.
>> Therefore, remove this setting.
> Not totally sure what SG LINK but okay.
>
> While the change itself is fine you really need reformulate the description.
> Based on your explanation, something like:
> ---
> For the t7 and older SoC families, the CMD_CFG_ERROR has no effect.
> Starting from SoC family XYZ, it will select SG LINK on error but this
> is causing a problem with the data address ... blablabla
> ---
>
> Please expand a bit on this, try to make it clearer.
> Also, please insert the proper fixes tag
>
> Last, make sure tp reply with plain text emails, otherwise lists will
> drop your reply and please do not top post.
>
> Thx
>
>> Thanks.
>> -------------------------------------------------------------------------------------------------------------------------
>> Rong.Chen@amlogic.com
>>
>>
>>   From: Jerome Brunet
>>   Date: 2023-09-27 15:43
>>   To: Rong.Chen; Ulf Hansson; Neil Armstrong; Kevin Hilman; Martin Blumenstingl
>>   CC: linux-mmc; linux-arm-kernel; linux-amlogic; linux-kernel
>>   Subject: Re: [PATCH] mmc: meson-gx: Remove setting of CMD_CFG_ERROR
>>   [You don't often get email from jbrunet@baylibre.com. Learn why this is important at
>>   https://aka.ms/LearnAboutSenderIdentification ]
>>
>>   [ EXTERNAL EMAIL ]
>>
>>   s
>>   On Wed 27 Sep 2023 at 15:25, "Rong.Chen" <Rong.Chen@amlogic.com> wrote:
>>
>>   > From: Rong Chen <rong.chen@amlogic.com>
>>   >
>>   > Setting bit CMD_CFG_ERROR has non effects on previous controllers.
>>
>>   Which previous controllers ? v2, v3 ? Can you list the SoCs please ?
>>
>>   > However, it will cause an IRQ and stop working on latest controllers,
>>
>>   Isn't it desirable to stop on error ? seems like a sane thing to do.
>>
>>   > This bit is used for selecting SG LINK of data address.
>>   > Don't set the bit CMD_CFG_ERROR anymore to resolve this issuse.
>>
>>   I'm not sure I understand the actual issue being resolved.
>>   Could you provide more details please ?
>>
>>   >
>>   > Therefore, remove this setting.
>>   >
>>   > Signed-off-by: Rong Chen <rong.chen@amlogic.com>
>>   > ---
>>   >  drivers/mmc/host/meson-gx-mmc.c | 1 -
>>   >  1 file changed, 1 deletion(-)
>>   >
>>   > diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>>   > index 9837dab096e6..c7c067b9415a 100644
>>   > --- a/drivers/mmc/host/meson-gx-mmc.c
>>   > +++ b/drivers/mmc/host/meson-gx-mmc.c
>>   > @@ -801,7 +801,6 @@ static void meson_mmc_start_cmd(struct mmc_host *mmc, struct mmc_command *cmd)
>>   >
>>   >       cmd_cfg |= FIELD_PREP(CMD_CFG_CMD_INDEX_MASK, cmd->opcode);
>>   >       cmd_cfg |= CMD_CFG_OWNER;  /* owned by CPU */
>>   > -     cmd_cfg |= CMD_CFG_ERROR; /* stop in case of error */
>>   >
>>   >       meson_mmc_set_response_bits(cmd, &cmd_cfg);