Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Date:   Thu, 26 Oct 2023 10:19:11 +0200
From:   Borislav Petkov <bp@alien8.de>
To:     Muralidhara M K <muralimk@amd.com>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        mchehab@kernel.org, Muralidhara M K <muralidhara.mk@amd.com>
Subject: Re: [PATCH v2 2/4] x86/MCE/AMD: Add new MA_LLC, USR_DP, and USR_CP
 bank types
Message-ID: <20231026081911.GEZTog/4+zbd2wRK6u@fat_crate.local>
References: <20231025051455.101424-1-muralimk@amd.com>
 <20231025051455.101424-3-muralimk@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20231025051455.101424-3-muralimk@amd.com>
Precedence: bulk

On Wed, Oct 25, 2023 at 05:14:53AM +0000, Muralidhara M K wrote:
> @@ -119,6 +120,8 @@ static struct smca_bank_name smca_names[] = {
>  	[SMCA_SHUB]			= { "shub",		"System Hub Unit" },
>  	[SMCA_SATA]			= { "sata",		"SATA Unit" },
>  	[SMCA_USB]			= { "usb",		"USB Unit" },
> +	[SMCA_USR_DP]			= { "usr_dp_pcs",	"Ultra Short Reach Data Plane Controller" },
> +	[SMCA_USR_CP]			= { "usr_cp_pcs",	"Ultra Short Reach Control Plane Controller" },

Why aren't those strings "usr_dp" and "usr_cp" too?

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette